From patchwork Thu Nov 27 02:37:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25242 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 107D8C32DE for ; Thu, 27 Nov 2025 02:37:59 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A94C560AA3; Thu, 27 Nov 2025 03:37:58 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="B8dlZb+v"; dkim-atps=neutral Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4A66460AB3 for ; Thu, 27 Nov 2025 03:37:57 +0100 (CET) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-4779adb38d3so1789925e9.2 for ; Wed, 26 Nov 2025 18:37:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764211076; x=1764815876; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mt8VuycA4JtISYG1OMwP/mShybOjaHrIEZw7TC7UHZg=; b=B8dlZb+vi/Ay031On+rNdj2DvCD2bItylXo0jzsudJjv8/OOHF6bUN7Y3FCzbXpDvg ViYDiwB3ZKmWUEdJYJAKxrgLtJdVbqXl2prgTuMAwgTDuWdCZl2yC0SErPw8Df3cyBCl SgGtTI+8MnWcOaF3oPCdYYDnZ6qQF1nHPETpxp02XB/uXCWqtj0/WOKRhXxVaI1qKP1h 7HjSGrOQq/VnvP5MFi3AcdZrYMdKJKJZjhxPwPXbtpHwW8OoRI7WTnKE4hG9hOOmLicN PQD/2sswinHyHO4pxdIL/VHo5KaRo58y56Gc/m1Xe95OPnxBta5Emc0e0jZYyIOdJOZL mVjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764211076; x=1764815876; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mt8VuycA4JtISYG1OMwP/mShybOjaHrIEZw7TC7UHZg=; b=xUXtBk3pded9qS7fk0XZyAMSf4VOxkMyPHbBBTHypJmfNqnB/VMkk7HayDYbyLtplT W42uOdjZoLM7ILxke9VfBDjrEpDh5k3vp5zlXjsjeIMXYgbK7SKeEILFaww+paOBmFkC xHz8Vtafuh3KsX/hziMSRAIgrVwjs4oqepqwQLL9jlzA1iA7pH/McQm/U/+ujkRE+A5y 4LilcXRY1TknYBUIAnkV3Av7sCyhRJZl+M4/DiD/xYndD9yinqM4J9zbHN9jmdNNUk9U k1ab4dO5v5GQgpMK0KNydtik65YYA3gh6VJgqyphey5Z8rFCSfPepK0OgGhXD/E5nI4h kaEw== X-Gm-Message-State: AOJu0Ywxh9WL04QT1jR3RymkqAEFA4OyfXzWECQ3juZ/Uz2JveuQTpYJ r+PDiJJnlsFz6J2j/VOArLvKhfG/OIYz1isIQ/fR7USKEErX7B8clQ1jkkm6M+BYg5pRJZCK2Fp lfhsb8f4= X-Gm-Gg: ASbGncvU5bRgbE/65FZQIgTUXdMgvuOumxFKZbUr2w31jAphypEqm/BWd9cb/vs88TQ BuJR64cLL+z/BkrXUFkPD/6BI57RX3ohKEG5o2QrETtiauBKp0tnrLyPuo6mFjEwoIGqkPwHXSe Ut5cNG0SsJ4Gr99qzfoYEc+TlWN2WCokLlIDeKr3X6ITDIrXUjEvxPwuPCuRhw9g6/fwoNFY1vO mpMP4klii2V8sUA4SQ11VvjaCx00C8wwZ7kLtMCf6vvJQD2xRyLvDjFbmsjoL68m7Uq6aoVMqmL OwQr9d7fV2Zo3rc+CM4SOl0+0RKQnm+8YCKzj3PO5gz6wNkSelFshzPvGAKlIFyTVUCFj6+i3Ke pwL3aW91kdYm+aYPNX7b09M3iD1VQM0e30B1Y/eGXyWYaV995pGgIzxhv54zf6KdlLUNKY6BO3G NTXrBpt6Glgy8hlXKrt/ctBIGdAS/4mTG/rTlcIx9KCHFleJVpRhxYAGojKCjlUDd6oNA= X-Google-Smtp-Source: AGHT+IGq2QWxaAkfBfeUaCBFNkzwKce5lSkNq+FVdton/7mygJouvmW/lA/LWh+KA6euzoZJLwsxbQ== X-Received: by 2002:a05:600c:1c0d:b0:477:9a28:b0a4 with SMTP id 5b1f17b1804b1-47904a6867fmr102638375e9.0.1764211076603; Wed, 26 Nov 2025 18:37:56 -0800 (PST) Received: from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4790552c3c9sm58186345e9.0.2025.11.26.18.37.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 18:37:56 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Bryan O'Donoghue , Kieran Bingham Subject: [PATCH v5 05/24] libcamera: shaders: Use highp not mediump for float precision Date: Thu, 27 Nov 2025 02:37:20 +0000 Message-ID: <20251127023739.179652-6-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251127023739.179652-1-bryan.odonoghue@linaro.org> References: <20251127023739.179652-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" mediump gives 10 bits of mantissa as the resolution. At higher resolutions 10 bits of accuracy is insufficient - for example at a width of 1928 bytes we need log2(1928) = ~11 bit resolution. Switching to highp gives us 23 bits of mantissa giving a sample width precision of about 2^23 ~ 8,388,608. Acked-by: Kieran Bingham Signed-off-by: Bryan O'Donoghue --- src/libcamera/shaders/RGB.frag | 2 +- src/libcamera/shaders/YUV_2_planes.frag | 2 +- src/libcamera/shaders/YUV_3_planes.frag | 2 +- src/libcamera/shaders/YUV_packed.frag | 2 +- src/libcamera/shaders/bayer_1x_packed.frag | 2 +- src/libcamera/shaders/bayer_unpacked.frag | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/libcamera/shaders/RGB.frag b/src/libcamera/shaders/RGB.frag index 4c374ac98..724395894 100644 --- a/src/libcamera/shaders/RGB.frag +++ b/src/libcamera/shaders/RGB.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/src/libcamera/shaders/YUV_2_planes.frag b/src/libcamera/shaders/YUV_2_planes.frag index 1d5d12062..d286f1179 100644 --- a/src/libcamera/shaders/YUV_2_planes.frag +++ b/src/libcamera/shaders/YUV_2_planes.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/src/libcamera/shaders/YUV_3_planes.frag b/src/libcamera/shaders/YUV_3_planes.frag index 8f788e90a..8e3e0b4a5 100644 --- a/src/libcamera/shaders/YUV_3_planes.frag +++ b/src/libcamera/shaders/YUV_3_planes.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/src/libcamera/shaders/YUV_packed.frag b/src/libcamera/shaders/YUV_packed.frag index b9ef9d41b..3c9e3e397 100644 --- a/src/libcamera/shaders/YUV_packed.frag +++ b/src/libcamera/shaders/YUV_packed.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag index f53f55758..19b13ad08 100644 --- a/src/libcamera/shaders/bayer_1x_packed.frag +++ b/src/libcamera/shaders/bayer_1x_packed.frag @@ -20,7 +20,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif /* diff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag index 7e35ca88e..aa7a1b004 100644 --- a/src/libcamera/shaders/bayer_unpacked.frag +++ b/src/libcamera/shaders/bayer_unpacked.frag @@ -16,7 +16,7 @@ Copyright (C) 2021, Linaro //Pixel Shader #ifdef GL_ES -precision mediump float; +precision highp float; #endif /** Monochrome RGBA or GL_LUMINANCE Bayer encoded texture.*/