From patchwork Thu Nov 27 02:22:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25235 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 0ACF7C3260 for ; Thu, 27 Nov 2025 02:23:53 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B6C1C60B37; Thu, 27 Nov 2025 03:23:52 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="eP/IYhlM"; dkim-atps=neutral Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 87FF460B2F for ; Thu, 27 Nov 2025 03:23:48 +0100 (CET) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-47774d3536dso2787165e9.0 for ; Wed, 26 Nov 2025 18:23:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764210228; x=1764815028; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I8jixvijd6gJLN+QzpL1b1w727QQZ88ZES2h9Mcjbmo=; b=eP/IYhlMzocDjxBGFH4R7PC3DeMsllYvA0+kON4gYtfgaQauBuXKwLmcObwz/8eUf8 k+/A8nB+9DkJ49LWsBmbnDgfBa5K1Vleq4EPQyi+R2+NLGus+USswrDpYdHtv+BpDnY1 a2jTMBLnbfY2MO/iq5xL0240hArSXOB3dQOouTRoasifbsHvEO/5McmKmej5ww8Yy59b IRHttd/zN9hLimQugOn0XO2VR0f6pbV5dLag4jib9GyPmEPNFQ6eKx+XC2Cfgr4JKSEe y0AZk6HbQcwYloWK25eIAms4jrsCFPOxzI3ePLV9V6COVYOd8DUuDfr3q/sR1NfE1YvW oddA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764210228; x=1764815028; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=I8jixvijd6gJLN+QzpL1b1w727QQZ88ZES2h9Mcjbmo=; b=YddmhZdWiA7UAzwN953HZijZwmU6dECPoc/u6fUzsvFuX5cuWOqOMQ1I6JqF9TnWjg BJVgf8+Oc24pFizhDWlbzjVilG5kYkrNbHdu2Vp6W6/YPqPeIvjav4RJBjwwicvoZcBc PDUvVTxh+lV/q++IechqiR3QVKbvz0+BnQkkNhjDF3gf575YpuKazkiufID8nNThQZGy mVjMutLyyq/i/IJE+RGPDfA5rbrHKv5K6Ao/L8dLNJOUuqJ0qDVUjY4ugAheT0v4fMK1 4KlbQj/Y8edg9b5NDGDAEOuM7RF1tFlFPcFPRXMbSRje+Yxnu83JRfGIviZFK0kpR+Jw 69Gg== X-Gm-Message-State: AOJu0Yz3g6oUF4aHmpsU3ZFZuyzp0lUsuJLEh+YlriZ6saoVL3IEUTuJ xuNwlzZ4oCQp2Y80gsq2RiHULwI806TStKDEASz2Uas0kghUi6GSUfunA0qtxkSVeRHLV9sWiJ+ wjh6cjJQ= X-Gm-Gg: ASbGncte4ppeLXmmvUzPE8KpGfB8qDEIQLu2LgjVCN/Z/dzOVeYmi5HOKFmYMMxOzUk RhWDkrVodtFSOXTuTdJyfY6qmaWTraec1sCXuU3/rrlbi13REyjEJ4QR+A1hiw9IKRk/u698kjy ZraBO5DZOjZpqlbQaD6MACFE+78S9AtF/Ph6lnMsFqDMlj94nxcvLpVIs2WsLWIb0I0mMB+bNBS Qgt8m6lkItX1LiSCcpVrOjzQK0mQvvh+lDD7t3X+U4hxQgQz7Aj/DKnZAX+8FCJgFeRSoBmdHoD S57unN2eAgXt85mK+O1OJCcgDUrIxchTiu8hn1om1cjzC+ECiPA5EHnj1MhEAVW8r9rBZxLD6La xQr/JBKO/gUfM3ZkemTkRI9WSsy9V86rC18DZ5rfhNwOtWz+xFitXMPE+mF+VZyLTRPBVIC78rs JZA7G+RJrUBJZyu+/DkbUTauSxyWp9n74qGnsqzSoZcdqhY1OzF9knrZh0slWqpp6LnUM= X-Google-Smtp-Source: AGHT+IEzzJOoT/BNeqJ1COeUoWLOThiDZAq87waMjXYINNIB5nsBh3V8JBlvLUqXuG7PUFhFrKGkQQ== X-Received: by 2002:a05:600c:314d:b0:477:9890:9ab8 with SMTP id 5b1f17b1804b1-477c04c3593mr215473345e9.3.1764210227921; Wed, 26 Nov 2025 18:23:47 -0800 (PST) Received: from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4790b0e21e8sm71549495e9.15.2025.11.26.18.23.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 18:23:47 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Bryan O'Donoghue , Milan Zamazal Subject: [PATCH v2 21/22] libcamera: software_isp: lut: Make gamma from lut.cpp available in debayer params Date: Thu, 27 Nov 2025 02:22:53 +0000 Message-ID: <20251127022256.178929-22-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251127022256.178929-1-bryan.odonoghue@linaro.org> References: <20251127022256.178929-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Provide the gamma used in IPA to Bayer parameters. We will pass Gamma into the shader via a uniform and can then tweak that value from outside at will. Reviewed-by: Milan Zamazal Signed-off-by: Bryan O'Donoghue Reviewed-by: Kieran Bingham --- include/libcamera/internal/software_isp/debayer_params.h | 1 + src/ipa/simple/algorithms/lut.cpp | 2 ++ src/libcamera/software_isp/debayer.cpp | 5 +++++ 3 files changed, 8 insertions(+) diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h index 5a0d9438f..d5dad1a98 100644 --- a/include/libcamera/internal/software_isp/debayer_params.h +++ b/include/libcamera/internal/software_isp/debayer_params.h @@ -58,6 +58,7 @@ struct DebayerParams { */ Matrix ccm; RGB blackLevel; + float gamma; }; } /* namespace libcamera */ diff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp index 49482d711..ea5a86b20 100644 --- a/src/ipa/simple/algorithms/lut.cpp +++ b/src/ipa/simple/algorithms/lut.cpp @@ -147,6 +147,8 @@ void Lut::prepare(IPAContext &context, params->gammaLut[i] = gammaTable[i / div]; } } + + params->gamma = context.configuration.gamma; } void Lut::process([[maybe_unused]] IPAContext &context, diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp index 1034912e7..8bcbd5dde 100644 --- a/src/libcamera/software_isp/debayer.cpp +++ b/src/libcamera/software_isp/debayer.cpp @@ -110,6 +110,11 @@ namespace libcamera { * \brief Blacklevel gains for the GPUISP */ +/** + * \var DebayerParams::gamma + * \brief Gamma value for the GPUISP + */ + /** * \class Debayer * \brief Base debayering class