From patchwork Thu Nov 27 02:22:36 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25218 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 8B043C3260 for ; Thu, 27 Nov 2025 02:23:16 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id DBA6060AA3; Thu, 27 Nov 2025 03:23:15 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="vSeHKphW"; dkim-atps=neutral Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 6E934609E0 for ; Thu, 27 Nov 2025 03:23:11 +0100 (CET) Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-477b91680f8so2521685e9.0 for ; Wed, 26 Nov 2025 18:23:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764210191; x=1764814991; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BYLFp48Jtlh28DV0l7WkmFCL3lrDfDHVbIKL8htzT4E=; b=vSeHKphWtBjwqNtxLIGKXnm9wfqSmDElHzmWyKjB3iKQhucA/WBBdhR3GtCYYdWTYJ Fk6NS6W183UHV3qZgmb8pfD/H2w60mdSdoymGczROk4aIDzX5ZFxBE7Z/3q2pJwq9yex i2KV1uJJau0A2JxOJHSXE+AqW1PUz6TaqaybbcOwY6kKoJ7vczftPErLWsH2nd0E6fe+ flwyQls7x390DFZY8dQ/Jc1LSsFLnDeJhv8K5RUoxNs14CCuhM1w0yGGXXGqfPyZzlbn Nla5r6gXm2R7k4/1hNraBZ9FAayMT5CM52/4P+o1JxJk6MjB1ZJ4bUIr0VeNNZlzRX1R PuTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764210191; x=1764814991; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BYLFp48Jtlh28DV0l7WkmFCL3lrDfDHVbIKL8htzT4E=; b=gsM9W0SY3AtFDcwV3XlBUtVZEcJnV5VLwlZfeSrtkPN0EwREFQC0K+SSENavdFHOmT Y7LRAxS8fERpt4hz+cbAAcy5e6cQkB9ST6tP4QefJb6m/1TXoSioJANYRgprujm0GRK1 /edEtVUruBAt1ZP9dE3zoKv5s9zVAGPAybmqQbOaW+nCNU+lxMPmWUuu4Qa9xdEltcPa LXL6xA2RNp5Ra5ELRIAUTg1N3D89qN7mXc86Hp8JHeiu0ANpjSBXJJiq1/g/2q/5LAD8 T7dhSJVRQRGvUlSE0lws+LK9hXeRpIubkRdbZXmdGhIOU6w+qsCe/8CEKnuBypYwymdD dLUg== X-Gm-Message-State: AOJu0YxiQ/FpiOJKJudJx8Q+DOkljD+q4j7uT2fPBNJ7ZnuIohleflS9 W8PwmP0gEk3u0dfnEqY0/es0MoVrQ+O4/OWE0SGQILZNEjlTlztCvdn6SPmmwEDQXvJGwQdfLVz m3uFAk8I= X-Gm-Gg: ASbGnctBj0GIiLZr1K3pZKT5EpivwjNU+7VcHbgDKTkjzX7Av9Xc76/7xDx2IZ/+Xii YjCTW1m+LeBRo91YXB4sq1mD6ee6tPql6DjPf9HNOyg7JZmSOOQ7QvxvOcdZzv1V3fNThPU+kbs 9jWCY73px1tjZmkS2q/OTz9zPLqt0pKsm/4seBnF0ZFSa4h/JSp7iGH/FaEXJ6cfXK05PCquEnl KxyENCRv1QFDLXxIOIZAlFEhzSYniPEIDL9G+LGnyMIk2+EzeNAS9Hi0ZLY0m7eVV4XOIrJe3s2 gQCAyx639AmgizWnzXpM2VHEVs9XXS3UakjBoBQRbJ1l6CMJZyodvxn7ilKVbgFkNm5qyg3c04s 2k3G3ouhnw0Ru8WRz4De6qXohznUPWyVLF2A2csNj5ANa83ymhNqoR34PIyR1t5JfwRv4f03uFN THOc7poZqG3XWrOlKW33Twu5nSW8J9Q3Xh35JafoT3H8/JhTxOdhb7ymAoR5lvz1IFq5Y= X-Google-Smtp-Source: AGHT+IHBz/3vtDnicqmetnkw42IdBF/8X5r27QL4RKG7YlAjPxsNYcs713zTv/NMssvNTVejPGNxKQ== X-Received: by 2002:a05:600c:3ba1:b0:475:dd89:acb with SMTP id 5b1f17b1804b1-477c11160cdmr221865095e9.22.1764210190788; Wed, 26 Nov 2025 18:23:10 -0800 (PST) Received: from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4790b0e21e8sm71549495e9.15.2025.11.26.18.23.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 18:23:10 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Hans de Goede , Kieran Bingham , Milan Zamazal , Bryan O'Donoghue Subject: [PATCH v2 04/22] libcamera: swstats_cpu: Update statsProcessFn() / processLine0() documentation Date: Thu, 27 Nov 2025 02:22:36 +0000 Message-ID: <20251127022256.178929-5-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251127022256.178929-1-bryan.odonoghue@linaro.org> References: <20251127022256.178929-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Hans de Goede Update the documentation of the statsProcessFn() / processLine0() src[] pointer argument to take into account that swstats_cpu may also be used with planar input data or with non Bayer single plane input data. The statsProcessFn typedef is private, so no documentation is generated for it. Move the new updated src[] pointer argument documentation to processLine0() so that it gets included in the generated docs. Reviewed-by: Kieran Bingham Reviewed-by: Milan Zamazal Signed-off-by: Hans de Goede Signed-off-by: Bryan O'Donoghue --- src/libcamera/software_isp/swstats_cpu.cpp | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp index 4f7bdd231..9c03338a0 100644 --- a/src/libcamera/software_isp/swstats_cpu.cpp +++ b/src/libcamera/software_isp/swstats_cpu.cpp @@ -72,6 +72,19 @@ namespace libcamera { * patternSize height == 1. * It'll process line 0 and 1 for input formats with patternSize height >= 2. * This function may only be called after a successful setWindow() call. + * + * This function takes an array of src pointers each pointing to a line in + * the source image. + * + * Bayer input data requires (patternSize_.height + 1) src pointers, with + * the middle element of the array pointing to the actual line being processed. + * Earlier element(s) will point to the previous line(s) and later element(s) + * to the next line(s). See the DebayerCpu::debayerFn documentation for details. + * + * Planar input data requires a src pointer for each plane, with src[0] pointing + * to the line in plane 0, etc. + * + * For non Bayer single plane input data only a single src pointer is required. */ /**