From patchwork Wed Nov 26 09:38:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 25210 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id F2857C32DE for ; Wed, 26 Nov 2025 09:39:12 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id BFE2760AA2; Wed, 26 Nov 2025 10:39:09 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="imqtkQT4"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 66DE9609E0 for ; Wed, 26 Nov 2025 10:39:06 +0100 (CET) Received: from [192.168.0.172] (mob-5-90-63-219.net.vodafone.it [5.90.63.219]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D3D386DE; Wed, 26 Nov 2025 10:36:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1764149817; bh=mDBl7Wvas50tmJkad3FT4JCKFaF+rjyT+QZXO++qVDc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=imqtkQT48inwC/Rc7J5kNUsXEAuRTCj+9p4E9ELw1OHOt5U0mJ4svknYb/+cOhli+ DV3z4deTu75yANMOgQCgxhPxGqJVWx1aI8NwRh2lpbCh+lznHFC6jVAaCSwr1PuoVY oVsLinN69WRNzCkJMxzkEauqIYXasywWrNRN2Cto= From: Jacopo Mondi Date: Wed, 26 Nov 2025 10:38:51 +0100 Subject: [PATCH v2 1/3] libcamera: request: Create control list with Camera info map MIME-Version: 1.0 Message-Id: <20251126-cam-control-override-v2-1-305024a1f190@ideasonboard.com> References: <20251126-cam-control-override-v2-0-305024a1f190@ideasonboard.com> In-Reply-To: <20251126-cam-control-override-v2-0-305024a1f190@ideasonboard.com> To: libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi , Kieran Bingham X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1562; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=mDBl7Wvas50tmJkad3FT4JCKFaF+rjyT+QZXO++qVDc=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpJsq5/h0OrfdHkCZS/yUyRM0i9tA7mHkGrCH9B V0Hv22d39SJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaSbKuQAKCRByNAaPFqFW PJBhEADEa3SE656Rtwv/v1CJkk7pgDhO6FLyWRSF7FbloTjyasiLYmqqN78YkRXCXPBGsv0waHy whcHUC6C97cZNZ57MX7gJEtf4KBqjQGuQpafHQ9qoaKS4J2GPlU+Dmn7Dd6dtXB+iCcKXiUREKm JzrPtHkxsGoho8h5XUCHpSoQfwlPfVxp66zssbhQ8gL1RelcqC1Dd3rSNtQoDkKEoC8dZAq3/Nt h8mP339Q/7mwtQQXZ18qSVywzSYTFrZU42qPAs5ylxvjR7rD7rn2Zj/pLuVwBBvk0thuJysX2Nk gJKjfOGs00h1iDAaRqwHrSCFF3jfXUu5K6ZR4c4HL2khsLC98lRFnm9cLeDZVEHlKu57Jl+bi33 pbNyg0n/OfMKFDPE3ABJh7kYArCfOEULwzCsVbx8vt71yxWDe2UMV/HJJrOTipMI5t+5nw8lnzS TkQzriyDRVHpGpIwYNVku5athpm+pU1OMu4xdst54nyVf0665wbi9ZRm2QDdHqidFC+Wa4AtBmW qS4wE73VEkwq9fZtY6Q7aYRLXSJ5cCifMQVCI3/yll6gjgTYpeR2CSlUBuDOIjeqdXdKKhC8YkJ ElpyVLmW4NoPQL2+CbQ1qFFkQ6Z7nVticIoSbszM2JoxQjdz6qHEAxlyYS9mwgzmiU4BfShw1iA X6+oknc9LWPNbzw== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The control lists associated with a Request is created with the global libcamera::controls::controls id map. This is fine as the idmap/info map used to contruct a ControlList are not used for any control validation purposes by the libcamera code. However creating a ControlList with the camera ControlInfoMap has two advantages: 1) The idmap can be extracted from the info map, but not the other way around 2) The control list is constructed with a valid map of info to the controls it can actually supports, instead of the global map of libcamera controls Initialize the ControlList part of a Request with the Camera control info map, as the association between a Request and a Camera is permanent and valid for the whole lifetime of a Request. Signed-off-by: Jacopo Mondi Reviewed-by: Kieran Bingham --- src/libcamera/request.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp index 60565f5984971c7ab34e119a15b8141799f71071..2544a059f6984d930ec909c74e0b621c9fe82726 100644 --- a/src/libcamera/request.cpp +++ b/src/libcamera/request.cpp @@ -356,7 +356,7 @@ Request::Request(Camera *camera, uint64_t cookie) : Extensible(std::make_unique(camera)), cookie_(cookie), status_(RequestPending) { - controls_ = new ControlList(controls::controls, + controls_ = new ControlList(camera->controls(), camera->_d()->validator()); /**