From patchwork Tue Nov 25 16:28:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 25208 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B3764C3338 for ; Tue, 25 Nov 2025 16:30:22 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 4CFCF60C6B; Tue, 25 Nov 2025 17:30:22 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="r3FHwVVU"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9D6FB60AA0 for ; Tue, 25 Nov 2025 17:30:20 +0100 (CET) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:bae1:340c:573c:570b]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id ABBDC13DE; Tue, 25 Nov 2025 17:28:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1764088091; bh=Ej4n1s7zWgywj6UeXPKqrRbpzpaHW3RxX4rYZ0woPQM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=r3FHwVVUBkVLgjbNJW5yyikyoh36+Rf+z33yfp+X/XznzByZGh7NBGMk5ieLJS8cM wqhUkdPh8o/dNUcQGpG6W5c/GQLAIxWYnu0ts4uqSqc314tQl5d3FyhXl7vLQ3HqAV 2PXhgIXvAM+XKbgjeN2EZRsSm4XJePd89c3+WK+I= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH v3 29/29] DNI pipeline: rkisp1: Workaround for customer kernels without requests Date: Tue, 25 Nov 2025 17:28:41 +0100 Message-ID: <20251125162851.2301793-30-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251125162851.2301793-1-stefan.klug@ideasonboard.com> References: <20251125162851.2301793-1-stefan.klug@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" There are a few kernels out there that have dynamic vertex map support, but no requests support. Allow full dewarp usage on these. Signed-off-by: Stefan Klug --- src/libcamera/converter/converter_dw100.cpp | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/libcamera/converter/converter_dw100.cpp b/src/libcamera/converter/converter_dw100.cpp index b39e4ab23cd6..22a15a368e38 100644 --- a/src/libcamera/converter/converter_dw100.cpp +++ b/src/libcamera/converter/converter_dw100.cpp @@ -33,6 +33,17 @@ LOG_DECLARE_CATEGORY(Converter) * and it has direct support for libcamera controls. */ +namespace { + +/* + * This flag allows to use dynamic dewarp maps to support pan, zoom, rotate when + * the kernel driver doesn't support requests. Only needed for legacy customer + * kernels. + */ +static constexpr bool kAllowDynamicDewarpMapsWithoutRequests = true; + +} /* namespace */ + ConverterDW100Module::ConverterDW100Module(std::shared_ptr media) : converter_(media), running_(false) { @@ -353,7 +364,7 @@ void ConverterDW100Module::updateControlInfos(const Stream *stream, ControlInfoM controls[&controls::Dw100ScaleMode] = ControlInfo(controls::Dw100ScaleModeValues, controls::Dw100ScaleModeFill); - if (!converter_.supportsRequests()) + if (!converter_.supportsRequests() && !kAllowDynamicDewarpMapsWithoutRequests) LOG(Converter, Warning) << "dw100 kernel driver has no requests support." " Dynamic configuration is not possible.";