From patchwork Tue Nov 25 16:28:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 25193 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E8B8CC333C for ; Tue, 25 Nov 2025 16:29:38 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 928EE60AB4; Tue, 25 Nov 2025 17:29:38 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="DsKPn+nv"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 94AF360AC4 for ; Tue, 25 Nov 2025 17:29:36 +0100 (CET) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:bae1:340c:573c:570b]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 9F7D86AF; Tue, 25 Nov 2025 17:27:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1764088047; bh=h3miCZmgaN6PDBGl9AKd+RDzNgW3R0M2XkJkpFniOyU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DsKPn+nvZcEDXxlDGKwe7sbtZZTAd1M/6lbirqy9gNNjqOhAeAh++PPM9rO/tUlc9 sDW+sE2gzoO8LXMz4+bFT/Wrz95nKg13hw0W26RRYwmhRCvl5dkgYzA5k+BA4yjknk SVy9NzsPK+P+yQMrJM377HM0mFRdr7zw9K+n2ha4= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH v3 14/29] pipeline: rkisp1: Fix number of buffers imported into the dewarper Date: Tue, 25 Nov 2025 17:28:26 +0100 Message-ID: <20251125162851.2301793-15-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251125162851.2301793-1-stefan.klug@ideasonboard.com> References: <20251125162851.2301793-1-stefan.klug@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" When the dewarper is used, an addition buffer loop with kRkISP1MinBufferCount buffers is created between ISP and dewarper. When the dewarper is configured, it stores the bufferCount value of the requested stream configurations. This number of buffers is then imported when the dewarper is started. On the input stream of the dewarper the bufferCount is currently left unchanged, meaning it carries the bufferCount as supplied by the user instead of the bufferCount of the additional loop. Fix that by setting the bufferCount to kRkISP1MinBufferCount. Signed-off-by: Stefan Klug Reviewed-by: Kieran Bingham --- Changes in v3: - Added this patch --- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index 79c8717c839a..138e1d5bf06b 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -954,6 +954,7 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c) if (data->usesDewarper_) { outputCfgs.push_back(const_cast(cfg)); + ispCfg.bufferCount = kRkISP1MinBufferCount; ispCfg.size = format.size; ispCfg.stride = PixelFormatInfo::info(ispCfg.pixelFormat)