From patchwork Tue Nov 25 16:28:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 25192 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B5BF1C333C for ; Tue, 25 Nov 2025 16:29:36 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 51C6B60ABB; Tue, 25 Nov 2025 17:29:36 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="QCrpfaAs"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5D2D760A9D for ; Tue, 25 Nov 2025 17:29:33 +0100 (CET) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:bae1:340c:573c:570b]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 70E17524; Tue, 25 Nov 2025 17:27:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1764088044; bh=54seuIsjJEBIcBROwnfmlkpCovzEqz1s9O3NMQZYXm8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QCrpfaAs1eOI2rYYs8Wet4FjuK5qtBsoMpnGkh0WsWXQZe+9QIlKzIVxflObrXnvx 0xcDohiPWEnDf9Owt37MSeVHXL/KcNf5hXAEIVcwNxyNaOOq1IHKG9cR0rmvBdFKQX YqIwwBu67ngQnFq9jLYCJh3pKiETqDWFOoLQ13M0= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug , Paul Elder Subject: [PATCH v3 13/29] libcamera: rkisp1: Allow upscaling when the dewarper is present Date: Tue, 25 Nov 2025 17:28:25 +0100 Message-ID: <20251125162851.2301793-14-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251125162851.2301793-1-stefan.klug@ideasonboard.com> References: <20251125162851.2301793-1-stefan.klug@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" When the dewarper is present, there is no need to forbid upscaling of the image data. Signed-off-by: Stefan Klug Reviewed-by: Paul Elder Reviewed-by: Kieran Bingham --- Changes in v3: - Collected tag --- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index 2d89b0b41958..79c8717c839a 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -609,6 +609,11 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate() return false; if (useDewarper) { + /* + * The dewarper output is independent of the ISP path. + * Reset to the originally requested size. + */ + tryCfg.size = cfg.size; bool adjusted; pipe->dewarper_->validateOutput(&tryCfg, &adjusted,