From patchwork Tue Nov 25 16:28:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 25189 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B87A1C333C for ; Tue, 25 Nov 2025 16:29:25 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 6863260AA9; Tue, 25 Nov 2025 17:29:25 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="HpMmBx7q"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3485660A86 for ; Tue, 25 Nov 2025 17:29:24 +0100 (CET) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:bae1:340c:573c:570b]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 3DCA22106; Tue, 25 Nov 2025 17:27:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1764088035; bh=3a1hYayUKIPR784V6RG9gGQmR5U4Pd2Ul/cvHZ6nPuM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HpMmBx7qX2pFqLKyTsfgCvi8YAKvQiR+6Lv6SaO9+bRkFn/GC1KSL5KxkBmtk2VNt Eg8UQalzPC3CT9jeao0GyChXAXG1S9GWrOTf0t0muExDItsysEeeDTRWwI77wZye8P 2wI70RX91+V5zXHcPaLM+XXidSg1FMkKfkKBzPEY= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug , Kieran Bingham , =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= , Paul Elder Subject: [PATCH v3 10/29] libcamera: converter_v4l2_m2m: Add debug logging for formats Date: Tue, 25 Nov 2025 17:28:22 +0100 Message-ID: <20251125162851.2301793-11-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251125162851.2301793-1-stefan.klug@ideasonboard.com> References: <20251125162851.2301793-1-stefan.klug@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Getting the requested input/output format is crucial for debugging. Add log statements for that. Signed-off-by: Stefan Klug Reviewed-by: Kieran Bingham Reviewed-by: Barnabás Pőcze Reviewed-by: Paul Elder --- Changes in v3: - Collected tags Changes in v2: - Collected tag --- src/libcamera/converter/converter_v4l2_m2m.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp index 48e49f143cf1..37377ab24952 100644 --- a/src/libcamera/converter/converter_v4l2_m2m.cpp +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp @@ -111,6 +111,7 @@ int V4L2M2MConverter::V4L2M2MStream::configure(const StreamConfiguration &inputC format.planesCount = 1; format.planes[0].bpl = inputCfg.stride; + LOG(Converter, Debug) << "Set input format to: " << format; int ret = m2m_->output()->setFormat(&format); if (ret < 0) { LOG(Converter, Error) @@ -133,6 +134,7 @@ int V4L2M2MConverter::V4L2M2MStream::configure(const StreamConfiguration &inputC format.fourcc = videoFormat; format.size = outputCfg.size; + LOG(Converter, Debug) << "Set output format to: " << format; ret = m2m_->capture()->setFormat(&format); if (ret < 0) { LOG(Converter, Error)