From patchwork Thu Nov 20 23:33:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25138 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B8E88BD80A for ; Thu, 20 Nov 2025 23:34:22 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5D7F960B0B; Fri, 21 Nov 2025 00:34:22 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="iomcvW2P"; dkim-atps=neutral Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B83D260A9E for ; Fri, 21 Nov 2025 00:34:19 +0100 (CET) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-4779aa4f928so13903275e9.1 for ; Thu, 20 Nov 2025 15:34:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763681659; x=1764286459; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U4gZBzqGbQfvRAdn9kIktQq170/k2VAqruGy17o40mc=; b=iomcvW2PZSqpWl99asYmYACa/mZ6kGkSWbPfr1mQQBOetAm9p+vuIYIQD2TZjDzJQ5 +fkhcGKj+xgtZvgYnMlZ3tgPtsVG1Wfx+PrYFnOY6BgbH5l6W9RX94NWa2RveUdkGSPc yQxWogYDnJRjLaB0grbRSU3tKE5TYuQpDGWhmE1vuDJZet2pPare5gEOo7CsTHZ6LoPW pC19CsXcgbqCBoG8r1JM/0e9z8toAQnBxKoTCJ4uE+/W/783IuKyBMl48QlLMarLU3// soYb4QHWGUEmpo2u/fXBrf1/kkyVfTL9d7V6ZObUgTBhO597lgwqu6lIsdRLxGuBSEQE tjhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763681659; x=1764286459; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=U4gZBzqGbQfvRAdn9kIktQq170/k2VAqruGy17o40mc=; b=pUsvD0IjL/K+EO8eaKMIXLtaOjTvsNSYHqCK+YOu86hWZGeQCseCDAg7PfGUwh3lkt IEhXX2EJyx99yG0lMt/MJYA7/saggrmzcvBptLV+9kB817RbfmKAO3c8BIvxG8HMnTTI sbPF5kH//HZ2rUo1fBvHN+eM1qn3GkGw362UbyvWcERR/L3ke5YGNVFpUuatzCQMOSg9 2cK7PsOreVdR5nPdxliT87reD1AxemBHFw0OfyfkdSPuW8G0IorlhRBNMKB+cvmf/7ar 4TIfyGj/G+L5TM+08SWjwqeu4ZgBByQio0bR/B9DVPZwOe0MAAc+d4JkNT8KRVy0vMyQ LBPA== X-Gm-Message-State: AOJu0YwymB107nCnPUdMbKfXB9eWNbE+qNW2d3OseoZN3pJM5z6IZWs8 BMK6jvyJl0L42I9rcTtWfXdETWuBescXHRS+vJ6v2DXYy/V4ttVShouD7bsDa+EdtRQ2cBq2KdS 2xCWwdnY= X-Gm-Gg: ASbGncuTXmEp0gKFs5lDL4Sz39/OtlunN+1SaPEWVN1ZYPH6xyZlNu2a4AEBFBGQDAY HBRSvpyzgcDMnlys+j9jUGezk1/BKARwKbtFILXQR/RoPBfyLTJEGs7CKyXiFgOYQCR9zxG5EHJ TRHzhmS+RVcb7fbSD4zFThzB3/sNBYawM+UMV7yluYJfZhh+J4gQABXV2wL+3pRTcaInwoJMMUQ GBkxxE3SAMawiXXqHqs5N7sRjcb8eSyZf+BwKX1STWLsSVmNXY8caFG8uwVDdDq8jRAMU0NizDG uVkBkHmbfN4vCnHJ1hIvmRt3O4KyZJCLw2KupO+KVFl79Jyw8hLtLXir5YU/jblrispzC02RtWG clhkJ+xM7aUHDDQrbOiTF2ouIcIJN0VcOuYZ7ZmQwysR8xfBIbHTRkpLx5r6f8eX4me7QeCi1YW YXjY28/9ffuX/eVfGZY6J5nxNhN5hf5KWjH0NTjngna8qpgRonMOZj1KEzbVQP4n5XCVQ= X-Google-Smtp-Source: AGHT+IHHhEiVs7+Pxy6H5m+Lik7EgWWji3ChGHb8KMZJsQQ5PHzSdmIoLZDHuonNghWtGknp0VtZnQ== X-Received: by 2002:a05:600c:19d2:b0:476:4efc:8ed4 with SMTP id 5b1f17b1804b1-477c0184965mr3221425e9.11.1763681659053; Thu, 20 Nov 2025 15:34:19 -0800 (PST) Received: from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fa3a81sm7984139f8f.26.2025.11.20.15.34.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 15:34:17 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Bryan O'Donoghue , Kieran Bingham Subject: [PATCH v4 14/23] libcamera: software_isp: debayer_cpu: Make getInputConfig and getOutputConfig static Date: Thu, 20 Nov 2025 23:33:38 +0000 Message-ID: <20251120233347.5046-15-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251120233347.5046-1-bryan.odonoghue@linaro.org> References: <20251120233347.5046-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Make getInputConfig and getOutputConfig static so as to allow for interrogation of the supported pixel formats prior to object instantiation. Do this so as to allow the higher level logic make an informed choice between CPU and GPU ISP based on which pixel formats are supported. Currently CPU ISP supports more diverse input and output schemes. Acked-by: Kieran Bingham Signed-off-by: Bryan O'Donoghue --- src/libcamera/software_isp/debayer_cpu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h index 2d385cf01..a395fc97c 100644 --- a/src/libcamera/software_isp/debayer_cpu.h +++ b/src/libcamera/software_isp/debayer_cpu.h @@ -98,8 +98,8 @@ private: template void debayer10P_RGRG_BGR888(uint8_t *dst, const uint8_t *src[]); - int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config); - int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config); + static int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config); + static int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config); int setupStandardBayerOrder(BayerFormat::Order order); int setDebayerFunctions(PixelFormat inputFormat, PixelFormat outputFormat,