From patchwork Thu Nov 20 23:33:31 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25131 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 1369DBD80A for ; Thu, 20 Nov 2025 23:34:09 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C2B8560AB1; Fri, 21 Nov 2025 00:34:08 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="No9sczOh"; dkim-atps=neutral Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 2D73660A8B for ; Fri, 21 Nov 2025 00:34:06 +0100 (CET) Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-4779aa4f928so13902015e9.1 for ; Thu, 20 Nov 2025 15:34:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763681645; x=1764286445; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ftr53nnZFbN48TlKdqsyBREu/6cYVA4gRslhx9V2PI8=; b=No9sczOhtJmp564JYv22mwUy9omlno3R3ToKxZYy7rz36uPjVTLQuLXo2YLrCxX9D5 SuFYXnI3irIA/VNSuQ4S/dkihQR1URTJjfJy1vYMeeIrNJHghPrXELz/oWGKeZJsKLHI 4eErwzFmUFD+OFn+vk5iQrRUxPb/U2/esnHpIbqhe9V1JoZ12xqjjMPosJt+nE/BUuck vkMelK9pQJZDaL6mcrK+Lrh02on7jWYg9Y6hOExp4pLQF9fxLm6oJyXSnqiAyKamE4Em LWEWsmyVa9egsnAm/MOAoiRndJ6iVMahfKKHCkXqJxc1kXHmVU/E1qFYmDmQRDpIpagf RPwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763681645; x=1764286445; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Ftr53nnZFbN48TlKdqsyBREu/6cYVA4gRslhx9V2PI8=; b=tBOY4oSguEZVbyJ5t7frS2lJdCMJerbRrg/oHCxALwUQUTeVo8onBeHqZWLLfBr4E6 ycEK5Y0O2xtwfnv5j42U5EQBgkk/u2ytgH6/fSDiypDHetmuk7JorwgChZ9y9/V0Rn6w ODd8Bg9honoW2fXs9+uUcIJvxnkBqujAfV6zvD1/wMjkIxBqxKfdzBJHSVuH+XP9C/cQ wJl5Y2j6Q4VRlnS/puVb+nLP+3R0ESwJFO6ZK/4H14oXWidgH9Wji//rG/amntYbn21/ dSm3mwrN2kw8Y5VkZyLxQXliCcln3fAFza4NMtz1xhVwtYXQVf669Vfk772ltMC3kEsk 05sw== X-Gm-Message-State: AOJu0YwlDGfRnhastuGwDN9UOQN0jpTLMsHk8j69M2obYSmEizNF5S9N WExWSgpyfAdK/lxobHFMlxhHP0l/IKYuDKRdxaDhRqQwkvoOZHsElkZe52hPyyV+uc0TZZSq2sx RHKAh2bk= X-Gm-Gg: ASbGncvryXEeGDkeLKdToi9jL8HkyZQyizaYsu9IxllCqO85/djhjxlUYbae3VFqwDM mWUgpKzfi3g3iYwgDaNmf8YfM9Mp5VKpgta2CKZIHGgmxcmh+0Oc+DvH3RAiSeBfCkafugQiURL rRBjIvRy0VCqg5aj9cow/TDtnv2OvPrNW0p07ehjRcauZFmLSO4kC/Y/q1VICRlDl2lyzKo/jl3 1WKnhe+4nF+2RfvRdDMoAbcI9Te47L+bXHyQw+sxXcQHvj26jtVPohpVZwO1ojAJXeJTOWlD14U i9F9iTKqE285wDE31TxRe0Sw5zBz0X2YAaY/iHOWzLSO0+A3csdBp3uFYotDx+qDp/mVg5V242X RLLnU/Q/FInKz4guR50rzjz4MyIN6dXGOOx+FNXtN/evMNf0rR1oVvTJLfsPScCeRB9ZoG34VQL /hy/ckYorc+zL4XwMFh4q61NPzTx8U7z5yI+tBVFRbn9ivjxBGN+cH8CZbJ2CRyQCkT2U= X-Google-Smtp-Source: AGHT+IEVkcdjtGpUOagEpkIKZMk9mBXMBmpv5g3wo6+3WuibeHByLVGZKfZkhAdi7dzdH4X7m62bHw== X-Received: by 2002:a05:6000:401e:b0:425:8bc2:9c43 with SMTP id ffacd0b85a97d-42cc1ac93a2mr115331f8f.1.1763681645422; Thu, 20 Nov 2025 15:34:05 -0800 (PST) Received: from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fa3a81sm7984139f8f.26.2025.11.20.15.34.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 15:34:04 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Bryan O'Donoghue , Milan Zamazal , Kieran Bingham Subject: [PATCH v4 07/23] libcamera: shaders: Extend bayer shaders to support swapping R and B on output Date: Thu, 20 Nov 2025 23:33:31 +0000 Message-ID: <20251120233347.5046-8-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251120233347.5046-1-bryan.odonoghue@linaro.org> References: <20251120233347.5046-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" We can easily facilitate swapping R and B on output. Pivot on an environment define for this purpose. Reviewed-by: Milan Zamazal Acked-by: Kieran Bingham Signed-off-by: Bryan O'Donoghue --- include/libcamera/internal/shaders/bayer_1x_packed.frag | 4 ++++ include/libcamera/internal/shaders/bayer_unpacked.frag | 6 +++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/include/libcamera/internal/shaders/bayer_1x_packed.frag b/include/libcamera/internal/shaders/bayer_1x_packed.frag index 90bd64570..c0632eb1f 100644 --- a/include/libcamera/internal/shaders/bayer_1x_packed.frag +++ b/include/libcamera/internal/shaders/bayer_1x_packed.frag @@ -268,5 +268,9 @@ void main(void) rgb.b = texture2D(blue_param, vec2(rgb.b, 0.5)).b; #endif +#if defined (SWAP_BLUE) + gl_FragColor = vec4(rgb.bgr, 1.0); +#else gl_FragColor = vec4(rgb, 1.0); +#endif } diff --git a/include/libcamera/internal/shaders/bayer_unpacked.frag b/include/libcamera/internal/shaders/bayer_unpacked.frag index 7c3d12b03..b545fbbdc 100644 --- a/include/libcamera/internal/shaders/bayer_unpacked.frag +++ b/include/libcamera/internal/shaders/bayer_unpacked.frag @@ -163,5 +163,9 @@ void main(void) { rgb.b = texture2D(blue_param, vec2(rgb.b, 0.5)).b; #endif - gl_FragColor.rgb = rgb; +#if defined (SWAP_BLUE) + gl_FragColor = vec4(rgb.bgr, 1.0); +#else + gl_FragColor = vec4(rgb, 1.0); +#endif }