From patchwork Thu Nov 20 23:20:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25122 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 58F28C3330 for ; Thu, 20 Nov 2025 23:21:06 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1663E60ABB; Fri, 21 Nov 2025 00:21:06 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="jrO4mKcL"; dkim-atps=neutral Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9348F60ABD for ; Fri, 21 Nov 2025 00:21:01 +0100 (CET) Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-47774d3536dso11139105e9.0 for ; Thu, 20 Nov 2025 15:21:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763680861; x=1764285661; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DnTn9MIz19IX9mj9lajM91BQDHALRtnXvR7P8cLPuio=; b=jrO4mKcLQFwyr8TTZTt/m1zoHG4oPOC/xfAS+O9IicGbngTcWzOe4XiPBvdoxvnC1n kdKS8Yt3Ji4iKslJ6vNH906rwqzhKmiRuGADnH9Z9BxzEi4E4PNHZVKa6yPezeHpijLG MJPALcVdEWp3W51Jesr8VtuzrQw7z5ar5vKdwDIfkDjOk/CD446KKzLenAzBKDwgUzbP mTycJfewVriYRrLNSsjsqPH25qufK5EDpYCDWtwMwpoTQeqG1JI8QG8OBEzqf//t6xc3 sTsKSrRB8NPF15jnNsvu+Hrd9qSUKx4OG1SFdJOYFpsK3qs0smy1RqSWDo3hSJdp9Baa alSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763680861; x=1764285661; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DnTn9MIz19IX9mj9lajM91BQDHALRtnXvR7P8cLPuio=; b=JGiWlJ4r8pzpBO7kCBhE5qY0nJ2Rb8AeGPK6mf+QWSjCGUViLDpmEIXtQ92ek92kRH POT4DJj0C+lC39CYGW1HbE5en3FXJz6LV775sIXoVddTSiRuuBEPe/OzkfY3BBtcMfDh 4StpivcM0Fhy7+CBmBZxwPXI7jZh9thqqJrWbknsr5cEwMqQJDMmUlGddtAySO8tUD3x 6oZLpK4nD1DpR5FmiqIcIiVDRKr0dt3LS6emzhXxWpsQPCLDtcXkX9ANZrq1f56X/tqW CIrIWsESxtwmZJpDym2sTp/cgn+qdC30Hbi/yTBz1xQk1Upw4NUj0087rQO3E0niWVxq ZASA== X-Gm-Message-State: AOJu0YzBUuGZArb9KX2wvSupfqsCOtUOW1kacbLnFBxEBOMWITHRdKSr iEuofZyxRb1LnxeXAu/QGDgJi6Tw5oTWYjlbVy/OT9+MJjD7LwM1PtYmTis0HCllJ6IbksE52C0 0LIA3AUs= X-Gm-Gg: ASbGncvpXUgD1uCI1GZZyYuozyAsBr/0gZ8CyVI8P5GOqp3TxDnTIsDqHnBjZEg0/Y5 kyx/AOpgCfjJ5kLFsWPOmQpNQ6sLbch4dxqj7cd//4whZM2sQPX7KlsYUzUECkGMB4uisQj9eB1 gsNEY9ix6PVg/xtLkKWprq/f4I3PV1w2pBdoc242H+zQgJ1bpXbS5rR2ljQ9e+XnsaWjFSmEIKO aji3Pc0DP/EYZzhD7IS9I6HHHIjvxujra2mnuuHH+WWVqcU2MQ9Ptw/VwD5zBDf3/LtI3QGQUuY W/Yt1ElLuxYjtJ/3lSoLgvXc1d3rG5/zB5uuNiaV/WHJG34ibeidOBJjcOmmqNzspDK2vmnUFtZ MOnKItprDkc8FMG18jA3CeeW7J4fECTFEwYV3veKfBJ7/101eEp9aOd+QOuPpzHGf0xveb0Fy+D zFmrvB3sB/MejjafRBRMcA7aSeZxLCUa4SAZkXOsEhRAH145SrAT3NnW8StLTB1o2ecyW8bPn4G LnNAA== X-Google-Smtp-Source: AGHT+IE54obcrC+Moe3y9r3lQaz+IxsTfaJoGEJ6kIA5RVi9TZvnrvDGzc6cfT8X6onDUlk2lHcBHw== X-Received: by 2002:a05:600c:4685:b0:475:ddad:c3a9 with SMTP id 5b1f17b1804b1-477c052f04bmr2491925e9.13.1763680860764; Thu, 20 Nov 2025 15:21:00 -0800 (PST) Received: from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477bf3af0ecsm11618415e9.9.2025.11.20.15.20.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 15:20:59 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Bryan O'Donoghue Subject: [PATCH 21/22] libcamera: software_isp: lut: Make gamma from lut.cpp available in debayer params Date: Thu, 20 Nov 2025 23:20:18 +0000 Message-ID: <20251120232019.3590-22-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251120232019.3590-1-bryan.odonoghue@linaro.org> References: <20251120232019.3590-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Provide the gamma used in IPA to Bayer parameters. We will pass Gamma into the shader via a uniform and can then tweak that value from outside at will. Signed-off-by: Bryan O'Donoghue --- include/libcamera/internal/software_isp/debayer_params.h | 5 +++++ src/ipa/simple/algorithms/lut.cpp | 2 ++ 2 files changed, 7 insertions(+) diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h index 1a319833c..5f340a7a6 100644 --- a/include/libcamera/internal/software_isp/debayer_params.h +++ b/include/libcamera/internal/software_isp/debayer_params.h @@ -62,6 +62,11 @@ struct DebayerParams { * Per frame blacklevel gains calculated by the IPA */ RGB blackLevel; /**< Blacklevel gains for GPUISP */ + + /* + * Gamma value as provided by the IPA + */ + float gamma; /**< Gamma for GPUISP */ }; } /* namespace libcamera */ diff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp index 49482d711..ea5a86b20 100644 --- a/src/ipa/simple/algorithms/lut.cpp +++ b/src/ipa/simple/algorithms/lut.cpp @@ -147,6 +147,8 @@ void Lut::prepare(IPAContext &context, params->gammaLut[i] = gammaTable[i / div]; } } + + params->gamma = context.configuration.gamma; } void Lut::process([[maybe_unused]] IPAContext &context,