From patchwork Thu Nov 20 23:20:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25120 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 3852CC3330 for ; Thu, 20 Nov 2025 23:21:01 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id CBB5260B31; Fri, 21 Nov 2025 00:21:00 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="qQ1zSuHQ"; dkim-atps=neutral Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 6D72E60B2F for ; Fri, 21 Nov 2025 00:20:58 +0100 (CET) Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-42b3377aaf2so813959f8f.2 for ; Thu, 20 Nov 2025 15:20:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763680858; x=1764285658; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Q72Mq/ODDFKHXLOJoLvTa+pTSd+VTsB7EmzhQuxUCGI=; b=qQ1zSuHQrdFwWiS4CywnBK52zeO6BX/dPRtJIexmg8uqx0gz1pmp5q9au3I3XkFg1H Nq1HffEXUT3pKZPP3HzDEhovJQTCdOfLCyXkSovyFl3Os4PJwMllj70P6qExbdN9Dyqw Z8IGihmo7hTCLqFYwJHk8Cjk6qvYezTyg6Kj/KiH/FfToTyMG1zod/+Hb1EaN5qfqH5l a+f8yM7eBxSVjst+ntgRRwVjA8iegF5G1McHMhOHVxnHuRMQYms5gRX75eYof3hE1TlE ejmBQb+mBcn+KWbqalLIyUIGX9D+Iff42coTdO1Npu/Ql/xlyotIM6vp1Hggkd59na6T GVNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763680858; x=1764285658; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Q72Mq/ODDFKHXLOJoLvTa+pTSd+VTsB7EmzhQuxUCGI=; b=nUVo4YpW7eyQoTOtaoeXEG9xWnG6p4gaDx+tR57UM6oodrBFEQpusekjHU39SVYMJx e7K0C07Ri/UrgibW0cuKKIxug0mhjL5+iQYxFrburA1jJ99wl1okIxruHCL7bgpvXvCe c9D6UJfvlzzff5oyTLsm29rbwTNI8BinUUbN01VJn6R7VIoIJ0u0vDxtL7IqV9kba+5i aYQtXq/oHa6MfHYbGRSPzn5OfwfhIYZOjwYNY6VTugrM73JOEdZrD8Ek69xS5oqj1O8S bRB2vNgVX1LaoLClViiSvJkCqCAoDuiPltia2QWQDdAtwRboEYPqth0KTL/6ZYFQ0Pof RNhw== X-Gm-Message-State: AOJu0Yz7t1IPSs7HzROi3luC/TmI6wQaHLG/M88xU1XsaIRGDObUy6dQ Iff+QQx+mX0SRpaDPM8jOMSmN9L2+Az91W4cfzKv55RZzQ25jcTGQ9UCbymVRA9gofV+kohPiaM dCadGx7k= X-Gm-Gg: ASbGnctPBcMMwaSHPuhRfOqIU280n2Ww0r+n8K6hnpllg38E29LCXV7Gs/2E8zaLRKB PzIO9eG5cgWAlTZaNGmfHUqkq/39lN4Byeteuza4DmW3WSb4D/MkHbqaZ1DeY4f/xQ6szAQSWt9 v1HH/JjDEP6PHH2pMBN4s2/H119P/bdh5rxBcWvJcX3RPdt7UUoQrVHruUjBetz20SmNG8SVt0P 4QZ57Fpn3xw2RUBfGHI2Hkbmy6acrUMwVBYLCojcGrtaqaccFFH16c4ok71nSbtWMMnCUsn8OWi rcjZS/ztgJ20SPi9RhawzKWlvKozHZ2rsgaOF0/Uqje8hMeEssAgbeMBJAQbNt3yBFwn9DS1ZGL H6mWH0NGB3BtoZ7jBM0CJ7o1xC2CJwq/f5FxJh/nF8mv8lYHRTMZkOJlzzP/zDvNP3FgKsfAwi0 Z6G88T8gUY7cVBZkGV5X/wmPvhk6/40QTb5IQG8mSqTeQGrVf4iVAUpAENd18aX7EHzzSyi5bBJ 4pQrw== X-Google-Smtp-Source: AGHT+IGr6em+UcoEmUHGX2PSVgy1Y/ZKLLYBm2RhcDpWvuQ2pmaipdpJAQncAy3M78cHMcjgcA2ypw== X-Received: by 2002:a05:6000:401e:b0:427:690:1d84 with SMTP id ffacd0b85a97d-42cc1d0ce5bmr76942f8f.32.1763680857721; Thu, 20 Nov 2025 15:20:57 -0800 (PST) Received: from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477bf3af0ecsm11618415e9.9.2025.11.20.15.20.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 15:20:56 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Bryan O'Donoghue Subject: [PATCH 19/22] libcamera: software_isp: lut: Make CCM available in debayer params Date: Thu, 20 Nov 2025 23:20:16 +0000 Message-ID: <20251120232019.3590-20-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251120232019.3590-1-bryan.odonoghue@linaro.org> References: <20251120232019.3590-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Provide the CCM calculated in LUT to the debayer params structure for consumption in the debayer shaders. Signed-off-by: Bryan O'Donoghue --- include/libcamera/internal/software_isp/debayer_params.h | 7 +++++++ src/ipa/simple/algorithms/lut.cpp | 1 + 2 files changed, 8 insertions(+) diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h index 217cd5d92..019df2048 100644 --- a/include/libcamera/internal/software_isp/debayer_params.h +++ b/include/libcamera/internal/software_isp/debayer_params.h @@ -13,6 +13,8 @@ #include #include +#include "libcamera/internal/matrix.h" + namespace libcamera { struct DebayerParams { @@ -49,6 +51,11 @@ struct DebayerParams { CcmLookupTable greenCcm; CcmLookupTable blueCcm; LookupTable gammaLut; + + /* + * Per frame CCM values as calcualted by the IPA + */ + Matrix ccm; /**< Per frame colour correction matrix for GPUISP */ }; } /* namespace libcamera */ diff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp index d4a79e101..49482d711 100644 --- a/src/ipa/simple/algorithms/lut.cpp +++ b/src/ipa/simple/algorithms/lut.cpp @@ -133,6 +133,7 @@ void Lut::prepare(IPAContext &context, auto &red = params->redCcm; auto &green = params->greenCcm; auto &blue = params->blueCcm; + params->ccm = ccm; for (unsigned int i = 0; i < DebayerParams::kRGBLookupSize; i++) { red[i].r = ccmValue(i, ccm[0][0]); red[i].g = ccmValue(i, ccm[1][0]);