From patchwork Thu Nov 20 23:20:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25106 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 67C3BC3333 for ; Thu, 20 Nov 2025 23:20:38 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 25A1860A8B; Fri, 21 Nov 2025 00:20:38 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="eKZ8K4Am"; dkim-atps=neutral Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D360F60A9D for ; Fri, 21 Nov 2025 00:20:34 +0100 (CET) Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-47796a837c7so9424105e9.0 for ; Thu, 20 Nov 2025 15:20:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763680834; x=1764285634; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J/rNUy6IT8Dq/gobx75Pygy+h2VMr98GtCcoWBBrzZU=; b=eKZ8K4AmDARdsmThf3v+ls8mG9gipqwucPUHy8L71i6g2Fh2u0yXeyy9PH7Eua0nYC kKesU8ysWGQyfljuuKSQs7NnMVzopOolgKErZn9Mg5gnxjZbEDC/GFJi6Q8cfgT5P6hf sNya3+g37TCwj5VPbRE1O65INEm0ahtBRH+L1d9dPJYiJOsuONZ+UiBaHfxvcPiPIWhG TVA/bdcg8OXfnvmnkvTaVhdEirFVBavFoBKxhgUM14FxPXaNycr3oVgWdlXOXU20oKUx 6bbKa4EJAPO1NV2/DTbaGxpUJXpn6gt7qMdmcbwS+ZgBF0KquBnmoqGFXXDKMN/iItKH V8mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763680834; x=1764285634; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=J/rNUy6IT8Dq/gobx75Pygy+h2VMr98GtCcoWBBrzZU=; b=WaheV8vULEnJD23XVYs8LExpn4UO5c7fNPV4jzDCJiQvHQ3Sr5m40ksFlSjsLLWwQR juidQMBsgy7g2VrI8zcK933AKmIJnYXsLC5kQ576wPNgbqKpl4eY+Atv8mUmrR5GOA/z xJ+ykBJ1gchDeJXD6IuJz5/wC3N7L6BQcL/Iu82EZ7Ad610lgC+5WavaDuVbkAXqRS1G xBrEFkc67Ih81NI+ZYL+gBjXnUjgps9kCYHsoZ/tcLnRrmpugO1vLHJUrerwWOyihPbp kFsM6QZcrqAW7Hj3oH9yNQixZmkGjKLNExmTvyw+vUhP4NLILnfQsudAkFDhisTHNKRj HjVw== X-Gm-Message-State: AOJu0YzDQofNXswdWQsMS4ljiPFh39X9pQQ8gYwjsnsjn7LjMl9b6roL ree3oduZnrly3dP+ThGIHJgzx+OC2WyEIuUkHnKeDDUCEt41JHwoy978rANfUMtyY5nGYxIH+ru Ew65kpXc= X-Gm-Gg: ASbGnctJvyrgRFFchKqOusf2Zxn605zzbB+47BKZDC+XEKPWKdNhKMEbQwZPjFXs77y I2jGUUUEM2e+XfIfOIJ++0kRs71acAwSAwIHjLcQhNkcR9xP5Qru9+4AJi6fY+TVU0Hd+buiQlL 6Goy+nN05q/Hisr9D8mgNFwk+exj6pJ3ahiknDGEvkrB9ztiTyQaX4ip2lywA+ZF7JQXT1dzHKo 9ZNaNr+hAqTsRc5q552PR3kWKOkClipJI3TKHXxG6EOYz/kEkE8Pp/HshlTCYbRGFHMTyydYs1M 8ujycRhRChwjsJP+FQ9hzql2nseZSCpeHRvHjp1bwt9NRAbbOnhgFAien+X+T1VjtvUw48n4JIj QMDO73AW7wh/ScQEbDS+LQ0qtOVFC8q8KVTqvRlMxAcVGpF6i+aCc97rfXaHsV4rs6piGk7p/oZ CN1tJV5qsMQqlD9IpqWK4xMKwzpK4EaDVi7BiE+s5a1875c9dATIG3cG1XfrzCkZyZfik= X-Google-Smtp-Source: AGHT+IExo/lZJ5aSQVeh+ZgmyPHPlqN12DlPdCnFcian4cxW11tHaGwpKCj9UEis+wbsjhh7O5Q6Lg== X-Received: by 2002:a05:600c:310d:b0:477:9fcf:3ff9 with SMTP id 5b1f17b1804b1-477c01c359fmr2941445e9.27.1763680834133; Thu, 20 Nov 2025 15:20:34 -0800 (PST) Received: from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477bf3af0ecsm11618415e9.9.2025.11.20.15.20.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 15:20:33 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Hans de Goede , Kieran Bingham , Milan Zamazal , Bryan O'Donoghue Subject: [PATCH 05/22] libcamera: swstats_cpu: Drop patternSize_ documentation Date: Thu, 20 Nov 2025 23:20:02 +0000 Message-ID: <20251120232019.3590-6-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251120232019.3590-1-bryan.odonoghue@linaro.org> References: <20251120232019.3590-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Hans de Goede patternSize_ is a private variable and its meaning is already documented in the patternSize() getter documentation. Move the list of valid sizes to the patternSize() getter documentation and drop the patternSize_ documentation. While at it also add 1x1 as valid size for use with future support of single plane non Bayer input data. Reviewed-by: Kieran Bingham Reviewed-by: Milan Zamazal Signed-off-by: Hans de Goede Signed-off-by: Bryan O'Donoghue --- src/libcamera/software_isp/swstats_cpu.cpp | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp index 9c03338a0..1b33ffa71 100644 --- a/src/libcamera/software_isp/swstats_cpu.cpp +++ b/src/libcamera/software_isp/swstats_cpu.cpp @@ -58,6 +58,8 @@ namespace libcamera { * also indicates if processLine2() should be called or not. * This may only be called after a successful configure() call. * + * Valid sizes are: 1x1, 2x2, 4x2 or 4x4. + * * \return The pattern size */ @@ -133,13 +135,6 @@ namespace libcamera { * \brief Statistics window, set by setWindow(), used every line */ -/** - * \var Size SwStatsCpu::patternSize_ - * \brief The size of the bayer pattern - * - * Valid sizes are: 2x2, 4x2 or 4x4. - */ - /** * \var unsigned int SwStatsCpu::xShift_ * \brief The offset of x, applied to window_.x for bayer variants