From patchwork Thu Nov 20 23:20:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25105 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 9A3DEC3330 for ; Thu, 20 Nov 2025 23:20:37 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5641860AA8; Fri, 21 Nov 2025 00:20:37 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="tkgnjAi4"; dkim-atps=neutral Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 22D75609DE for ; Fri, 21 Nov 2025 00:20:33 +0100 (CET) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4777771ed1aso9717455e9.2 for ; Thu, 20 Nov 2025 15:20:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763680832; x=1764285632; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BYLFp48Jtlh28DV0l7WkmFCL3lrDfDHVbIKL8htzT4E=; b=tkgnjAi4zUlOH16meHfDpcEW40BiEU08q5jzilgdKC3Os/QPtuxXWXQoFC0e3hnC76 pkVAFXA1wlTHgsQBwPYBXSY79bMhYM6wMuRxOiWKb+vavo4l4Px94ZUSmL+zfBFWdEal PZ20/D2D38zx3EnYJl2izGwCxUKVIZMNYD0wxGuZFDVdMRtF+yt5R/ST3WkcoJ141Bp9 1yThP5S9o7jHbt4Aa0peO8h0r9bF+IiAb048QeSh/Tzb+KzPinVr7Kqlp8ww8NcjgzOs /Ku98lLmFaxc8q4xA0+87+wPaKQGs6zFwOaK6VNbo/m61YRsC5TcUz5kKBJaT1yKkm6l 5qqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763680832; x=1764285632; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BYLFp48Jtlh28DV0l7WkmFCL3lrDfDHVbIKL8htzT4E=; b=LMDuS43ILxWsl5q4SapVWe9Eov1UZ1yfQXxTgB9PoqGkETYBtnEh6HMA1EokpZd2Eo e/pex7TFY6Lj7RZxA97Nsd81v3mtJTbCEJFz2cyvcA4+fopMIJdQJqihh57B5qoOwpXh PhsvXnh54h07ysWSw41AQMP64no1HTrPiURJwZfMrQJRjZxvtwzRsMKcDMQQoVm5Km2p 75tJPtRf3FOUa++IK9h+oHQy7AVjDgbss2rJG9SCkDx4yLNKxM72EEYrwLDO2If+4E0X UUqbRXfSR0pf+o+QNirCk7jUPCzyQT5Q9Qd5K8I8DMX4o/dD4LYzWV4P9GMYxhCEOeid ES8g== X-Gm-Message-State: AOJu0YyGcG4fYcqB52fZl2aQc63oNUZr+N/mqdKhXSgOS6SqigNXQoGC Rq4q5k1mDPjkeU2UmavZK1FLnSzMvcHlxrQg+RL4MRIy0tUB3RsA8sxGswzrMDQMw03VannUxGC 8mWEm0OA= X-Gm-Gg: ASbGncuInIp26Gud8kewwIzBnC8MORxXKrwbX+SdpW6+FVIPmBvQnh/0c4m7D7GTWLZ xKHecHNsFePqf05lzNC4VB0DyaOFrbBCWwL+QEIOIlMPnLsKRCa28USVFrfWBdZlz9+RNreFR1a D7xwZq+8/JSco3KL3N4OcQVfQ47PgJpFPogUdpREUZTnNb8bL1FCyfRvlanYteR65UVlibz3uJN InK26Eqqch0CTX7DSKj/hHYp1fbda/Pl4LrpNAQ8WeWrpPhfT44q22rUlQLm6fB8VVEMQPEp2D5 8QvY4uQJ9aLuifY2BFHaAX9Z+iSDn26E+Vb6nO3DpeOIT1PPg3SNocBnBVv0jqG31W2PDVEntO1 84Yl55ePQzIPZwLw1QtneJ+HNbqqSvy9GUI/NJU1AtnN8PAPMeYlpfW75zbEZ02DNyDBIKEzDus auL47tm3rJ79R5ZRtzGEzhWMxn7aZn73qRqUc6+noE4QcexlY5/k2I6qaBk3rZ4EtbuAI= X-Google-Smtp-Source: AGHT+IE+lwAwIbMQwP55EOpjso52jOpajRLW1RSPF0IcBjKNSlkcFeIWNlgmHLqKEdTYBbrUrpshtg== X-Received: by 2002:a05:600c:45cf:b0:477:8ba7:fe0a with SMTP id 5b1f17b1804b1-477c01c001bmr3631235e9.24.1763680832446; Thu, 20 Nov 2025 15:20:32 -0800 (PST) Received: from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477bf3af0ecsm11618415e9.9.2025.11.20.15.20.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 15:20:31 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Hans de Goede , Kieran Bingham , Milan Zamazal , Bryan O'Donoghue Subject: [PATCH 04/22] libcamera: swstats_cpu: Update statsProcessFn() / processLine0() documentation Date: Thu, 20 Nov 2025 23:20:01 +0000 Message-ID: <20251120232019.3590-5-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251120232019.3590-1-bryan.odonoghue@linaro.org> References: <20251120232019.3590-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Hans de Goede Update the documentation of the statsProcessFn() / processLine0() src[] pointer argument to take into account that swstats_cpu may also be used with planar input data or with non Bayer single plane input data. The statsProcessFn typedef is private, so no documentation is generated for it. Move the new updated src[] pointer argument documentation to processLine0() so that it gets included in the generated docs. Reviewed-by: Kieran Bingham Reviewed-by: Milan Zamazal Signed-off-by: Hans de Goede Signed-off-by: Bryan O'Donoghue --- src/libcamera/software_isp/swstats_cpu.cpp | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp index 4f7bdd231..9c03338a0 100644 --- a/src/libcamera/software_isp/swstats_cpu.cpp +++ b/src/libcamera/software_isp/swstats_cpu.cpp @@ -72,6 +72,19 @@ namespace libcamera { * patternSize height == 1. * It'll process line 0 and 1 for input formats with patternSize height >= 2. * This function may only be called after a successful setWindow() call. + * + * This function takes an array of src pointers each pointing to a line in + * the source image. + * + * Bayer input data requires (patternSize_.height + 1) src pointers, with + * the middle element of the array pointing to the actual line being processed. + * Earlier element(s) will point to the previous line(s) and later element(s) + * to the next line(s). See the DebayerCpu::debayerFn documentation for details. + * + * Planar input data requires a src pointer for each plane, with src[0] pointing + * to the line in plane 0, etc. + * + * For non Bayer single plane input data only a single src pointer is required. */ /**