From patchwork Fri Nov 14 14:17:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 25060 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id F1D9CC3317 for ; Fri, 14 Nov 2025 14:17:36 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 41A3560AB6; Fri, 14 Nov 2025 15:17:32 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="uUF9nate"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C7B7060A85 for ; Fri, 14 Nov 2025 15:17:20 +0100 (CET) Received: from [192.168.1.101] (93-61-96-190.ip145.fastwebnet.it [93.61.96.190]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id CB79419AD; Fri, 14 Nov 2025 15:15:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1763129720; bh=MkyAuTFUvynNr2wv/aJybpKRRVV0Ti2Z7sUQF8pUMoo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=uUF9nateHiXmp/cF/cekjyfJnvMjkFDBhJpnRYQ+kJbjtOsndPrDasoSVgqKfua7f NOEa2zOXaQhp7B95ZVECeFdpWirWTzzpCwBVpqM4gXPbLxYBhSy4kv6G/lDd1xfNCk AODfCmr8PEmtY1j/ragFTtFNbD/ZlShSFbYmagXY= From: Jacopo Mondi Date: Fri, 14 Nov 2025 15:17:03 +0100 Subject: [PATCH v3 08/19] ipa: libipa: agc: Remove unused accessors MIME-Version: 1.0 Message-Id: <20251114-exposure-limits-v3-8-b7c07feba026@ideasonboard.com> References: <20251114-exposure-limits-v3-0-b7c07feba026@ideasonboard.com> In-Reply-To: <20251114-exposure-limits-v3-0-b7c07feba026@ideasonboard.com> To: =?utf-8?q?Niklas_S=C3=B6derlund?= , Robert Mader , libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2342; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=MkyAuTFUvynNr2wv/aJybpKRRVV0Ti2Z7sUQF8pUMoo=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpFznrF/GZbFsNXTHVwL9B+ZI0WH5EgqHN+Y7QM yMcjGea5JyJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaRc56wAKCRByNAaPFqFW PMIxEACsUTXA/jehYw0+xrcB1hQnKDfLzFcYxlgq48yWiXJdJuagESRmmlQjPzD0fnbf+iJjdWf VZJoeNbX6MOqFfbdRCiei22VDdjM5ubkhFSIw+Wkr8+tCxuwmfyve2peSg6mrhj2pP9/1u9eyvs IXod7wzVSQz+GyBtoJ7nl8HZhLlUTU4/eFpSz3WVFWbWCrxMAGgtet2WN3cWWEM/MOY653Rhh7k o4yEJOZnAwF9mio+g/bfIvkJmwMhzqb7cl8T+0TH9YQFjmnehb+zgtnYv1it3cqiYLQRgNyiSoU pJNM9pIDeCVJR05iMYQbm/d9ru6+IpJZDarCLyCVo6MrqOIAB/+zGZEq459xHbHzknR77YfceTM 7PC2zH2ZQ6y3jMpRYpvT3/GrUo1iQFJKh9c3zCZdjQjUYr9kK5GmfnDb5dYPj16ZKctDHVqzOd2 +/y+Nm1jTLIGhOMnoPVPDoa57riSV9XH0YgRt5yUplig3uxvfxP/RPxu/ZnkLCpYhkA4xgOFaX0 phriiUPTwrO65bwdcO0a7a6OI9jcEqijjt9OYPOLOjDcKqx4iJamCYxTjhhZcuE3cfbcUXIblvU k34Xwg+DZEO89iS3SSQ52ky0yBTa4VFplxHXrxXO8cSDUmRXYCTUNhefNC3xF00khljeW3EDhTw H6rHupaS148sJFw== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Remove unused accessors. They're not only unused but it is not even clear what the purpose of accessing the fields is. Signed-off-by: Jacopo Mondi --- src/ipa/libipa/exposure_mode_helper.cpp | 25 ------------------------- src/ipa/libipa/exposure_mode_helper.h | 5 ----- 2 files changed, 30 deletions(-) diff --git a/src/ipa/libipa/exposure_mode_helper.cpp b/src/ipa/libipa/exposure_mode_helper.cpp index 29e316d9d09181cd65cb08f26babb1a680bee62a..962ce1b1b7503e0f86f3857b484b249cb6383fde 100644 --- a/src/ipa/libipa/exposure_mode_helper.cpp +++ b/src/ipa/libipa/exposure_mode_helper.cpp @@ -266,31 +266,6 @@ ExposureModeHelper::splitExposure(utils::Duration exposure) const exposure / (exposureTime * gain * quantGain) }; } -/** - * \fn ExposureModeHelper::minExposureTime() - * \brief Retrieve the configured minimum exposure time limit set through - * setLimits() - * \return The minExposureTime_ value - */ - -/** - * \fn ExposureModeHelper::maxExposureTime() - * \brief Retrieve the configured maximum exposure time set through setLimits() - * \return The maxExposureTime_ value - */ - -/** - * \fn ExposureModeHelper::minGain() - * \brief Retrieve the configured minimum gain set through setLimits() - * \return The minGain_ value - */ - -/** - * \fn ExposureModeHelper::maxGain() - * \brief Retrieve the configured maximum gain set through setLimits() - * \return The maxGain_ value - */ - } /* namespace ipa */ } /* namespace libcamera */ diff --git a/src/ipa/libipa/exposure_mode_helper.h b/src/ipa/libipa/exposure_mode_helper.h index 968192ddc5af768ae0de58aca6c7230c7b3bd507..f8b7a4aa4800b59459f8fc80f502b83647547f51 100644 --- a/src/ipa/libipa/exposure_mode_helper.h +++ b/src/ipa/libipa/exposure_mode_helper.h @@ -33,11 +33,6 @@ public: std::tuple splitExposure(utils::Duration exposure) const; - utils::Duration minExposureTime() const { return minExposureTime_; } - utils::Duration maxExposureTime() const { return maxExposureTime_; } - double minGain() const { return minGain_; } - double maxGain() const { return maxGain_; } - private: utils::Duration clampExposureTime(utils::Duration exposureTime, double *quantizationGain = nullptr) const;