From patchwork Fri Nov 14 14:16:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 25054 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 3857CC3241 for ; Fri, 14 Nov 2025 14:17:28 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7D3CD60AAF; Fri, 14 Nov 2025 15:17:22 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="QjXjkeN8"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 86A12609D8 for ; Fri, 14 Nov 2025 15:17:18 +0100 (CET) Received: from [192.168.1.101] (93-61-96-190.ip145.fastwebnet.it [93.61.96.190]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 59EDCC77; Fri, 14 Nov 2025 15:15:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1763129717; bh=9ZfASp4CccITLhl3MKlou4OHekrvmW0G8T01Ii0WxtE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=QjXjkeN8ozYMeBBPFby1eSqpy53pPLsOFlZ/S3hfvpoEY9+cc7NevegwW7Qt42Sx4 ecNA927iu4aDISqMXLr/fjhrhCRhQVYqui65o4+xI8tFoDoFwCzM1SJIpOhKFa1vGk guHH5hT/aKrTfLISg59tpX6Tf3eaA09vbqye/huA= From: Jacopo Mondi Date: Fri, 14 Nov 2025 15:16:57 +0100 Subject: [PATCH v3 02/19] ipa: ipu3: Move CameraHelper to context MIME-Version: 1.0 Message-Id: <20251114-exposure-limits-v3-2-b7c07feba026@ideasonboard.com> References: <20251114-exposure-limits-v3-0-b7c07feba026@ideasonboard.com> In-Reply-To: <20251114-exposure-limits-v3-0-b7c07feba026@ideasonboard.com> To: =?utf-8?q?Niklas_S=C3=B6derlund?= , Robert Mader , libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi , Laurent Pinchart X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4094; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=9ZfASp4CccITLhl3MKlou4OHekrvmW0G8T01Ii0WxtE=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpFznq6H1jeOLq2k2cwa5eZw1pKDSo8TRlEaIT8 xXKLnSPqo2JAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaRc56gAKCRByNAaPFqFW PIdxD/9N5LrlL3eX+O4/ZrQGpUzovrHBjqcyP+7ynSu4ubHLRGtusoSsunqgaBq2TFvOner7CM9 K9FAS+KQFL8gxjc9O41+XpmkNPZI4vrRiWS9swkJHLlsrUZmkktbi6An/b9NsbEkVdN8SBzKchw dijSjqPpVzbTbXK/HPHTf3vEmeagyGPi613dxUQaMKhCgylnaszS57r0yDKLjm6wRdUBQMuSdFs dqO6iCFUJFnVtZShiFMGTPZ4r1xuQFfrxHasJcyX6J1jCL0O+kPpbO9Hh4i6B8kzcUbeXSLBYh4 2n/79UGE+bdtLeNE8hxwy3g9t76aDx+kOAlxUTaSnBAeFqVEmmINcGjG3Ju+QNqeK66F6H1/yXO qqT3R3365yZY8kzfXuMzX4k7GkCSqGJwTY2pMWGELkU6QZUlxq49r7LGaE/vWYARVHHjUiKFqzE W3+PofZF2MCprdCmnsvAftN0LHJQMsdV/eJsEFevS7/GUJAVhiQnDfVoXuL7Y+OFhqx04+8xEeM mYS77b0CPq4R4ku4kWKGWeW9493K179hRqwMnB/i4czcoIGK6XrxcdN8RSeWlIPIcrkdq33VxOZ F+pynP0Um81UvkpX4uI9EshTu9pbtQagqZ81U7SSD1k3AXBp4tM/KsONXWhAQ8l8kNMItzGiZX9 K+rQcG18UWUbqcw== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Move the CameraHelper sensor to the Context so that it can be used by the algorithms directly. Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart --- src/ipa/ipu3/ipa_context.cpp | 3 +++ src/ipa/ipu3/ipa_context.h | 3 +++ src/ipa/ipu3/ipu3.cpp | 15 ++++++--------- 3 files changed, 12 insertions(+), 9 deletions(-) diff --git a/src/ipa/ipu3/ipa_context.cpp b/src/ipa/ipu3/ipa_context.cpp index 3b22f7917650d9e400d5368c2f890d6b2dc846a0..5d0ebaaec454fca823851228614a3eb229f0132b 100644 --- a/src/ipa/ipu3/ipa_context.cpp +++ b/src/ipa/ipu3/ipa_context.cpp @@ -54,6 +54,9 @@ namespace libcamera::ipa::ipu3 { * * \var IPAContext::ctrlMap * \brief A ControlInfoMap::Map of controls populated by the algorithms + * + * \var IPAContext::camHelper + * \brief The camera sensor helper */ /** diff --git a/src/ipa/ipu3/ipa_context.h b/src/ipa/ipu3/ipa_context.h index 97fcf06cd4ac9ac6d64c4933fcea80ace0e572df..4544d663642fb6fde1cf69a32f1c0fbb2fbd98f6 100644 --- a/src/ipa/ipu3/ipa_context.h +++ b/src/ipa/ipu3/ipa_context.h @@ -15,6 +15,7 @@ #include #include +#include #include namespace libcamera { @@ -95,6 +96,8 @@ struct IPAContext { FCQueue frameContexts; ControlInfoMap::Map ctrlMap; + + std::unique_ptr camHelper; }; } /* namespace ipa::ipu3 */ diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp index 1cae08bf255f6f53a0ebee02ba3aadda5a650ae3..36d8f0da430a3d4f94e2a3f760850519742ea992 100644 --- a/src/ipa/ipu3/ipu3.cpp +++ b/src/ipa/ipu3/ipu3.cpp @@ -179,9 +179,6 @@ private: IPACameraSensorInfo sensorInfo_; - /* Interface to the Camera Helper */ - std::unique_ptr camHelper_; - /* Local parameter storage */ struct IPAContext context_; }; @@ -222,8 +219,8 @@ void IPAIPU3::updateSessionConfiguration(const ControlInfoMap &sensorControls) */ context_.configuration.agc.minExposureTime = minExposure * context_.configuration.sensor.lineDuration; context_.configuration.agc.maxExposureTime = maxExposure * context_.configuration.sensor.lineDuration; - context_.configuration.agc.minAnalogueGain = camHelper_->gain(minGain); - context_.configuration.agc.maxAnalogueGain = camHelper_->gain(maxGain); + context_.configuration.agc.minAnalogueGain = context_.camHelper->gain(minGain); + context_.configuration.agc.maxAnalogueGain = context_.camHelper->gain(maxGain); } /** @@ -301,8 +298,8 @@ int IPAIPU3::init(const IPASettings &settings, const ControlInfoMap &sensorControls, ControlInfoMap *ipaControls) { - camHelper_ = CameraSensorHelperFactoryBase::create(settings.sensorModel); - if (camHelper_ == nullptr) { + context_.camHelper = CameraSensorHelperFactoryBase::create(settings.sensorModel); + if (context_.camHelper == nullptr) { LOG(IPAIPU3, Error) << "Failed to create camera sensor helper for " << settings.sensorModel; @@ -597,7 +594,7 @@ void IPAIPU3::processStats(const uint32_t frame, IPAFrameContext &frameContext = context_.frameContexts.get(frame); frameContext.sensor.exposure = sensorControls.get(V4L2_CID_EXPOSURE).get(); - frameContext.sensor.gain = camHelper_->gain(sensorControls.get(V4L2_CID_ANALOGUE_GAIN).get()); + frameContext.sensor.gain = context_.camHelper->gain(sensorControls.get(V4L2_CID_ANALOGUE_GAIN).get()); ControlList metadata(controls::controls); @@ -643,7 +640,7 @@ void IPAIPU3::queueRequest(const uint32_t frame, const ControlList &controls) void IPAIPU3::setControls(unsigned int frame) { int32_t exposure = context_.activeState.agc.exposure; - int32_t gain = camHelper_->gainCode(context_.activeState.agc.gain); + int32_t gain = context_.camHelper->gainCode(context_.activeState.agc.gain); ControlList ctrls(sensorCtrls_); ctrls.set(V4L2_CID_EXPOSURE, exposure);