From patchwork Mon Nov 3 21:30:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 24956 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id F2C54BDE4C for ; Mon, 3 Nov 2025 21:29:47 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1C6D3609E0; Mon, 3 Nov 2025 22:29:46 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=igalia.com header.i=@igalia.com header.b="NvGM0LLe"; dkim-atps=neutral Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 86CF9606A0 for ; Mon, 3 Nov 2025 22:29:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5LplDBP1uUWMozLUJOJ1wlxSmSi8jM+UCwkHsYU5698=; b=NvGM0LLeQKM7bd16RF4H6ulWfA 36FKiLJ+zIATbSckt4EaJQH08sjUPLVmSARFxB7LLmXeriqw0ZViJr68NPKhyptLtzMrs25IEYlLv xDBinKVynP/5SvvZ1lskh+0nCKObXZieBbiNCQG/B2mR3rOeSFSAMpWeLLmPSMAHIDxiNqXDIkZ7Q p/1rIN2hTalZx7HgWycKqCl4+GZPfCbHp/n3GwelY9YcX8jIpC+fLp2NKZ5LHLDQP9QFcE8bCkAM2 GIWzO9cX7dI2BzVDQRrmi7Cn0Hj+6af8297I9ffZ8HUDz8GUrOA8kIfHizSaOKc8uoppGrI1/+WX8 fkG2Ryiw==; Received: from [81.140.124.245] (helo=uajain) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1vG27S-0013tS-Ee; Mon, 03 Nov 2025 22:29:42 +0100 From: Umang Jain To: libcamera-devel@lists.libcamera.org Cc: Nicolas Dufresne , Umang Jain , =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= Subject: [PATCH v4 2/3] gstreamer: Improve logging for buffer pool activation Date: Mon, 3 Nov 2025 21:30:13 +0000 Message-ID: <20251103213014.62713-3-uajain@igalia.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251103213014.62713-1-uajain@igalia.com> References: <20251103213014.62713-1-uajain@igalia.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" If the negotiation is going to fail, log the GST_ELEMENT_ERROR in gst_libcamera_src_negotiate(), instead of logging in downstream method chain. Signed-off-by: Umang Jain Reviewed-by: Nicolas Dufresne Reviewed-by: Barnabás Pőcze --- src/gstreamer/gstlibcamerasrc.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp index bd79b769..5443b062 100644 --- a/src/gstreamer/gstlibcamerasrc.cpp +++ b/src/gstreamer/gstlibcamerasrc.cpp @@ -574,12 +574,8 @@ gst_libcamera_create_video_pool(GstLibcameraSrc *self, GstPad *srcpad, gst_buffer_pool_set_config(GST_BUFFER_POOL_CAST(pool), config); } - if (!gst_buffer_pool_set_active(pool, true)) { - GST_ELEMENT_ERROR(self, RESOURCE, SETTINGS, - ("Failed to active buffer pool"), - ("gst_libcamera_src_negotiate() failed.")); + if (!gst_buffer_pool_set_active(pool, true)) return { nullptr, -EINVAL }; - } return { std::exchange(pool, nullptr), 0 }; } @@ -680,8 +676,12 @@ gst_libcamera_src_negotiate(GstLibcameraSrc *self) std::tie(video_pool, ret) = gst_libcamera_create_video_pool(self, srcpad, caps, &info); - if (ret) + if (ret) { + GST_ELEMENT_ERROR(self, RESOURCE, SETTINGS, + ("Failed to create video pool: %s", g_strerror(-ret)), + ("gst_libcamera_src_negotiate() failed.")); return false; + } } GstLibcameraPool *pool = gst_libcamera_pool_new(self->allocator,