From patchwork Fri Oct 31 09:50:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 24929 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 64FFEBE080 for ; Fri, 31 Oct 2025 09:51:04 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 295FE60971; Fri, 31 Oct 2025 10:51:03 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="NYmsw7yP"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id ABBEE606E6 for ; Fri, 31 Oct 2025 10:51:01 +0100 (CET) Received: from pb-laptop.local (185.221.140.239.nat.pool.zt.hu [185.221.140.239]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A892F1690; Fri, 31 Oct 2025 10:49:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1761904150; bh=tHr0Zd/kpd33P5sSH7WmFaQhmcn8pMhsD/VfIL2oPvY=; h=From:To:Cc:Subject:Date:From; b=NYmsw7yPItoYojoeVoNUbzbC3b3bDsAHMXYfYehtA+3gcskLnG0wljp/laCUiYskC /cqdxwmMZsLpd+0DyKb2HC3AgJNP5VgLykT0JKEid1Wa2MwI7jx6N1LRJUC2RZ13hx 6HqBiPpcvys1pw0mzoksbs0izvQ3gjht0sPN3xrI= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Cc: Laurent Pinchart , Kieran Bingham Subject: [RFC PATCH v2] utils: checkstyle.py: Accept `Closes` commit trailer Date: Fri, 31 Oct 2025 10:50:57 +0100 Message-ID: <20251031095057.1181439-1-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.51.1 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" `Closes: ` is recognized by gitlab[0] and closes the referenced issue automatically when a commit is made to the project's default branch. Now that issues are hosted on gitlab, it will be the preferred way to reference the fixed issue from a commit, so replace the previously used `Bug` with it in the checkstlye.py script. [0]: https://docs.gitlab.com/user/project/issues/managing_issues/#default-closing-pattern Signed-off-by: Barnabás Pőcze Reviewed-by: Kieran Bingham --- changes in v2: * remove `Bug` v1: https://patchwork.libcamera.org/patch/24888/ --- Still one potential question remains: should the url be restricted? I think it makes sense to allow arbitrary urls to support different bug trackers (e.g. rpi github). --- utils/checkstyle.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.51.1 diff --git a/utils/checkstyle.py b/utils/checkstyle.py index f6229bbd86..fa1355c173 100755 --- a/utils/checkstyle.py +++ b/utils/checkstyle.py @@ -541,7 +541,7 @@ class TrailersChecker(CommitChecker): known_trailers = { 'Acked-by': email_regex, - 'Bug': link_regex, + 'Closes': link_regex, 'Co-developed-by': email_regex, 'Fixes': commit_regex, 'Link': link_regex,