From patchwork Fri Oct 24 08:50:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 24795 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B7670BE080 for ; Fri, 24 Oct 2025 08:53:07 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 78DD660947; Fri, 24 Oct 2025 10:53:07 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="lcGytAZb"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 72EA860938 for ; Fri, 24 Oct 2025 10:53:06 +0200 (CEST) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:7edc:62f4:c118:1549]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id D0D6B4B0C; Fri, 24 Oct 2025 10:51:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1761295880; bh=Ik+5kjY+0todhct0SOiC4RS7hv34hhfk2uGJKgSEv/Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lcGytAZbkR4mOY+Sja1lZLX98lKIdwVHuvNcJC+4YmGiXJZBEMlNw7be5S+EPdhLU LXqn+dJfya8Q854lAF4vYI7C7Sf1nggofEHSTpFqJiv05aZJLIUjzp4CFyTNUIGKMy SSTXtAyrr0TsUk0g0pylAzZlo8UJ3lVouqUtofJc= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH v1 29/35] ipa: libipa: Reduce log level when obtaining an uninitialized frame context Date: Fri, 24 Oct 2025 10:50:53 +0200 Message-ID: <20251024085130.995967-30-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20251024085130.995967-1-stefan.klug@ideasonboard.com> References: <20251024085130.995967-1-stefan.klug@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" With the pipeline rework, it is a valid condition to obtain an uninitialized frame context. Explain that in the comment and reduce the log level. The same applies to the "already initialized" case. Signed-off-by: Stefan Klug --- src/ipa/libipa/fc_queue.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/ipa/libipa/fc_queue.h b/src/ipa/libipa/fc_queue.h index 812022c496ed..75e0072a6eb4 100644 --- a/src/ipa/libipa/fc_queue.h +++ b/src/ipa/libipa/fc_queue.h @@ -64,7 +64,7 @@ public: * an error condition ? */ if (frame != 0 && frame <= frameContext.frame_) - LOG(FCQueue, Warning) + LOG(FCQueue, Debug) << "Frame " << frame << " already initialised"; else init(fc, frame); @@ -112,12 +112,12 @@ public: * The frame context has been retrieved before it was * initialised through the initialise() call. This indicates an * algorithm attempted to access a Frame context before it was - * queued to the IPA. Controls applied for this request may be - * left unhandled. - * - * \todo Set an error flag for per-frame control errors. + * queued to the IPA. This can happen when a frame was dropped + * in the kernel. Then one frame will not be queued for the + * requests to catch up, but the pipeline will still call + * prepare on that frame. */ - LOG(FCQueue, Warning) + LOG(FCQueue, Debug) << "Obtained an uninitialised FrameContext for " << frame; init(fc, frame);