From patchwork Fri Oct 24 08:50:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 24783 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 87598C3259 for ; Fri, 24 Oct 2025 08:52:30 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 57269608D1; Fri, 24 Oct 2025 10:52:30 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="utCxFLu3"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C63E3608C3 for ; Fri, 24 Oct 2025 10:52:28 +0200 (CEST) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:7edc:62f4:c118:1549]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 55D4921D0; Fri, 24 Oct 2025 10:50:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1761295843; bh=tJZqo5Jgcw4iWuPX5RG+D/HiDG+3K7kFUCiaYJdlh7E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=utCxFLu3vZU/xwqzajsGRbsOU0N3gw1DXPyi5S7LaNW8llWbDV2Q/6xGCOrAmBYmE qEVe9dhggNcaRvo+UstpVQbtMHvf2Xm+PBGK6OypInd3FAc4UVT54w6sZJPD89EmCN 3ZW1R3cpcMPx6Hh8aGMO1vnK5tBPvEQwi3eD57ns= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH v1 17/35] ipa: rkisp1: agc: Fix vblank, when computeParams prepare is not called Date: Fri, 24 Oct 2025 10:50:41 +0200 Message-ID: <20251024085130.995967-18-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20251024085130.995967-1-stefan.klug@ideasonboard.com> References: <20251024085130.995967-1-stefan.klug@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" In raw capture mode, prepare() is not called at all. Ensure that vblank is still calculated corresctly. Signed-off-by: Stefan Klug --- src/ipa/rkisp1/algorithms/agc.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp index 5ce77b7672f2..7c9538f95cbe 100644 --- a/src/ipa/rkisp1/algorithms/agc.cpp +++ b/src/ipa/rkisp1/algorithms/agc.cpp @@ -340,6 +340,9 @@ void Agc::queueRequest(IPAContext &context, } frameContext.agc.minFrameDuration = agc.minFrameDuration; frameContext.agc.maxFrameDuration = agc.maxFrameDuration; + + /* V-blank needs to be valid for the start controls handling. Update it. */ + processFrameDuration(context, frameContext); } /**