From patchwork Fri Oct 24 07:54:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 24765 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 6D712C3259 for ; Fri, 24 Oct 2025 07:55:05 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9ACF360835; Fri, 24 Oct 2025 09:55:04 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="YtNQ2sNJ"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7ABBD606E1 for ; Fri, 24 Oct 2025 09:55:03 +0200 (CEST) Received: from pb-laptop.local (185.221.141.231.nat.pool.zt.hu [185.221.141.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 73AAD1AA6; Fri, 24 Oct 2025 09:53:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1761292397; bh=XkCiTV1TIDfRI4ulTMarSLBMJxLmjqMOz28dwhckVW0=; h=From:To:Cc:Subject:Date:From; b=YtNQ2sNJN/fTJuLz4GzUkbKsolDhK8oThIwNwolDg9TUWz8+Esw0TYPpCB/1zBy28 kOiYCk+tzHvSvrvtYtNLfj/XA1K1Y+kcvHUq2qwg/qpys8ubm/LIZC0LTx7cPLj9hg 27l6Uaz9swrdSj8ZQX0KfVHT79Wz0WMUfX8amPqk= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Cc: Kieran Bingham , Naushir Patuck , Daniel Scally Subject: [RFC PATCH v2] libipa: camera_sensor_helper: Add imx708 Date: Fri, 24 Oct 2025 09:54:59 +0200 Message-ID: <20251024075459.1200809-1-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.51.1.dirty MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Daniel Scally The imx708 sensor driver has long been available, especially in raspberry pi kernels; and the raspberry pi ipa module has had the corresponding helper class since 2023 (952ef94ed78d71). The camera sensor properties database also has an entry for it (2fb0f250196326), but the camera sensor helper class is missing from the common libipa component. So add it, with the same gain formula as the raspberry pi ipa module. Handling the raspberry pi specific "wide" / "noir" suffixes is omitted. They are not present in the camera sensor properties database either. Signed-off-by: Daniel Scally [Extend commit message.] Signed-off-by: Barnabás Pőcze Reviewed-by: Kieran Bingham --- changes in v2: * drop rpi specific suffixes v1: https://patchwork.libcamera.org/patch/24708/ --- src/ipa/libipa/camera_sensor_helper.cpp | 10 ++++++++++ 1 file changed, 10 insertions(+) -- 2.51.1.dirty diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp index ef3bd0d62..1f2a95e56 100644 --- a/src/ipa/libipa/camera_sensor_helper.cpp +++ b/src/ipa/libipa/camera_sensor_helper.cpp @@ -642,6 +642,16 @@ public: }; REGISTER_CAMERA_SENSOR_HELPER("imx477", CameraSensorHelperImx477) +class CameraSensorHelperImx708 : public CameraSensorHelper +{ +public: + CameraSensorHelperImx708() + { + gain_ = AnalogueGainLinear{ 0, 1024, -1, 1024 }; + } +}; +REGISTER_CAMERA_SENSOR_HELPER("imx708", CameraSensorHelperImx708) + class CameraSensorHelperOv2685 : public CameraSensorHelper { public: