From patchwork Tue Jan 15 23:19:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 247 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0088E60C99 for ; Wed, 16 Jan 2019 00:19:15 +0100 (CET) Received: from localhost.localdomain (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 93A089DC; Wed, 16 Jan 2019 00:19:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1547594354; bh=CJ93eiZh/iCm5BWAn1wDJ1LR1lzR7Ubm/007oRBS9lQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tsmHAkAtooISK+tJaFW6Z2i2SfTVprqygefRsLx+YoPI9oHE2jCUObzAeUXHSz5X/ +81/s+Y511SyKwjd6wTUDtJSHI3/wpCU+KjWUBErtNYXCcyznmNHrGxhJlcyxy912Q bq35ww3/fCIQYM1e3uipOHBIXkHXiKdKWIIIqTew= From: Kieran Bingham To: LibCamera Devel Date: Tue, 15 Jan 2019 23:19:09 +0000 Message-Id: <20190115231909.19893-4-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190115231909.19893-1-kieran.bingham@ideasonboard.com> References: <20190115231909.19893-1-kieran.bingham@ideasonboard.com> Subject: [libcamera-devel] [PATCH v3 3/3] test: v4l2_device: Add test suite and initial test X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jan 2019 23:19:15 -0000 Provide a base class to construct a v4l2_device object for further tests and an initial test which validates the FD handle can not be leaked. Signed-off-by: Kieran Bingham Reviewed-by: Niklas Söderlund --- test/meson.build | 1 + test/v4l2_device/double_open.cpp | 38 +++++++++++++++++++++++ test/v4l2_device/meson.build | 12 ++++++++ test/v4l2_device/v4l2_device_test.cpp | 43 +++++++++++++++++++++++++++ test/v4l2_device/v4l2_device_test.h | 27 +++++++++++++++++ 5 files changed, 121 insertions(+) create mode 100644 test/v4l2_device/double_open.cpp create mode 100644 test/v4l2_device/meson.build create mode 100644 test/v4l2_device/v4l2_device_test.cpp create mode 100644 test/v4l2_device/v4l2_device_test.h diff --git a/test/meson.build b/test/meson.build index 32152888a55e..fb6b115eb2ab 100644 --- a/test/meson.build +++ b/test/meson.build @@ -1,6 +1,7 @@ subdir('libtest') subdir('media_device') +subdir('v4l2_device') public_tests = [ ['event', 'event.cpp'], diff --git a/test/v4l2_device/double_open.cpp b/test/v4l2_device/double_open.cpp new file mode 100644 index 000000000000..ca2b201454a4 --- /dev/null +++ b/test/v4l2_device/double_open.cpp @@ -0,0 +1,38 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Copyright (C) 2019, Google Inc. + * + * libcamera V4L2 API tests + */ + +#include + +#include "v4l2_device_test.h" + +namespace { + +class DoubleOpen : public V4L2DeviceTest +{ +protected: + int run() + { + int ret; + + /* + * Expect failure: The device has already been opened by the + * V4L2DeviceTest base class + */ + ret = dev_->open(); + if (!ret) { + std::cout << "Double open erroneously succeeded" << std::endl; + dev_->close(); + return TestFail; + } + + return TestPass; + } +}; + +} /* namespace */ + +TEST_REGISTER(DoubleOpen); diff --git a/test/v4l2_device/meson.build b/test/v4l2_device/meson.build new file mode 100644 index 000000000000..41675a303498 --- /dev/null +++ b/test/v4l2_device/meson.build @@ -0,0 +1,12 @@ +# Tests are listed in order of complexity. +# They are not alphabetically sorted. +v4l2_device_tests = [ + [ 'double_open', 'double_open.cpp' ], +] + +foreach t : v4l2_device_tests + exe = executable(t[0], [t[1], 'v4l2_device_test.cpp'], + link_with : test_libraries, + include_directories : test_includes_internal) + test(t[0], exe, suite: 'v4l2_device', is_parallel: false) +endforeach diff --git a/test/v4l2_device/v4l2_device_test.cpp b/test/v4l2_device/v4l2_device_test.cpp new file mode 100644 index 000000000000..362553712caa --- /dev/null +++ b/test/v4l2_device/v4l2_device_test.cpp @@ -0,0 +1,43 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Copyright (C) 2019, Google Inc. + * + * libcamera V4L2 API tests + */ + +#include +#include + +#include "v4l2_device_test.h" + +using namespace libcamera; + +bool exists(const std::string &path) +{ + struct stat sb; + + if (stat(path.c_str(), &sb) == 0) + return true; + + return false; +} + +int V4L2DeviceTest::init() +{ + const std::string device("/dev/video0"); + + /* Validate the device node exists. */ + if (!exists(device)) { + std::cout << "No video device available" << std::endl; + return TestSkip; + } + + dev_ = new V4L2Device(device); + + return dev_->open(); +} + +void V4L2DeviceTest::cleanup() +{ + delete dev_; +}; diff --git a/test/v4l2_device/v4l2_device_test.h b/test/v4l2_device/v4l2_device_test.h new file mode 100644 index 000000000000..405cb7d6f404 --- /dev/null +++ b/test/v4l2_device/v4l2_device_test.h @@ -0,0 +1,27 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Copyright (C) 2018, Google Inc. + * + * vl42device_test.h - libcamera v4l2device test base class + */ +#ifndef __LIBCAMERA_V4L2_DEVICE_TEST_H_ +#define __LIBCAMERA_V4L2_DEVICE_TEST_H_ + +#include "test.h" +#include "v4l2_device.h" + +using namespace libcamera; + +class V4L2DeviceTest : public Test +{ +public: + V4L2DeviceTest() : dev_(nullptr) { }; + +protected: + int init(); + void cleanup(); + + V4L2Device *dev_; +}; + +#endif /* __LIBCAMERA_V4L2_DEVICE_TEST_H_ */