From patchwork Wed Oct 15 01:22:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 24649 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 78758C3331 for ; Wed, 15 Oct 2025 01:23:04 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id CA48C605FF; Wed, 15 Oct 2025 03:23:03 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="fZe0xwMW"; dkim-atps=neutral Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F76D6060A for ; Wed, 15 Oct 2025 03:22:59 +0200 (CEST) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-b3ee18913c0so965005166b.3 for ; Tue, 14 Oct 2025 18:22:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760491379; x=1761096179; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Iq/QQZnzG0Y02cPlHt1zWbTY7RnwaVpFXzmCvziIA+w=; b=fZe0xwMWMGo8C6oUdOa/l40J7hzAs5KkvvyTHKyCzyNo9TyJZQLY+n6yj6a716qGE2 BuU4aOvwbIxALS9ZpisJtT9QYM67bcOgFIQQnXWwnfhUlHHFc/PU5MAFC820QofLouuk 6/2xdPiunkrMKbpi+T2OmULkB1wpKO2v0JOYC1UrGV2yeo77y6iUhK0FxzMsdywhRiR1 OYVMJ/ti/E6Q7xADyN8ZpWb23QTbkLISevHgt2Ius2TFqA568xwVnv8FOpPsqj63fKwT gjmPfzgyqUzj8OEJ/vfsEAGY5jbWFgWGqTc1KOVVWTy5U8DYLb8Kecgr2Rcy69vE90m5 Ak8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760491379; x=1761096179; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Iq/QQZnzG0Y02cPlHt1zWbTY7RnwaVpFXzmCvziIA+w=; b=luaSZO7i69z7xAIgqiLLUdLuWB8VJHn56dC9W5dD9ZjKoGWJAvDaUwbiioTNdwghr5 1wbwxhh5NGXPUMrZjJ2lQjkgDrFhUq7zl+G+X9Pg4bDSHfwNYRz9QDeZ3GHlKRxtleuW M/GkrAe1EA+vC537PtoCOPivMrNJXeulhAriZ+dDxK+dbuYNG6pcmsFKy/0H30Dn5/Sd ipb9YCV4Z/zV9Z8Qdq9qYiJR8eEDhlx0UDA6XF40i1DEUQ9PZuVlEQcKQcIXfdFd2Lo1 ZJ2vvpnBeqO7yumnJYedRi39n9t2o08xVDQrymmag7mhTiomCT0DsSbkWXbB8iro17O0 pYFg== X-Gm-Message-State: AOJu0YziFSph9pxJwuGk2iDr0kHFIMzzejNNS4skoR48ud2cc0jF0rKX mTTdIB3OvIMyd6EHI8qERQmWLpBZP0hM+PP4W3Oi4MTnnOmo8Uyu30Vgzt477Ao7zevNogG2V9T Q/wYb X-Gm-Gg: ASbGncvWKj/T7YdUE4f8X+ySdMkjXkdVqlH0+2Lw7fPITalHt4T8Wr8jJZZUO4sNtqD hAtTzcbR2ax1Z3ZNQVauW66/RF0T3YoqB3e2Ivzf0rEPmpMy3zQlm+Js/7B1hidcQbPZ/Bb7uoy 5Uzpu6h7BqsmeQxbTQZYccfAm786cvWcuoLToYtq6qBjIR4bIuIKJrgYGctWrHt3GGFt0FLkORB EQgC5v6mwW5bjEcqMVdNf9YsDkKgQzTUUxtrROxSQo88ZcaQ3VyOGAH0kX8w2tbnuI1Ctm8iy6P cji+b2UB4n91/9E6D8nW1jkA3Hn7+07pRPG89GQ2+GCrZ+BtvqvzLq04i1uBrMBPePd68wThC54 CtMfqIDpbb0FD0eBnQ4zX+1QQDULr1s7TozifJIlkcZmzy40CrOrFaDRXXoER4PACVr3EoXEoqP 7EdJExu78YURVPkn8+eHfA31yJe3X7gOhtXuWKhahK X-Google-Smtp-Source: AGHT+IFV7v50DkMRAyePLHrzpFA9FM4KFCTak0EP0i1/fA8DD4uhz+zlRSUno72VWuZKT5drN37Svw== X-Received: by 2002:a17:906:fa0e:b0:b55:a883:63c4 with SMTP id a640c23a62f3a-b55a8841f25mr1816867066b.10.1760491378718; Tue, 14 Oct 2025 18:22:58 -0700 (PDT) Received: from inspiron14p-linux.nxsw.local (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b5ccd7b202dsm98348466b.82.2025.10.14.18.22.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Oct 2025 18:22:58 -0700 (PDT) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org, bod.linux@nxsw.ie, Kieran Bingham Subject: [PATCH v3 04/39] libcamera: swstats_cpu: Update statsProcessFn() / processLine0() documentation Date: Wed, 15 Oct 2025 02:22:16 +0100 Message-ID: <20251015012251.17508-5-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251015012251.17508-1-bryan.odonoghue@linaro.org> References: <20251015012251.17508-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Hans de Goede Update the documentation of the statsProcessFn() / processLine0() src[] pointer argument to take into account that swstats_cpu may also be used with planar input data or with non Bayer single plane input data. The statsProcessFn typedef is private, so no documentation is generated for it. Move the new updated src[] pointer argument documentation to processLine0() so that it gets included in the generated docs. Reviewed-by: Kieran Bingham Reviewed-by: Milan Zamazal Signed-off-by: Hans de Goede Signed-off-by: Bryan O'Donoghue --- src/libcamera/software_isp/swstats_cpu.cpp | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp index 4f7bdd23..9c03338a 100644 --- a/src/libcamera/software_isp/swstats_cpu.cpp +++ b/src/libcamera/software_isp/swstats_cpu.cpp @@ -72,6 +72,19 @@ namespace libcamera { * patternSize height == 1. * It'll process line 0 and 1 for input formats with patternSize height >= 2. * This function may only be called after a successful setWindow() call. + * + * This function takes an array of src pointers each pointing to a line in + * the source image. + * + * Bayer input data requires (patternSize_.height + 1) src pointers, with + * the middle element of the array pointing to the actual line being processed. + * Earlier element(s) will point to the previous line(s) and later element(s) + * to the next line(s). See the DebayerCpu::debayerFn documentation for details. + * + * Planar input data requires a src pointer for each plane, with src[0] pointing + * to the line in plane 0, etc. + * + * For non Bayer single plane input data only a single src pointer is required. */ /**