From patchwork Sat Oct 11 16:03:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 24593 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B5FECC3331 for ; Sat, 11 Oct 2025 16:03:51 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 92D3860461; Sat, 11 Oct 2025 18:03:48 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="TLqXATX+"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E9FC60443 for ; Sat, 11 Oct 2025 18:03:43 +0200 (CEST) Received: from charm.hippo-penny.ts.net (cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2E6BAF0F; Sat, 11 Oct 2025 18:02:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1760198527; bh=Ha/BSR0e6IO1ScJhvHZHHgbiYlSuK3dxK9DL3yf6IJ4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TLqXATX+j8s0fjx8nLwwuy//9sKIt9TNdUaZQ/2c+f2OhkMyXtsopTNAudyOnWitG cH+4O3Hv3ef4Y0XhawEmHR1OShItSTYproxkO88gj1kKrFZ+qJIZx30gadC7+IqMU/ 3x1lxaCwmXpKiQRWyhf/q+8TvZVMMpm0lfBEcdPw= From: Kieran Bingham To: libcamera devel Cc: Kieran Bingham Subject: [RFC PATCH 5/7] ipa: softipa: Pass IPACameraSensorInfo to configure Date: Sat, 11 Oct 2025 17:03:33 +0100 Message-ID: <20251011160335.50578-6-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251011160335.50578-1-kieran.bingham@ideasonboard.com> References: <20251011160335.50578-1-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Pass the CameraSensorInfo in to the configure phase of the IPA from the CameraSensor class, allowing the context to be used when configuring the IPA. Signed-off-by: Kieran Bingham --- include/libcamera/ipa/soft.mojom | 1 + src/libcamera/pipeline/simple/simple.cpp | 10 ++++++++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/include/libcamera/ipa/soft.mojom b/include/libcamera/ipa/soft.mojom index 3acac53981e7..7bdbb65b4458 100644 --- a/include/libcamera/ipa/soft.mojom +++ b/include/libcamera/ipa/soft.mojom @@ -9,6 +9,7 @@ module ipa.soft; import "include/libcamera/ipa/core.mojom"; struct IPAConfigInfo { + libcamera.IPACameraSensorInfo sensorInfo; libcamera.ControlInfoMap sensorControls; }; diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp index a7e7ac25bac2..7d56effec50b 100644 --- a/src/libcamera/pipeline/simple/simple.cpp +++ b/src/libcamera/pipeline/simple/simple.cpp @@ -1412,8 +1412,14 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c) if (data->converter_) { return data->converter_->configure(inputCfg, outputCfgs); } else { - ipa::soft::IPAConfigInfo configInfo; - configInfo.sensorControls = data->sensor_->controls(); + IPACameraSensorInfo sensorInfo; + ret = data->sensor_->sensorInfo(&sensorInfo); + if (ret) + return ret; + + ipa::soft::IPAConfigInfo configInfo{ sensorInfo, + data->sensor_->controls() }; + return data->swIsp_->configure(inputCfg, outputCfgs, configInfo, &data->controlInfo_); } }