From patchwork Fri Oct 10 09:22:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Robert Mader X-Patchwork-Id: 24577 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 0F47DC3264 for ; Fri, 10 Oct 2025 09:23:12 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3DE426B599; Fri, 10 Oct 2025 11:23:11 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=collabora.com header.i=robert.mader@collabora.com header.b="XcUMeiVd"; dkim-atps=neutral Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B8BC8613AB for ; Fri, 10 Oct 2025 11:23:09 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; t=1760088187; cv=none; d=zohomail.com; s=zohoarc; b=UyAvrZR7tY6ln19yW15dCqjJyT4SmSfuHLnFii/70fQZkyJQYjAZm2wp3vA8OCSMzsOXeOzSAAAhdXRBN0eHlyvwFk7WDuTvYhHkXDwSHAYyC8LiWb4rUL7wMEafrysiltGH4GK591HaQ8eRnGCzXezbBIvHfErq2v+A2J+HcMY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760088187; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=8lcTgiz/DVIok3LYZLg2U1P8XsmQ7i4ZElFOGyyw9C0=; b=cnHvESd0zZ5tBV4DWPy5d15ZL8s9bvI5bavs0od+nq2GuujXDJ5xthwnmcuvRZy2lHn8vHHEWPjT82YH7BmHf3AJDmkhqNth+8rVWCXQe7CmOIJWe/FFQuJBCLVfDJxzE1eCf/DrZ7oi6LAWDJGfws25cgiVnn6m+fLvtjuH83s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=robert.mader@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1760088187; s=zohomail; d=collabora.com; i=robert.mader@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=8lcTgiz/DVIok3LYZLg2U1P8XsmQ7i4ZElFOGyyw9C0=; b=XcUMeiVdNIcmB6Ieh7QVMR3arEM1bp4Oc1CesfQwHPprx4ylT6fcNOFgXti3fJbz 3BfBJYoPmPxxVKhHqASpw2zEeS3uw/x4qQ0QgEtpIJKA3lodOaoHYjauZoLd4tdA1jA PlBPA/PSXCoK4gr05Fbhy05vCdYDNnKdDf7VD9uI= Received: by mx.zohomail.com with SMTPS id 1760088185982806.8245937455339; Fri, 10 Oct 2025 02:23:05 -0700 (PDT) From: Robert Mader To: libcamera-devel@lists.libcamera.org Cc: Robert Mader , =?utf-8?q?Barnab=C3=A1s_P?= =?utf-8?b?xZFjemU=?= Subject: [PATCH v4 3/3] pipeline: simple: Initialize maxQueuedRequestsDevice to 4 Date: Fri, 10 Oct 2025 11:22:26 +0200 Message-ID: <20251010092226.41228-3-robert.mader@collabora.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251010092226.41228-1-robert.mader@collabora.com> References: <20251010092226.41228-1-robert.mader@collabora.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Now that the pipeline handler supports high buffer counts, apps may queue more requests, exhausting e.g. frame contexts (see ipa::soft::kMaxFrameContexts => 16). Thus limit the number of queued requests to 4, corresponding to the the previous buffer limit. Suggested-by: Barnabás Pőcze Signed-off-by: Robert Mader Reviewed-by: Kieran Bingham Tested-by: Barnabás Pőcze --- src/libcamera/pipeline/simple/simple.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp index c4cb7c391..dec9f6514 100644 --- a/src/libcamera/pipeline/simple/simple.cpp +++ b/src/libcamera/pipeline/simple/simple.cpp @@ -420,6 +420,7 @@ protected: int queueRequestDevice(Camera *camera, Request *request) override; private: + static constexpr unsigned int kMaxQueuedRequestsDevice = 4; static constexpr unsigned int kNumInternalBuffers = 4; struct EntityData { @@ -1287,7 +1288,8 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate() */ SimplePipelineHandler::SimplePipelineHandler(CameraManager *manager) - : PipelineHandler(manager), converter_(nullptr) + : PipelineHandler(manager, kMaxQueuedRequestsDevice), + converter_(nullptr) { }