From patchwork Tue Oct 7 18:17:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 24569 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id BA913BF415 for ; Tue, 7 Oct 2025 18:18:01 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A347E6B5AA; Tue, 7 Oct 2025 20:17:57 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="rP70+HhP"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E1EA6B5AA for ; Tue, 7 Oct 2025 20:17:54 +0200 (CEST) Received: from [192.168.1.102] (93-61-96-190.ip145.fastwebnet.it [93.61.96.190]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 14DA06DF; Tue, 7 Oct 2025 20:16:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1759860980; bh=Xn18toPmvYwkT3H1mYGXtvtgr+abkKDv+2itl2J4ueU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=rP70+HhP50R31HKGJ6kWmKNUIG5psYNTARCh+Nt6E0y2rRDgfVGOV65JH6qGVZKOO jQVK2N/Q25Dg/0/wpHDXG/yA/zzu+hJv04bLX+0AMLJuPhjKLQB+SvVNsrvO3oj2+b qkVWHccACEYbceKtXKmoN5N0xsJxcWu7xlUvFkJY= From: Jacopo Mondi Date: Tue, 07 Oct 2025 20:17:44 +0200 Subject: [PATCH v5 2/5] include: linux: Add v4l2-isp.h MIME-Version: 1.0 Message-Id: <20251007-v4l2-params-v5-2-8db451a81398@ideasonboard.com> References: <20251007-v4l2-params-v5-0-8db451a81398@ideasonboard.com> In-Reply-To: <20251007-v4l2-params-v5-0-8db451a81398@ideasonboard.com> To: libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi , Antoine Bouyer , Laurent Pinchart X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4970; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=Xn18toPmvYwkT3H1mYGXtvtgr+abkKDv+2itl2J4ueU=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBo5VlPB76vOReh1tcmMk51bR6RRr74JJu8hTTd6 aS9agGucy6JAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaOVZTwAKCRByNAaPFqFW PNHDEAClTCkNL0KXEUkhKLD2nZCCFNZ4WvEnYu2kNQcHJ2tXidm7oP7nNJPIVn7H5kzprg1cxT3 FDBCW6ZyV1GLedJ4uR9o8Yi0uCdlKMF42+phxb4KXWWUEJY9tQRfs8Y3fho6qfgVe40CfGsB0o4 lozka3vNH46N/eunUgcrgR0ANDblVRZ5Fnj/U06mKlljALTFgnJ3AMR5zRkpdbdKaYOh+NIdo17 QsrAtpM1kGmZUs4keqUKkeZVT0mVKivfip5TRqzr+X4h0smcs9h/LFu+YJ79Mf8GJN2quRMQGNP o9NdO6rqrH6l5DLBftIGTdwTm05b9pLEnU7PBaUyT2zhTBwxm2ZQt9A6foO77kDcwtJfSHlStVy pWzhw5t1fR03AXRn3OXoWM4HoEsQGJUjw4gG0fuwd1d8By+3oTrgAjlfiJAMsAswzxdbOETuRuC uunjBMQSlWQa3P/KiL4Vmd8baqZZzh2wQqL0xpiDKRb3lnTYZl5TimJaqTR1UHQ1T6pl6rI7CoT FF0YzpzlW81FuWee6E1ja8ZrcrbMLpUJe6ezUQTFUZL9BZ1nBCHOOCMKHS7Z5aOQeflGhRvp9pS xst3tsazDDqgPEsdErjaydiLOucBD9HSB/vd+PMwoBBSsABlwV83F46ix1Cc0X10E/yiJeOktQN vlchy4xXS1k7R1A== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Import the v4l2-isp.h header from the Linux kernel sources. The file has not been merged in mainline Linux yet but is available at v6: https://lore.kernel.org/all/20251007-extensible-parameters-validation-v6-1-5f719d9f39e5@ideasonboard.com Create the include/linux/media/ directory so that header files exported from the kernel which include this file do not need to be adjusted when imported in libcamera. Signed-off-by: Jacopo Mondi Tested-by: Antoine Bouyer Reviewed-by: Laurent Pinchart --- include/linux/media/v4l2-isp.h | 82 ++++++++++++++++++++++++++++++++++++++++++ utils/update-kernel-headers.sh | 1 + 2 files changed, 83 insertions(+) diff --git a/include/linux/media/v4l2-isp.h b/include/linux/media/v4l2-isp.h new file mode 100644 index 0000000000000000000000000000000000000000..49b451e30d88cce7d15ab40e6a3d533c7bb7a12c --- /dev/null +++ b/include/linux/media/v4l2-isp.h @@ -0,0 +1,82 @@ +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ +/* + * Video4Linux2 generic ISP parameters and statistics support + * + * Copyright (C) 2025 Ideas On Board Oy + * Author: Jacopo Mondi + */ + +#ifndef _V4L2_ISP_H_ +#define _V4L2_ISP_H_ + +#include +#include + +#define V4L2_ISP_PARAMS_FL_BLOCK_DISABLE (1U << 0) +#define V4L2_ISP_PARAMS_FL_BLOCK_ENABLE (1U << 1) + +/* + * Reserve the first 8 bits for V4L2_ISP_PARAMS_FL_* flag. + * + * Driver-specific flags should be defined as: + * #define DRIVER_SPECIFIC_FLAG0 ((1U << V4L2_ISP_PARAMS_FL_DRIVER_FLAGS(0)) + * #define DRIVER_SPECIFIC_FLAG1 ((1U << V4L2_ISP_PARAMS_FL_DRIVER_FLAGS(1)) + */ +#define V4L2_ISP_PARAMS_FL_DRIVER_FLAGS(n) ((n) + 8) + +/** + * struct v4l2_isp_params_block_header - V4L2 extensible parameters block header + * @type: The parameters block type (driver-specific) + * @flags: A bitmask of block flags (driver-specific) + * @size: Size (in bytes) of the parameters block, including this header + * + * This structure represents the common part of all the ISP configuration + * blocks. Each parameters block shall embed an instance of this structure type + * as its first member, followed by the block-specific configuration data. + * + * The @type field is an ISP driver-specific value that identifies the block + * type. The @size field specifies the size of the parameters block. + * + * The @flags field is a bitmask of per-block flags V4L2_PARAMS_ISP_FL_* and + * driver-specific flags specified by the driver header. + */ +struct v4l2_isp_params_block_header { + __u16 type; + __u16 flags; + __u32 size; +} __attribute__((aligned(8))); + +/** + * struct v4l2_isp_params_buffer - V4L2 extensible parameters configuration + * @version: The parameters buffer version (driver-specific) + * @data_size: The configuration data effective size, excluding this header + * @data: The configuration data + * + * This structure contains the configuration parameters of the ISP algorithms, + * serialized by userspace into a data buffer. Each configuration parameter + * block is represented by a block-specific structure which contains a + * :c:type:`v4l2_isp_params_block_header` entry as first member. Userspace + * populates the @data buffer with configuration parameters for the blocks that + * it intends to configure. As a consequence, the data buffer effective size + * changes according to the number of ISP blocks that userspace intends to + * configure and is set by userspace in the @data_size field. + * + * The parameters buffer is versioned by the @version field to allow modifying + * and extending its definition. Userspace shall populate the @version field to + * inform the driver about the version it intends to use. The driver will parse + * and handle the @data buffer according to the data layout specific to the + * indicated version and return an error if the desired version is not + * supported. + * + * For each ISP block that userspace wants to configure, a block-specific + * structure is appended to the @data buffer, one after the other without gaps + * in between. Userspace shall populate the @data_size field with the effective + * size, in bytes, of the @data buffer. + */ +struct v4l2_isp_params_buffer { + __u32 version; + __u32 data_size; + __u8 data[] __counted_by(data_size); +}; + +#endif /* _V4L2_ISP_H_ */ diff --git a/utils/update-kernel-headers.sh b/utils/update-kernel-headers.sh index 666624f9972ea61067e5b5695237ab7a17c61664..857601df8766c6493e51b62f0f9ca551d7efbd4a 100755 --- a/utils/update-kernel-headers.sh +++ b/utils/update-kernel-headers.sh @@ -56,6 +56,7 @@ headers=" linux/udmabuf.h linux/v4l2-common.h linux/v4l2-controls.h + linux/v4l2-isp.h linux/v4l2-mediabus.h linux/v4l2-subdev.h linux/videodev2.h