From patchwork Fri Oct 3 09:27:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 24556 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 94479C3261 for ; Fri, 3 Oct 2025 09:27:48 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 23F4D6B5FE; Fri, 3 Oct 2025 11:27:45 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Wwki69jI"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 787F16B5F0 for ; Fri, 3 Oct 2025 11:27:40 +0200 (CEST) Received: from [192.168.1.102] (93-61-96-190.ip145.fastwebnet.it [93.61.96.190]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8EBC219DC; Fri, 3 Oct 2025 11:26:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1759483569; bh=hLwTmOJVVPHSSQUncjmyXZHEHG/cMq3kRVtjAUQ1jPM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Wwki69jIEEMqcBJuRuUBTRwItJ5m6EOawhp+nkfa1f7t0ESO2iDq9xQ0gLHQMkl/b ctIYxo+RCReYoShznKD2pvnQUyVwsMSNIqO111vFV360OGRqF8tUkeoTtjW998WLi0 kDXiw2Q73h5bWRzEWUJ5tiWoZh+z5lc+OJNCLsXk= From: Jacopo Mondi Date: Fri, 03 Oct 2025 11:27:30 +0200 Subject: [PATCH 2/2] ipa: ipa_module: Remove pipelineName MIME-Version: 1.0 Message-Id: <20251003-ipa-match-by-name-v1-2-07b796729412@ideasonboard.com> References: <20251003-ipa-match-by-name-v1-0-07b796729412@ideasonboard.com> In-Reply-To: <20251003-ipa-match-by-name-v1-0-07b796729412@ideasonboard.com> To: libcamera-devel@lists.libcamera.org, =?utf-8?q?Niklas_S=C3=B6derlund?= , Hans de Goede Cc: Jacopo Mondi X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=6631; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=hLwTmOJVVPHSSQUncjmyXZHEHG/cMq3kRVtjAUQ1jPM=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBo35cKQ2ew+5YL/czJ7tksfo15gqpgOSZV4Z6Nz k6UoblaxbuJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaN+XCgAKCRByNAaPFqFW PGBlEACb5vZXBJMHrwN52XbQsF8b4BmYqBaQDCmjnLr80JRzviqL3Z73gxUVlWMK9PhnQvJ8TkV zHV2tkiNQoCxEm6T1W8mhTJWzwQbHFhhEwmsyOjakZATzdoB8fN4aKJjnOS5h24Iy0YsXlgYo03 YrV4+lKc2TZr6bY5E6TWwHNx72kJmZwEsA1Ghe1drwLRKvQX7eyFC4l3wdtATMfF8Nc+gCdYRec plMBHqYXmq8N/mGbThMAKVgo5q+GPHZKjbhWPlrjvDTyoRwmE32U6bXARGKGVA10q+XBfURDMU7 M1Dmh/1sJMvOikxIWjV67wdU56j3wCezbPpr3MNIMRa3cK/N/3HF6v1MD/3pFwCCAYqdAkExots ruBS+Qnsk8wU4pxg7d0POo7wYDbzkrlIvqPwcID2mrXQjW0U2G52C36VFA6DS2+hqvRMfB862wi vYcYGV/DwqC7My96rDkfvhvq6QQpy2QLyDaFjSxdzHa+Hk2PBLOAoe7OMLIIA9N8SZPVF9NdzUG wMMytQWLYgf1RqWsFMHu6NxXPcr7u5Gjd6YsjbRM5hat/i10FhK789RYvaBFPF2j5Tlbb5Y1B53 oVak4OEg7gcHA8hghvoCuo+IrB/5TLKOBDz9kzty0Myt7gAxFv+0fwMvcNxD9Rhu1slsL05pQyx mRm4LN+cgfymFzw== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" All the IPA modules declare a pipelineName that is identical to their name. As we now support creating IPAs by name (either explicitly provided by the pipeline handlers or by using the pipeline name), the duplicated information in IPAModuleInfo is redundant. Remove it. Signed-off-by: Jacopo Mondi Reviewed-by: Barnabás Pőcze Reviewed-by: Kieran Bingham --- include/libcamera/ipa/ipa_module_info.h | 1 - src/ipa/ipu3/ipu3.cpp | 1 - src/ipa/mali-c55/mali-c55.cpp | 1 - src/ipa/rkisp1/rkisp1.cpp | 1 - src/ipa/rpi/pisp/pisp.cpp | 1 - src/ipa/rpi/vc4/vc4.cpp | 1 - src/ipa/simple/soft_simple.cpp | 1 - src/ipa/vimc/vimc.cpp | 1 - src/libcamera/ipa_module.cpp | 15 ++++++--------- test/ipa/ipa_module_test.cpp | 3 --- 10 files changed, 6 insertions(+), 20 deletions(-) diff --git a/include/libcamera/ipa/ipa_module_info.h b/include/libcamera/ipa/ipa_module_info.h index 3507a6d7678a3fd171c9239967d4667381ac3ea6..436ec82d7750d1ab7901499f4c4d88f0a173b563 100644 --- a/include/libcamera/ipa/ipa_module_info.h +++ b/include/libcamera/ipa/ipa_module_info.h @@ -16,7 +16,6 @@ namespace libcamera { struct IPAModuleInfo { int moduleAPIVersion; uint32_t pipelineVersion; - char pipelineName[256]; char name[256]; } __attribute__((packed)); diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp index 1cae08bf255f6f53a0ebee02ba3aadda5a650ae3..a714024129b688b0579662ac7d6d9c3ffc15b62a 100644 --- a/src/ipa/ipu3/ipu3.cpp +++ b/src/ipa/ipu3/ipu3.cpp @@ -672,7 +672,6 @@ const struct IPAModuleInfo ipaModuleInfo = { IPA_MODULE_API_VERSION, 1, "ipu3", - "ipu3", }; /** diff --git a/src/ipa/mali-c55/mali-c55.cpp b/src/ipa/mali-c55/mali-c55.cpp index 7d45e7310aecdae0e47655e6d2e8830e776d74cd..e52e89be7c7e34310ca866bcbea2134833e967db 100644 --- a/src/ipa/mali-c55/mali-c55.cpp +++ b/src/ipa/mali-c55/mali-c55.cpp @@ -387,7 +387,6 @@ const struct IPAModuleInfo ipaModuleInfo = { IPA_MODULE_API_VERSION, 1, "mali-c55", - "mali-c55", }; IPAInterface *ipaCreate() diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp index fa22bfc349043002345d275b11a60ac983e329d7..a8e46094bdb9c431eb9143cccfa88e8ae7a3c04f 100644 --- a/src/ipa/rkisp1/rkisp1.cpp +++ b/src/ipa/rkisp1/rkisp1.cpp @@ -480,7 +480,6 @@ const struct IPAModuleInfo ipaModuleInfo = { IPA_MODULE_API_VERSION, 1, "rkisp1", - "rkisp1", }; IPAInterface *ipaCreate() diff --git a/src/ipa/rpi/pisp/pisp.cpp b/src/ipa/rpi/pisp/pisp.cpp index 829b912585223a0296a9709aca433d5240caea1b..9424cb4d129dda541a3cc5f9bacac56dc44f15da 100644 --- a/src/ipa/rpi/pisp/pisp.cpp +++ b/src/ipa/rpi/pisp/pisp.cpp @@ -1089,7 +1089,6 @@ const IPAModuleInfo ipaModuleInfo = { IPA_MODULE_API_VERSION, 1, "rpi/pisp", - "rpi/pisp", }; IPAInterface *ipaCreate() diff --git a/src/ipa/rpi/vc4/vc4.cpp b/src/ipa/rpi/vc4/vc4.cpp index b2fec934480487c0c0566d510afd7a72129e441c..dc3455642ec71865d73662e6cd2d42bba61cadb8 100644 --- a/src/ipa/rpi/vc4/vc4.cpp +++ b/src/ipa/rpi/vc4/vc4.cpp @@ -606,7 +606,6 @@ const struct IPAModuleInfo ipaModuleInfo = { IPA_MODULE_API_VERSION, 1, "rpi/vc4", - "rpi/vc4", }; IPAInterface *ipaCreate() diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp index b147aca2e3436cd79586063c4ee23f6698f266bf..9122f1c019ce1bb1c6a4d96e3fda664023391464 100644 --- a/src/ipa/simple/soft_simple.cpp +++ b/src/ipa/simple/soft_simple.cpp @@ -350,7 +350,6 @@ const struct IPAModuleInfo ipaModuleInfo = { IPA_MODULE_API_VERSION, 0, "simple", - "simple", }; IPAInterface *ipaCreate() diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp index a1351a0f45ce4ce6afed3151001eb74b10090c16..822e00aff2033e42254823b07ec396a50f71f182 100644 --- a/src/ipa/vimc/vimc.cpp +++ b/src/ipa/vimc/vimc.cpp @@ -202,7 +202,6 @@ const struct IPAModuleInfo ipaModuleInfo = { IPA_MODULE_API_VERSION, 0, "vimc", - "vimc", }; IPAInterface *ipaCreate() diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp index 0bd6f14626fe2038072f48b70ca4341b0eb8cef5..53cea6b187e86f20628d3b51c47097836801b094 100644 --- a/src/libcamera/ipa_module.cpp +++ b/src/libcamera/ipa_module.cpp @@ -215,18 +215,15 @@ Span elfLoadSymbol(Span elf, const char *symbol) * \var IPAModuleInfo::pipelineVersion * \brief The pipeline handler version that the IPA module is for * - * \var IPAModuleInfo::pipelineName - * \brief The name of the pipeline handler that the IPA module is for - * - * This name is used to match a pipeline handler with the module. - * * \var IPAModuleInfo::name * \brief The name of the IPA module * - * The name may be used to build file system paths to IPA-specific resources. - * It shall only contain printable characters, and may not contain '*', '?' or - * '\'. For IPA modules included in libcamera, it shall match the directory of - * the IPA module in the source tree. + * This name is used to match a the IPA module. + * + * The name may also be used to build file system paths to IPA-specific + * resources. It shall only contain printable characters, and may not contain + * '*', '?' or '\'. For IPA modules included in libcamera, it shall match the + * directory of the IPA module in the source tree. * * \todo Allow user to choose to isolate open source IPAs */ diff --git a/test/ipa/ipa_module_test.cpp b/test/ipa/ipa_module_test.cpp index 1c97da3242a7d558c52dce6ed3bc9b5f76742944..af71c3285328263da71643da97e7b8c440d9a7ad 100644 --- a/test/ipa/ipa_module_test.cpp +++ b/test/ipa/ipa_module_test.cpp @@ -37,12 +37,10 @@ protected: cerr << "IPA module information mismatch: expected:" << endl << "moduleAPIVersion = " << testInfo.moduleAPIVersion << endl << "pipelineVersion = " << testInfo.pipelineVersion << endl - << "pipelineName = " << testInfo.pipelineName << endl << "name = " << testInfo.name << "got: " << endl << "moduleAPIVersion = " << info.moduleAPIVersion << endl << "pipelineVersion = " << info.pipelineVersion << endl - << "pipelineName = " << info.pipelineName << endl << "name = " << info.name << endl; } @@ -58,7 +56,6 @@ protected: IPA_MODULE_API_VERSION, 0, "vimc", - "vimc", }; count += runTest("src/ipa/vimc/ipa_vimc.so", testInfo);