From patchwork Tue Sep 30 12:26:54 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 24532 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 62A37C328C for ; Tue, 30 Sep 2025 13:41:55 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 0D0876B5F0; Tue, 30 Sep 2025 15:41:55 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="kTLFc7Z6"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B695262C35 for ; Tue, 30 Sep 2025 15:41:53 +0200 (CEST) Received: from ideasonboard.com (unknown [94.31.94.171]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 7D07816A; Tue, 30 Sep 2025 15:40:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1759239625; bh=x+vjD6onUSlvK78JMqMvix69fARA+qz6/JunZ/8/qCE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kTLFc7Z6FA+DKytS9NlKorj5rKSin6PiDV/7r+Na/C8GQREKfzqQTW2X7Vk36+8jX Hfa5Uq54MOGiywbsFac56AC8tlUOWoOoO8WghKwU/yWFyAvgiw5T+w6CJwESXlJLCi 4LzK8E9oDFrG+m7KIfHe1AbBYjXhI9Dvr20mjTGk= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH v1 33/33] DNI pipeline: rkisp1: Workaround for customer kernels without requests Date: Tue, 30 Sep 2025 14:26:54 +0200 Message-ID: <20250930122726.1837524-34-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250930122726.1837524-1-stefan.klug@ideasonboard.com> References: <20250930122726.1837524-1-stefan.klug@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" There are a few kernels out there that have dynamic vertex map support, but no requests support. Allow full dewarp usage on these. Signed-off-by: Stefan Klug --- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index 98521c804d84..e50cf8c0f978 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -183,6 +183,13 @@ static constexpr unsigned int kRkISP1MaxQueuedRequests = 4; */ static constexpr unsigned int kRkISP1MinBufferCount = 4; +/* + * This flag allows to use dynamic dewarp maps to support pan, zoom, rotate when + * the kernel driver doesn't support requests. Only needed for legacy customer + * kernels. + */ +static constexpr bool kAllowDynamicDewarpMapsWithoutRequests = true; + } /* namespace */ class PipelineHandlerRkISP1 : public PipelineHandler @@ -1514,7 +1521,7 @@ int PipelineHandlerRkISP1::updateControls(RkISP1CameraData *data) maxCrop); } - if (dewarper_->supportsRequests()) { + if (dewarper_->supportsRequests() || kAllowDynamicDewarpMapsWithoutRequests) { controls[&controls::draft::Dw100Scale] = ControlInfo(0.2f, 8.0f, 1.0f); controls[&controls::draft::Dw100Rotation] = ControlInfo(-180.0f, 180.0f, 0.0f); controls[&controls::draft::Dw100Offset] = ControlInfo(Point(-10000, -10000), Point(10000, 10000), Point(0, 0));