From patchwork Mon Sep 29 20:19:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Milan Zamazal X-Patchwork-Id: 24493 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 28CC6C324C for ; Mon, 29 Sep 2025 20:19:57 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B2EA76B63D; Mon, 29 Sep 2025 22:19:56 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="a/+d4K4N"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9E4A36B629 for ; Mon, 29 Sep 2025 22:19:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759177191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XWvUR07kciLuBnqkJFghSeoKkucr5rx9vJXZTwvkPTk=; b=a/+d4K4NhwanwbOVnQtuknAWxXXd5JUqX7OR2beyeYh5ZSTSiee35FAsQLcWANSLgq9i1E v3HFX+A6FKyCaIKRjrKI8+LORtdJ4svUzQmwqL8dvKXA7fZs5cmA7wHn21rUG1+ChG6QxU oxSKAcu2PmUK/IMW5UCC11fQJMezRDI= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-202-op0zCXSnO9KlGGoZR81dGg-1; Mon, 29 Sep 2025 16:19:48 -0400 X-MC-Unique: op0zCXSnO9KlGGoZR81dGg-1 X-Mimecast-MFC-AGG-ID: op0zCXSnO9KlGGoZR81dGg_1759177187 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 020AC1800378; Mon, 29 Sep 2025 20:19:47 +0000 (UTC) Received: from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.35]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E46F419560B4; Mon, 29 Sep 2025 20:19:44 +0000 (UTC) From: Milan Zamazal To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal , pobrn@protonmail.com, mail@maciej.szmigiero.name, hansg@kernel.org Subject: [PATCH v5 5/7] ipa: simple: awb: Use correct type in std::accumulate Date: Mon, 29 Sep 2025 22:19:22 +0200 Message-ID: <20250929201924.45019-6-mzamazal@redhat.com> In-Reply-To: <20250929201924.45019-1-mzamazal@redhat.com> References: <20250929201924.45019-1-mzamazal@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: dQtgiFBmib2tQZ-ecBx8IIFoqoD-azQGWVmAPtkJKNk_1759177187 X-Mimecast-Originator: redhat.com content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The result type of the std::accumulate() call is uint64_t; let's use the same type for the initial value (rather than the default int) to prevent summing up the values in a different integer type. Signed-off-by: Milan Zamazal Reviewed-by: Hans de Goede Reviewed-by: Barnabás Pőcze --- src/ipa/simple/algorithms/awb.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp index b1eb7d310..fb21396ef 100644 --- a/src/ipa/simple/algorithms/awb.cpp +++ b/src/ipa/simple/algorithms/awb.cpp @@ -68,7 +68,7 @@ void Awb::process(IPAContext &context, * rather than from the sensor range. */ const uint64_t nPixels = std::accumulate( - histogram.begin(), histogram.end(), 0); + histogram.begin(), histogram.end(), uint64_t(0)); const uint64_t offset = blackLevel * nPixels; const uint64_t minValid = 1; const uint64_t sumR = stats->sumR_ > offset / 4 ? stats->sumR_ - offset / 4 : minValid;