From patchwork Wed Dec 18 14:49:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 2441 X-Patchwork-Delegate: jacopo@jmondi.org Return-Path: Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1D3C5605D8 for ; Wed, 18 Dec 2019 15:47:56 +0100 (CET) X-Originating-IP: 93.34.114.233 Received: from uno.lan (93-34-114-233.ip49.fastwebnet.it [93.34.114.233]) (Authenticated sender: jacopo@jmondi.org) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 975E860008; Wed, 18 Dec 2019 14:47:54 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Date: Wed, 18 Dec 2019 15:49:59 +0100 Message-Id: <20191218145001.22283-6-jacopo@jmondi.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191218145001.22283-1-jacopo@jmondi.org> References: <20191218145001.22283-1-jacopo@jmondi.org> MIME-Version: 1.0 Subject: [libcamera-devel] [RFC 5/7] libcamera: sensor: ov5670: Register pixel array properties X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Dec 2019 14:47:56 -0000 Implement sensor specific pixel array properties initialization for the OV5670 sensor driver by overriding CameraSensor::initProperties() method. Signed-off-by: Jacopo Mondi --- src/libcamera/sensor/ov5670.cpp | 19 +++++++++++++++++++ src/libcamera/sensor/ov5670.h | 3 +++ 2 files changed, 22 insertions(+) diff --git a/src/libcamera/sensor/ov5670.cpp b/src/libcamera/sensor/ov5670.cpp index ca9f3c1d544f..c2d996785717 100644 --- a/src/libcamera/sensor/ov5670.cpp +++ b/src/libcamera/sensor/ov5670.cpp @@ -6,6 +6,10 @@ */ #include "ov5670.h" + +#include +#include + #include "camera_sensor.h" namespace libcamera { @@ -15,4 +19,19 @@ OV5670CameraSensor::OV5670CameraSensor(const MediaEntity *entity) { } +int OV5670CameraSensor::initProperties(const ControlInfoMap &controlMap) +{ + /* Pixel Array Properties. */ + properties_.set(properties::PixelArraySize, { 2.9f, 1.18f }); + properties_.set(properties::PixelArrayBounds, { 2592, 1944 }); + properties_.set(properties::PixelArrays, { 2592, 1944 }); + properties_.set(properties::ActiveAreaSize, { 16, 6, 2560, 1920 }); + int32_t bayerFilter = properties::BayerFilterGRBG; + properties_.set(properties::BayerFilterArrangement, bayerFilter); + properties_.set(properties::ISOSensitivityRange, { 50, 800 }); + + return CameraSensor::initProperties(controlMap); +} + }; /* namespace libcamera */ + diff --git a/src/libcamera/sensor/ov5670.h b/src/libcamera/sensor/ov5670.h index f84239c8411d..564a4546d69b 100644 --- a/src/libcamera/sensor/ov5670.h +++ b/src/libcamera/sensor/ov5670.h @@ -11,8 +11,11 @@ namespace libcamera { +class ControlInfoMap; class OV5670CameraSensor final : public CameraSensor { + int initProperties(const ControlInfoMap &controlMap); + private: OV5670CameraSensor(const MediaEntity *entity); friend CameraSensorFactory;