From patchwork Tue Dec 17 01:51:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Niklas_S=C3=B6derlund?= X-Patchwork-Id: 2434 Return-Path: Received: from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net [195.74.38.228]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 98B4C6047E for ; Tue, 17 Dec 2019 02:51:18 +0100 (CET) X-Halon-ID: b72fedea-206f-11ea-a00b-005056917a89 Authorized-sender: niklas@soderlund.pp.se Received: from bismarck.berto.se (p54ac5865.dip0.t-ipconnect.de [84.172.88.101]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA id b72fedea-206f-11ea-a00b-005056917a89; Tue, 17 Dec 2019 02:51:17 +0100 (CET) From: =?utf-8?q?Niklas_S=C3=B6derlund?= To: libcamera-devel@lists.libcamera.org Date: Tue, 17 Dec 2019 02:51:06 +0100 Message-Id: <20191217015106.1175515-4-niklas.soderlund@ragnatech.se> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191217015106.1175515-1-niklas.soderlund@ragnatech.se> References: <20191217015106.1175515-1-niklas.soderlund@ragnatech.se> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 3/3] test: file_descriptor: Add test X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Dec 2019 01:51:19 -0000 Add a test which exercises the whole FileDescriptor interface. Signed-off-by: Niklas Söderlund Reviewed-by: Laurent Pinchart --- test/file_descriptor.cpp | 165 +++++++++++++++++++++++++++++++++++++++ test/meson.build | 1 + 2 files changed, 166 insertions(+) create mode 100644 test/file_descriptor.cpp diff --git a/test/file_descriptor.cpp b/test/file_descriptor.cpp new file mode 100644 index 0000000000000000..177d8bcf16591185 --- /dev/null +++ b/test/file_descriptor.cpp @@ -0,0 +1,165 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Copyright (C) 2019, Google Inc. + * + * file_descriptor.cpp - FileDescriptor test + */ + +#include +#include +#include +#include + +#include + +#include "test.h" + +using namespace libcamera; +using namespace std; + +class FileDescriptorTest : public Test +{ +protected: + int init() + { + desc1_ = nullptr; + desc2_ = nullptr; + + fd_ = open("/tmp", O_TMPFILE | O_RDWR, S_IRUSR | S_IWUSR); + if (fd_ < 0) + return TestFail; + + /* Cache inode number of temp file. */ + struct stat s; + if (fstat(fd_, &s)) + return TestFail; + + inodeNr_ = s.st_ino; + + return 0; + } + + int run() + { + /* Test creating FileDescriptor from numerical file descriptor. */ + desc1_ = new FileDescriptor(fd_); + if (desc1_->fd() == fd_) + return TestFail; + + if (!isValidFd(fd_) || !isValidFd(desc1_->fd())) + return TestFail; + + int fd = desc1_->fd(); + + delete desc1_; + desc1_ = nullptr; + + if (!isValidFd(fd_) || isValidFd(fd)) + return TestFail; + + /* Test creating FileDescriptor from other FileDescriptor. */ + desc1_ = new FileDescriptor(fd_); + desc2_ = new FileDescriptor(*desc1_); + + if (desc1_->fd() == fd_ || desc2_->fd() == fd_ || desc1_->fd() == desc2_->fd()) + return TestFail; + + if (!isValidFd(desc1_->fd()) || !isValidFd(desc2_->fd())) + return TestFail; + + delete desc1_; + desc1_ = nullptr; + + if (!isValidFd(desc2_->fd())) + return TestFail; + + delete desc2_; + desc2_ = nullptr; + + /* Test creating FileDescriptor by taking over other FileDescriptor. */ + desc1_ = new FileDescriptor(fd_); + fd = desc1_->fd(); + desc2_ = new FileDescriptor(std::move(*desc1_)); + + if (desc1_->fd() != -1 || desc2_->fd() != fd) + return TestFail; + + if (!isValidFd(desc2_->fd())) + return TestFail; + + delete desc1_; + desc1_ = nullptr; + delete desc2_; + desc2_ = nullptr; + + /* Test creating FileDescriptor by copy assignment. */ + desc1_ = new FileDescriptor(); + desc2_ = new FileDescriptor(fd_); + + if (desc1_->fd() != -1) + return TestFail; + + fd = desc2_->fd(); + *desc1_ = *desc2_; + + if (desc1_->fd() == fd || desc2_->fd() != fd) + return TestFail; + + if (!isValidFd(desc1_->fd()) || !isValidFd(desc2_->fd())) + return TestFail; + + delete desc1_; + desc1_ = nullptr; + delete desc2_; + desc2_ = nullptr; + + if (!isValidFd(fd_)) + return TestFail; + + /* Test creating FileDescriptor by move assignment. */ + desc1_ = new FileDescriptor(); + desc2_ = new FileDescriptor(fd_); + + fd = desc2_->fd(); + *desc1_ = std::move(*desc2_); + + if (desc1_->fd() != fd || desc2_->fd() != -1) + return TestFail; + + if (!isValidFd(desc1_->fd())) + return TestFail; + + delete desc1_; + desc1_ = nullptr; + delete desc2_; + desc2_ = nullptr; + + return TestPass; + } + + void cleanup() + { + delete desc2_; + delete desc1_; + + if (fd_ > 0) + close(fd_); + } + +private: + bool isValidFd(int fd) + { + struct stat s; + if (fstat(fd, &s)) + return false; + + /* Check that inode number matches cached temp file. */ + return s.st_ino == inodeNr_; + } + + int fd_; + ino_t inodeNr_; + FileDescriptor *desc1_, *desc2_; +}; + +TEST_REGISTER(FileDescriptorTest) diff --git a/test/meson.build b/test/meson.build index 1bb2161dc05a7b1d..9dc392df30efd956 100644 --- a/test/meson.build +++ b/test/meson.build @@ -25,6 +25,7 @@ internal_tests = [ ['event', 'event.cpp'], ['event-dispatcher', 'event-dispatcher.cpp'], ['event-thread', 'event-thread.cpp'], + ['file_descriptor', 'file_descriptor.cpp'], ['message', 'message.cpp'], ['object', 'object.cpp'], ['object-invoke', 'object-invoke.cpp'],