From patchwork Mon Aug 25 11:44:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 24230 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 3F2F5BEFBE for ; Mon, 25 Aug 2025 11:44:24 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id DD308692ED; Mon, 25 Aug 2025 13:44:23 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="cDHZycwl"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 39DC1692CA for ; Mon, 25 Aug 2025 13:44:22 +0200 (CEST) Received: from neptunite.infra.iob (unknown [IPv6:2404:7a81:160:2100:39d7:37aa:64a2:5533]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 149062285; Mon, 25 Aug 2025 13:43:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1756122200; bh=2jNgxbH/TJrbZsNEpU2wRU2f1EEn/Vw9JLm6+MO46fE=; h=From:To:Cc:Subject:Date:From; b=cDHZycwlrqVeBpiG7XS3W618RRTrX/vzWbDHXE9XgunkTXOEZrP2rENErNjTfBQg1 ygz8vgfvTfm2KYFvj/M6fX8jMrLZxgtwJvCj0sXYLPAhrPBBVY5af9EgxfoHR4M51M mqBECjx7TCkXpP6XCnUGtEjUKBquNBW6EFV+vND8= From: Paul Elder To: libcamera-devel@lists.libcamera.org Cc: Paul Elder Subject: [PATCH] test: utils: Add endlines Date: Mon, 25 Aug 2025 20:44:09 +0900 Message-ID: <20250825114409.569050-1-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Most of the error messages from the utils test had no endlines. Add them so that the output is nicer. Signed-off-by: Paul Elder Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- test/utils.cpp | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/test/utils.cpp b/test/utils.cpp index 195fddc97d97..ae5b01746722 100644 --- a/test/utils.cpp +++ b/test/utils.cpp @@ -85,7 +85,7 @@ protected: if (index != i || value != i + 1) { cerr << "utils::enumerate() test failed: i=" << i << ", index=" << index << ", value=" << value - << std::endl; + << endl; return TestFail; } @@ -106,7 +106,7 @@ protected: if (index != i || value != i) { cerr << "utils::enumerate() test failed: i=" << i << ", index=" << index << ", value=" << value - << std::endl; + << endl; return TestFail; } @@ -120,7 +120,7 @@ protected: if (index != i || value != i * 2) { cerr << "utils::enumerate() test failed: i=" << i << ", index=" << index << ", value=" << value - << std::endl; + << endl; return TestFail; } @@ -138,32 +138,32 @@ protected: exposure = 25ms + 25ms; if (exposure.get() != 50000.0) { - cerr << "utils::Duration failed to return microsecond count"; + cerr << "utils::Duration failed to return microsecond count" << endl; return TestFail; } exposure = 1.0s / 4; if (exposure != 250ms) { - cerr << "utils::Duration failed scalar divide test"; + cerr << "utils::Duration failed scalar divide test" << endl; return TestFail; } exposure = 5000.5us; if (!exposure) { - cerr << "utils::Duration failed boolean test"; + cerr << "utils::Duration failed boolean test" << endl; return TestFail; } os << exposure; if (os.str() != "5000.50us") { - cerr << "utils::Duration operator << failed"; + cerr << "utils::Duration operator << failed" << endl; return TestFail; } exposure = 100ms; ratio = exposure / 25ms; if (ratio != 4.0) { - cerr << "utils::Duration failed ratio test"; + cerr << "utils::Duration failed ratio test" << endl; return TestFail; } @@ -219,7 +219,7 @@ protected: std::string s = os.str(); if (s != ref) { cerr << "utils::hex() test failed, expected '" << ref - << "', got '" << s << "'"; + << "', got '" << s << "'" << endl; return TestFail; }