From patchwork Sun Aug 24 00:48:24 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 24195 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 3C7C7C32BB for ; Sun, 24 Aug 2025 00:49:04 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2746E69303; Sun, 24 Aug 2025 02:49:03 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="qaZziY0M"; dkim-atps=neutral Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id AE72A692FF for ; Sun, 24 Aug 2025 02:48:47 +0200 (CEST) Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-45a20c51c40so26179695e9.3 for ; Sat, 23 Aug 2025 17:48:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755996527; x=1756601327; darn=lists.libcamera.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=TfqtxqIsqCyESJnF4snpoyUimWkfpfXPHPpywJRlG8M=; b=qaZziY0MGAFqB7rKcFX+R7n15UofoSHdoZ7L4JACONYe3FpcK0gZviw7Mm5Bte61ew YYNG3NodYgWurLmslKs4/UUAnnE+tGI7EjDaQduNctaiepbmoy3P5cPuOJrH7UtSRVlu PdYBJ3Ek+S96U3Y5fYREVdZBIrW69xsYz03r9MRnIo0PgD9VtMY5QS05+r7abIFvEKMf p3lD1mUZZfOfmhXYBJnkwNp5D/rFfOXFexgiqI0rPLV98OejJN1dmmBvzoi8s0j3iDN9 A6ejvK5tjY4fNqwUJtWQZJFMHWk3Vt9UUsA+tU1PnXam+/N7VlVNqtaX+3xWhP92NMah +6dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755996527; x=1756601327; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TfqtxqIsqCyESJnF4snpoyUimWkfpfXPHPpywJRlG8M=; b=X1lmNGbM3b4nBRxM3QtuyEq71kTmKiaG2xTS1QDmEcBKBuUzHV1D4ITlUgH8j0RzVu /fMFBLrTPZ0x1QDRYsOLo/0La4KTapkNjYspXU+2AscCm2Wh/+MTEkMNPwGmQPm9fRtB 0b5Gl9p3mXX7NzIMn7T8QS6LhH8tewsguainZrNXv/jhQprghbyWO5d3yKaeDoyd6Ah+ CSqt2dV9oTuJvVZEYZiMHN+RmbzdqaIgxqpY99xu1GmCTthXfcSydFESKhHqsSIq/yde f+wVy55HWRtqaWlSlhMXjVAsIsXaTcRMXoscA2I6nWR+mc5tWXbo5kUH39+4pCgnpB0E OfWQ== X-Gm-Message-State: AOJu0Yx1/9kIJZQHBsk3b8hhth6fyvGFNU453Q+Yw6sxzLB88R98LA6a mJ3toBR5cykPhgbs/gH4+q/iAgTEujX3uw3nf9r8vsAdr25ocv1KbzFb5xiBiduZM1O4GFxE4l5 iuD5V0qU= X-Gm-Gg: ASbGnctV4xD9XiXHEdJaGlAy7SWhfz6Ms45HGxqGmOIMxi570J+70tjsGZEF9BQYfDo hGTtVu9l8udBuMEOLYrGR+r9fQ5FvZLSutWRZkMrPZ3qQSgdzC1jQ9BhrcYc/5D8NUQhf6EzWR0 7tP8b8WPk8Uw1nsMT9nM/XSazJnEpdlVIBAKzx5AYW4oLLRFvpl2oQ2LVy4JEzaOn+ybwRHv99L qOoairF9q9UdS0Bmq4Flb0dRNSXSszi5b9TfGJJmrpAkS8CcO8llnM7j9UzDZbXKFW4H9CMi3fp w1z78N699ZwwOUGwtTFebnMDaZGTmPUvSbr4QGAUdAyVgRqEEqZTu3iaSsGUWkEQQdkt3toMXvp wh7h0nomtHub7kBBhAdxh28iRK4PNsiG98grVdX7uL3oSyqVcT0SAUg0gE14sH2CPaGRQhki+pI Gyv5ouuoK9yYsvjJO2DAzl X-Google-Smtp-Source: AGHT+IHVYpyMhUzef8/MU7qtnMuTb0LPjXYvgtnuFBz2R27BdOn6KOb+hvZPwlh9bYKpS9glrGXD3Q== X-Received: by 2002:a05:600c:3212:b0:459:df48:3b19 with SMTP id 5b1f17b1804b1-45b517c5df0mr47197135e9.18.1755996527241; Sat, 23 Aug 2025 17:48:47 -0700 (PDT) Received: from [192.168.0.13] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b4e1d530esm69347225e9.0.2025.08.23.17.48.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Aug 2025 17:48:46 -0700 (PDT) From: Bryan O'Donoghue Date: Sun, 24 Aug 2025 01:48:24 +0100 Subject: [PATCH v2 12/37] libcamera: software_isp: Start the ISP thread in configure MIME-Version: 1.0 Message-Id: <20250824-b4-v0-5-2-gpuisp-v2-a-v2-12-96f4576c814e@linaro.org> References: <20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org> In-Reply-To: <20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org> To: libcamera-devel@lists.libcamera.org Cc: Bryan O'Donoghue X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1811; i=bryan.odonoghue@linaro.org; h=from:subject:message-id; bh=TJz2c1i4gj5Q/xRIyCEfIizExQxLMBanHSgh1qaIxXA=; b=owEBbQKS/ZANAwAKASJxO7Ohjcg6AcsmYgBoqmFeekoGOrHPNkZ23S1I4csSplTg6EZM/0FRj K8OWRwCG6GJAjMEAAEKAB0WIQTmk/sqq6Nt4Rerb7QicTuzoY3IOgUCaKphXgAKCRAicTuzoY3I Olr9D/oCpMP0uAlk4rPKyyfK2eU6NEJ/aPMkKwtNSAgZhKdcdr35jlLFcCmLJ4XyR7mxiInPSml g2qbY/Gfo8OG/hR1JJP/0eYuer+DpaT+lf+a3eIuLdHcHbjhiwJDqjD1u5EIWQ8CR0As8klsews lsxc2BWdk1zWCG/Fif9ZiMTxtQCr4tEHGbwXsI/u+fLxEwtS9aeekTTe+fkZ5v0bBqNkJay1pvj JDNHpmw2z54/9Pxd5F8ElH4LWqDAh/kAYW1v27AGnnd83bb9b5Cst/1zbcPmwGzfjwR70HOS6sT 8t5VeVsdkD6HiwxhFMe5sbkBYJLnuidEBtCjgBn95hF3m/M5F+f2t9eE/fJjfw7usyym1mItOfH ek1uSS1WJBCECT0S6yIp+ZfY7mHSHfWyti0J60cgXVlmCPdC1WBxAUwGrxeEQsGdxD7o+GdtJ0d tmt1EijDeFcQKuCxauuYerDKZhFlILogBXwYOMK1395j6/fh9RkEg9wY6PNH6WuMcDXvQ7PcJ0F pJ0k4uJ8ujaRRm1lQ7Yb01hpuyGm6rHSBRgKJvAksrLmfQ0yXzi5IwliLfZTh3NePTbx0lDZOeQ ntXzngzcS/0xEmSg4SW3Y+jnkKZkCQKJDYj8SmQSeD2b840qn8t++nPuqy4MsbIMQz09bKV06rB zDs/c+F7csbI4Og== X-Developer-Key: i=bryan.odonoghue@linaro.org; a=openpgp; fpr=E693FB2AABA36DE117AB6FB422713BB3A18DC83A X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" EGL is not thread-safe and in fact associates invisible handles with the threadid of the calling context. As a result we need to make Deabyer::configure() and Debayer::process() in SoftISP execute on the same thread. When we call Debayer::configure() in the egl class this will setup and egl context for us which is associated with the calling thread context. Hence when Debayer::process(); runs it must run in the same thread as Debayer::configure() or the hidden Gegl context handles will not point to the same place. Move start thread into configure() as a first step towards this. Signed-off-by: Bryan O'Donoghue --- src/libcamera/software_isp/software_isp.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp index 28e2a360e7e6d5071e7b97c2bffc60478d245a60..7bee8f0681dd5cedcd81950ed49f611b514e763d 100644 --- a/src/libcamera/software_isp/software_isp.cpp +++ b/src/libcamera/software_isp/software_isp.cpp @@ -159,8 +159,6 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor, metadataReady.emit(frame, metadata); }); ipa_->setSensorControls.connect(this, &SoftwareIsp::setSensorCtrls); - - debayer_->moveToThread(&ispWorkerThread_); } SoftwareIsp::~SoftwareIsp() @@ -262,6 +260,9 @@ int SoftwareIsp::configure(const StreamConfiguration &inputCfg, if (ret < 0) return ret; + debayer_->moveToThread(&ispWorkerThread_); + ispWorkerThread_.start(); + return debayer_->configure(inputCfg, outputCfgs, ccmEnabled_); } @@ -343,7 +344,6 @@ int SoftwareIsp::start() if (ret) return ret; - ispWorkerThread_.start(); return 0; }