From patchwork Fri Aug 15 13:52:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 24142 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 986E4BDCC1 for ; Fri, 15 Aug 2025 13:52:59 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A75DA6925A; Fri, 15 Aug 2025 15:52:58 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="PUJutLc+"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id F37BE61443 for ; Fri, 15 Aug 2025 15:52:56 +0200 (CEST) Received: from pb-laptop.local (185.221.141.188.nat.pool.zt.hu [185.221.141.188]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B793D8FA for ; Fri, 15 Aug 2025 15:52:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1755265921; bh=ot9tDkn/8pPOFYE55eEBjkG1AtKr4xO2BvANrZ+VZdE=; h=From:To:Subject:Date:From; b=PUJutLc+2re+AIc8ZTMfT29L8moUOpNL7o1Ld1uS3hu0dZRoISzVqYNGuR+qinWTb e/0sYRA2B0hwBY2jmzzpQiQZXxRP/au/x5+Z1VSm0cn22vG2EZfWuNZHPKVHuSU4m8 Bf2LbakMFphob0k4Cj0vmV+FTeAoTmtFQK4pXWYo= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [RFC PATCH v1 1/2] libcamera: device_enumerator: Take list of entity names in ctor Date: Fri, 15 Aug 2025 15:52:52 +0200 Message-ID: <20250815135253.2231076-1-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.50.1 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Make it possible to pass a list of entity names to the `DeviceMatch` constructor, thereby simplifying the construction if there is a known set of entity names by avoiding the repeated `add()` calls. Signed-off-by: Barnabás Pőcze --- include/libcamera/internal/device_enumerator.h | 5 ++++- src/libcamera/device_enumerator.cpp | 7 +++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/include/libcamera/internal/device_enumerator.h b/include/libcamera/internal/device_enumerator.h index db3532a98..cb055e166 100644 --- a/include/libcamera/internal/device_enumerator.h +++ b/include/libcamera/internal/device_enumerator.h @@ -7,8 +7,10 @@ #pragma once +#include #include #include +#include #include #include @@ -20,7 +22,8 @@ class MediaDevice; class DeviceMatch { public: - DeviceMatch(const std::string &driver); + DeviceMatch(const std::string &driver, + std::initializer_list entities = {}); void add(const std::string &entity); diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp index ae17862f6..ec98418fa 100644 --- a/src/libcamera/device_enumerator.cpp +++ b/src/libcamera/device_enumerator.cpp @@ -66,9 +66,12 @@ LOG_DEFINE_CATEGORY(DeviceEnumerator) /** * \brief Construct a media device search pattern * \param[in] driver The Linux device driver name that created the media device + * \param[in] entities The list of media graph entity names to search */ -DeviceMatch::DeviceMatch(const std::string &driver) - : driver_(driver) +DeviceMatch::DeviceMatch(const std::string &driver, + std::initializer_list entities) + : driver_(driver), + entities_(entities.begin(), entities.end()) { }