From patchwork Thu Aug 7 13:20:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 24068 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 7899BBDCC1 for ; Thu, 7 Aug 2025 13:20:46 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5E7E26921A; Thu, 7 Aug 2025 15:20:45 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=igalia.com header.i=@igalia.com header.b="ZYjEyEZO"; dkim-atps=neutral Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9437569052 for ; Thu, 7 Aug 2025 15:20:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=mf58jB+Q+A0jok2fTL7mZFHrkjnTIPjCacoC4Ykh2XU=; b=ZYjEyEZOb8fUC3wx/mBEqRm58/ 7DB4iETvjr1LfIzwGBggjTfnNOR0gw2On50edKBIJ7XNjngHSTAsiUukbTuK125uIfDzcQoYOJDtz rQW366akqVL/wByO1zpUZOsFnktmvWW1lwZgeBkJ3hzoQdJtTwOD0VmlcMc2q8eDcsfFzSkhEj/rp Wkf00H06Nzm/UiRsPfZB0mxNigMNzbAoBid+EjZ9/h5Iv3VnDVXgfZVdagZS2Xfgdk6WhlNnIMJFp BZown1xnQ96qF04glr2kLSlQJuhwY9S5Xcthuk8mLoe3pJTMmFXhOmdQi+MlpikOSkEOy7csl20aL H5xteO5A==; Received: from [49.36.71.143] (helo=uajain) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1uk0Xy-00B0xz-JN; Thu, 07 Aug 2025 15:20:42 +0200 From: Umang Jain To: libcamera-devel@lists.libcamera.org Cc: Umang Jain Subject: [PATCH] test: camera: Use Request::ReuseBuffers flag Date: Thu, 7 Aug 2025 18:50:52 +0530 Message-ID: <20250807132052.84591-1-uajain@igalia.com> X-Mailer: git-send-email 2.50.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Pass Request::ReuseBuffers flag to request->reuse() where the same buffers are added to the request, as the flag exists precisely for such use cases. Signed-off-by: Umang Jain --- test/camera/buffer_import.cpp | 8 +------- test/camera/camera_reconfigure.cpp | 8 +------- test/camera/capture.cpp | 8 +------- 3 files changed, 3 insertions(+), 21 deletions(-) diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp index 815d1cae..d6feee79 100644 --- a/test/camera/buffer_import.cpp +++ b/test/camera/buffer_import.cpp @@ -52,16 +52,10 @@ protected: if (request->status() != Request::RequestComplete) return; - const Request::BufferMap &buffers = request->buffers(); - completeRequestsCount_++; /* Create a new request. */ - const Stream *stream = buffers.begin()->first; - FrameBuffer *buffer = buffers.begin()->second; - - request->reuse(); - request->addBuffer(stream, buffer); + request->reuse(Request::ReuseBuffers); camera_->queueRequest(request); dispatcher_->interrupt(); diff --git a/test/camera/camera_reconfigure.cpp b/test/camera/camera_reconfigure.cpp index 06c87730..ae9941c1 100644 --- a/test/camera/camera_reconfigure.cpp +++ b/test/camera/camera_reconfigure.cpp @@ -46,14 +46,8 @@ private: if (request->status() != Request::RequestComplete) return; - const Request::BufferMap &buffers = request->buffers(); - - const Stream *stream = buffers.begin()->first; - FrameBuffer *buffer = buffers.begin()->second; - /* Reuse the request and re-queue it with the same buffers. */ - request->reuse(); - request->addBuffer(stream, buffer); + request->reuse(Request::ReuseBuffers); camera_->queueRequest(request); } diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp index 8766fb19..a4168661 100644 --- a/test/camera/capture.cpp +++ b/test/camera/capture.cpp @@ -48,16 +48,10 @@ protected: if (request->status() != Request::RequestComplete) return; - const Request::BufferMap &buffers = request->buffers(); - completeRequestsCount_++; /* Create a new request. */ - const Stream *stream = buffers.begin()->first; - FrameBuffer *buffer = buffers.begin()->second; - - request->reuse(); - request->addBuffer(stream, buffer); + request->reuse(Request::ReuseBuffers); camera_->queueRequest(request); dispatcher_->interrupt();