From patchwork Tue Jul 22 10:25:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 23895 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 6C2D6C3237 for ; Tue, 22 Jul 2025 10:25:39 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 6E9816902A; Tue, 22 Jul 2025 12:25:38 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=igalia.com header.i=@igalia.com header.b="nWEX4+Kk"; dkim-atps=neutral Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1E4C868F93 for ; Tue, 22 Jul 2025 12:25:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FrleBOl9j8Aye7M8Ulxs3jAD8wzLUjEDGZiDImAgqfM=; b=nWEX4+KkzdwH6jKP5OJM5PtWMV jvAF4m4Y6upIisjxorJOC06Pnrj9cAK/XLDow+i9B+0aqKDJNDLWv4XtQ87YyL2ngeCPX6Zgrmn11 Un2uXu26LPOaQthp6kLgMhRfVS+C+Q7dikUzkVVOdSGN5ypI9Y4cOHjuH+auTxqNXQTo1+Ft3V4TI jmPwPEb3UgyeSPy3PgSe4HT58LVhqjWE5yRVPxx/RxES6ARLLOlehlpktmNU79r+TnEm0IcftKqnN 8qN0D6EJcsh27sGLD4hln/HHFYZ3RFMTjov+jR23hi/q5V4FsMNWMnQchXh4Y3L/En+r64gUo/F/1 NjW86b3g==; Received: from [49.36.71.87] (helo=uajain) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1ueABj-0025xD-Mq; Tue, 22 Jul 2025 12:25:36 +0200 From: Umang Jain To: libcamera-devel@lists.libcamera.org Cc: Umang Jain Subject: [PATCH] pipeline: simple: Improve debug log in validate() Date: Tue, 22 Jul 2025 15:55:38 +0530 Message-ID: <20250722102538.52706-1-uajain@igalia.com> X-Mailer: git-send-email 2.50.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Improve the debug log while adjusting the StreamConfiguration's pixel format. The log should clearly indicate the requested pixel format and the adjusted pixel format. Signed-off-by: Umang Jain Reviewed-by: Kieran Bingham --- src/libcamera/pipeline/simple/simple.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp index efb07051..492da967 100644 --- a/src/libcamera/pipeline/simple/simple.cpp +++ b/src/libcamera/pipeline/simple/simple.cpp @@ -1204,7 +1204,9 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate() PixelFormat pixelFormat = *it; if (cfg.pixelFormat != pixelFormat) { - LOG(SimplePipeline, Debug) << "Adjusting pixel format"; + LOG(SimplePipeline, Debug) + << "Adjusting pixel format from " + << cfg.pixelFormat << " to " << pixelFormat; cfg.pixelFormat = pixelFormat; status = Adjusted; }