From patchwork Sun Jul 13 12:16:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 23804 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E0F70BE175 for ; Sun, 13 Jul 2025 12:17:18 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id EED6468F27; Sun, 13 Jul 2025 14:17:17 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ayDrZKd5"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 8C12F68EA8 for ; Sun, 13 Jul 2025 14:17:16 +0200 (CEST) Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 3092699F; Sun, 13 Jul 2025 14:16:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1752409005; bh=muRB9KcPXm6ChyH7FtE1M733NOzKJ4iQ1+9+VMlUnbo=; h=From:To:Cc:Subject:Date:From; b=ayDrZKd5NXJH1qix7kfn2BkDLjIWovoqequ8eup/O5RELAEUz/TWqu9IflHzQ6uta QxWmL2dgkLEcSvaO5bVs4hH/mKFc/gTKjEjB+RDu9gYeETo4uTPXp8cwugnEVcRNpb Bjar0eVBk2PAb8RIHMgVxycswarSrjlSrH7qJgvY= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Cc: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= Subject: [PATCH v3] libcamera: camera_manager: Log info message to report camera creation Date: Sun, 13 Jul 2025 15:16:45 +0300 Message-ID: <20250713121645.11776-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.49.1 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Camera creation is one of the most important events generated by libcamera, but we are completely silent about it. The lack of a log message makes it more difficult to identify problems and provide support. Fix it by adding an Info message that reports the camera id and its pipeline handler when the camera is added. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham Reviewed-by: Umang Jain --- Changes since v2: - Rebase on latest master branch --- src/libcamera/camera_manager.cpp | 4 ++++ 1 file changed, 4 insertions(+) base-commit: afd9890b7b9a65d95ef3295f52e01e0ec9ce7b3f -- Regards, Laurent Pinchart diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp index e62e7193cfdc..f81794bfd6fe 100644 --- a/src/libcamera/camera_manager.cpp +++ b/src/libcamera/camera_manager.cpp @@ -217,6 +217,10 @@ void CameraManager::Private::addCamera(std::shared_ptr camera) cameras_.push_back(camera); } + LOG(Camera, Info) + << "Adding camera '" << camera->id() << "' for pipeline handler " + << camera->_d()->pipe()->name(); + /* Report the addition to the public signal */ CameraManager *const o = LIBCAMERA_O_PTR(); o->cameraAdded.emit(camera);