From patchwork Tue Jul 1 11:29:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 23704 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 5CBA1C3237 for ; Tue, 1 Jul 2025 11:29:29 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 186BE68E2A; Tue, 1 Jul 2025 13:29:28 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=igalia.com header.i=@igalia.com header.b="dUnMkMmb"; dkim-atps=neutral Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A5C5668E2A for ; Tue, 1 Jul 2025 13:29:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=LV561dU6pvdK+oCH138B7P/slDJecaPDdPgskP2DSLI=; b=dUnMkMmbhEWJsWnroDIBH/H9Ls 5ahwCtyhc1YEFVKSQzAakZgpw48QHQ0ymODQ6KjWV8pCUB/+fFQ32ts8H5oBjEJP4ZQdTPEB2kg4R NPIm+vNcfYaPy0zoRPSLrwYOPnGT2l5ZFHCKuWkK5cfyeqxg7SnYMsR3ywlgPVVtX5vG6lHqUyFfV 4BD1wbq6ZKbqiakXRvbO7dhYtJbd4P4BY5K9fYlzlXBdPs5+J18m0RrXs9WXN+g+cx7NLGKVquQ8m 4fS5g5vCOrpeHMXoB0Srd9boQ2XXG6OeWiWlM4I7e1+cXOjKutnOB9G/GiDDrI1NHQ7YLHTp6Ge1V blr6bx+A==; Received: from [49.36.69.141] (helo=uajain) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1uWZAy-00AwG9-55; Tue, 01 Jul 2025 13:29:24 +0200 From: Umang Jain To: libcamera-devel@lists.libcamera.org Cc: Umang Jain , Kieran Bingham Subject: [PATCH v2 2/2] lc-compliance: Ensure stream's colorspace is set after validate() Date: Tue, 1 Jul 2025 16:59:22 +0530 Message-ID: <20250701112922.62285-3-uajain@igalia.com> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250701112922.62285-1-uajain@igalia.com> References: <20250701112922.62285-1-uajain@igalia.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" StreamConfiguration::colorspace is a std::optional<> and if unset by the user, it should be populated by the pipeline handler after the CameraConfiguration::validate(). Add a EXPECT_TRUE() check to ensure that each stream in the CameraConfiguration has a colorspace set. Signed-off-by: Umang Jain Reviewed-by: Kieran Bingham Tested-by: Robert Mader Reviewed-by: Barnabás Pőcze --- src/apps/lc-compliance/helpers/capture.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/apps/lc-compliance/helpers/capture.cpp b/src/apps/lc-compliance/helpers/capture.cpp index 2a3fa3b6..e767e45e 100644 --- a/src/apps/lc-compliance/helpers/capture.cpp +++ b/src/apps/lc-compliance/helpers/capture.cpp @@ -52,6 +52,9 @@ void Capture::configure(libcamera::Span roles) FAIL() << "Configuration not valid"; } + for (auto &cfg : *config_) + EXPECT_TRUE(cfg.colorSpace) << cfg << " - colorspace not set."; + if (camera_->configure(config_.get())) { config_.reset(); FAIL() << "Failed to configure camera";