From patchwork Tue Jul 1 11:29:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 23703 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id AC7B5C3237 for ; Tue, 1 Jul 2025 11:29:27 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 6B28E68E28; Tue, 1 Jul 2025 13:29:25 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=igalia.com header.i=@igalia.com header.b="QYjtFo00"; dkim-atps=neutral Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id EEAA468E1A for ; Tue, 1 Jul 2025 13:29:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=gbi1bHpDTvUWKxvWCxqhwX2/uT8BRTc0Rzvzm2zArd8=; b=QYjtFo00847nBx6PCvFMODMZ0H FWwjlrciSEJ+wLN/zKABtj1Oaj+zeNmQ6s0s9Xtil5bSNRpifCQOR5EgOfY5Td4adNMSACd25Lm+J RonqktLGWRPA0gpJM9zKEqbTOmTHuXjcax8bEl6s6NuhB0QOgdaFH7p9KfuvXCyDO9flm1+lullSI E/WNSvF6ZtGDXDyPq7rQk/hYHykaFdWZci8UN6oxrZiZ7EhmvUk8F/LDZpHrHHA/g+Fte4G5JAzet h4ZwWc+K2dmCjCpq5tJe0mmV6yGn6M48bhNCek638vyFWQa06+NgbCfmVALiTf0Qz1rU7jhq5+Ws/ n67NDy5Q==; Received: from [49.36.69.141] (helo=uajain) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1uWZAv-00AwG9-HG; Tue, 01 Jul 2025 13:29:22 +0200 From: Umang Jain To: libcamera-devel@lists.libcamera.org Cc: Umang Jain Subject: [PATCH v2 1/2] pipeline: virtual: Provide and validate colorspace Date: Tue, 1 Jul 2025 16:59:21 +0530 Message-ID: <20250701112922.62285-2-uajain@igalia.com> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250701112922.62285-1-uajain@igalia.com> References: <20250701112922.62285-1-uajain@igalia.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Virtual pipeline handler should provide colorSpace in generateConfiguration() and validate the colorspace in validate(). It is mandatory for a pipeline handler to set the colorspace if it is unset in the stream configuration, during validate(). Signed-off-by: Umang Jain Reviewed-by: Kieran Bingham Tested-by: Robert Mader --- src/libcamera/pipeline/virtual/virtual.cpp | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/libcamera/pipeline/virtual/virtual.cpp b/src/libcamera/pipeline/virtual/virtual.cpp index 049ebcba..841846b4 100644 --- a/src/libcamera/pipeline/virtual/virtual.cpp +++ b/src/libcamera/pipeline/virtual/virtual.cpp @@ -180,6 +180,17 @@ CameraConfiguration::Status VirtualCameraConfiguration::validate() adjusted = true; } + if (!cfg.colorSpace) { + cfg.colorSpace = ColorSpace::Sycc; + status = Adjusted; + adjusted = true; + } + + if (validateColorSpaces() == Adjusted) { + status = Adjusted; + adjusted = true; + } + if (adjusted) LOG(Virtual, Info) << "Stream configuration adjusted to " << cfg.toString(); @@ -244,6 +255,7 @@ PipelineHandlerVirtual::generateConfiguration(Camera *camera, cfg.pixelFormat = pixelFormat; cfg.size = data->config_.maxResolutionSize; cfg.bufferCount = VirtualCameraConfiguration::kBufferCount; + cfg.colorSpace = ColorSpace::Sycc; config->addConfiguration(cfg); }