From patchwork Fri Jun 27 07:42:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 23669 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E28B3C3237 for ; Fri, 27 Jun 2025 07:42:18 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8C7B368DFC; Fri, 27 Jun 2025 09:42:15 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=igalia.com header.i=@igalia.com header.b="Ydvda+/2"; dkim-atps=neutral Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 8CC2068DF6 for ; Fri, 27 Jun 2025 09:42:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=yAGDdktLSnopHQCFyDN/BK/qWVUnJYrVXmxRyRoC2R0=; b=Ydvda+/22Km4PnROd4h/LJm6pV TrRnkElZ8JbPU0kwR/+xxSKljafd6JuIEQ5lGQA0U2+cHPP9MFGHN0qBB3YN6X14mGuKlm7GecZF3 bPZ3pMPg3iCQ/5Tjs7aLS9wDuKFIv0Z16Pm193F1jkMeQsCDxZNFLcgVT/DcDCSG5MjzFlgYLRC85 XEugN/fZb/eU7nBzoLWGkl0+vtL2M70qZmGNyfch4zQdq2m7CkEDx4SHM8A/RkfNJ0JMhn/jduSIt OdtIkqlrBJzLW3cP/Vhu4ug97PehMi1PEPjtl/MmkthQ7Gh3eBKxY17qHiUof8OuYGnFkvikDzQ+F rIV1yXbA==; Received: from [49.36.69.141] (helo=uajain) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1uV3iq-009IWh-Az; Fri, 27 Jun 2025 09:42:08 +0200 From: Umang Jain To: libcamera-devel@lists.libcamera.org Cc: Giacomo Cappellini , Nicolas Dufresne , Umang Jain Subject: [PATCH 2/2] libcamera: gstreamer: Report mounting-rotation of camera sensor Date: Fri, 27 Jun 2025 13:12:08 +0530 Message-ID: <20250627074208.49872-3-uajain@igalia.com> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250627074208.49872-1-uajain@igalia.com> References: <20250627074208.49872-1-uajain@igalia.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Report mounting-rotation of the camera sensor by reading the property::Rotation property from libcamera. This is reported in GstDevice properties for libcamerasrc element. Signed-off-by: Umang Jain --- src/gstreamer/gstlibcameraprovider.cpp | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/gstreamer/gstlibcameraprovider.cpp b/src/gstreamer/gstlibcameraprovider.cpp index 5da96ea3..806a149a 100644 --- a/src/gstreamer/gstlibcameraprovider.cpp +++ b/src/gstreamer/gstlibcameraprovider.cpp @@ -12,6 +12,7 @@ #include #include +#include #include "gstlibcamerasrc.h" #include "gstlibcamera-utils.h" @@ -131,6 +132,8 @@ gst_libcamera_device_new(const std::shared_ptr &camera) static const std::array roles{ StreamRole::VideoRecording }; g_autoptr(GstCaps) caps = gst_caps_new_empty(); const gchar *name = camera->id().c_str(); + std::string rotation_str; + bool success; std::unique_ptr config = camera->generateConfiguration(roles); if (!config || config->size() != roles.size()) { @@ -144,12 +147,23 @@ gst_libcamera_device_new(const std::shared_ptr &camera) gst_caps_append(caps, sub_caps); } + const int32_t rotation = camera->properties().get(properties::Rotation).value_or(0); + Orientation mountingOrientation = orientationFromRotation(rotation, &success); + rotation_str = success ? orientationToString(mountingOrientation) + : std::to_string(rotation); + + g_autoptr(GstStructure) props = + gst_structure_new("camera-properties", + "mounting-rotation", G_TYPE_STRING, rotation_str.c_str(), + nullptr); + return GST_DEVICE(g_object_new(GST_TYPE_LIBCAMERA_DEVICE, /* \todo Use a unique identifier instead of camera name. */ "name", name, "display-name", name, "caps", caps, "device-class", "Source/Video", + "properties", props, nullptr)); }