From patchwork Thu Jun 26 05:24:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 23656 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 91C60BDCBF for ; Thu, 26 Jun 2025 05:24:53 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C469468DE2; Thu, 26 Jun 2025 07:24:52 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=igalia.com header.i=@igalia.com header.b="ZAS2vZtp"; dkim-atps=neutral Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5997661529 for ; Thu, 26 Jun 2025 07:24:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=g1+SopzQO8Z/5Xr4T8Y0GV4v7dlMMHBSZXnKE8X8RTQ=; b=ZAS2vZtpYmnESFe4DskBwYIBP+ MFAxtQFSF7m8Hr7vkUNZ+us6/QtFaVwSGfCWe1jq3hZ1Ue2EJ0buXjqAd2+h5UpLVsaFW7rdpzA/m eSJXXkT8AjNkrebWqs/tnE3tEXA1REVhiYb52o9vA0WIPrAEOQtNy1GCe2X4F5FiT9lYF3aZyH4IM 0DTOlbxfLc7Q4O+mlMe4IfvabI5NtNfSE+b5tV2ogyJuio0+3fqq4yvT5vinLNhh16mi+UQgqsRoK 1scRFRffLq2reS9RH6BHlxIW+CCvYr4XfB2ZLGHMF2GQV8l+Zqbhu77/XXdKO1VhY9ndVtgskL5Nh nJkr5OxA==; Received: from [49.36.69.141] (helo=uajain) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1uUf6N-008qlr-Qi; Thu, 26 Jun 2025 07:24:48 +0200 From: Umang Jain To: libcamera-devel@lists.libcamera.org Cc: Umang Jain , Jacopo Mondi Subject: [PATCH v2] camera_sensor: Expand on computeTransform() documentation Date: Thu, 26 Jun 2025 10:54:41 +0530 Message-ID: <20250626052441.20305-1-uajain@igalia.com> X-Mailer: git-send-email 2.50.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The description for computeTransform() when the desired orientation cannot be achieved, can be expanded a further bit, to clearly report that orientation will be adjusted to native camera sensor mounting rotation. Signed-off-by: Umang Jain Reviewed-by: Jacopo Mondi Reviewed-by: Laurent Pinchart --- Changes in v2: - Use rotation instead of orientation for describing sensor mounting --- src/libcamera/sensor/camera_sensor.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/libcamera/sensor/camera_sensor.cpp b/src/libcamera/sensor/camera_sensor.cpp index d19b5e2e..4f2fd269 100644 --- a/src/libcamera/sensor/camera_sensor.cpp +++ b/src/libcamera/sensor/camera_sensor.cpp @@ -302,8 +302,9 @@ int CameraSensor::setEmbeddedDataEnabled(bool enable) * camera sensor, likely at configure() time. * * If the requested \a orientation cannot be obtained, the \a orientation - * parameter is adjusted to report the current image orientation and - * Transform::Identity is returned. + * parameter is adjusted to report the native image orientation (i.e. resulting + * from the physical mounting rotation of the camera sensor, without any + * transformation) and Transform::Identity is returned. * * If the requested \a orientation can be obtained, the function computes a * Transform and does not adjust \a orientation.