From patchwork Tue Jun 24 17:12:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 23646 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B535AC3237 for ; Tue, 24 Jun 2025 17:12:35 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8CCE268DF7; Tue, 24 Jun 2025 19:12:31 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="qz5e6Rcq"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9E83C61536 for ; Tue, 24 Jun 2025 19:12:27 +0200 (CEST) Received: from Monstersaurus.hippo-penny.ts.net (cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id EA7B26A6; Tue, 24 Jun 2025 19:12:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1750785130; bh=ruvTkwLj/SkKTC/SNrMWgEW7H/eoXPodGYY3DLlb97k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qz5e6RcqqrLclJ7NshBOlhxx1BIIJXG1UEXsRmAGabwShjtYozln7ib0RcPCe1sV9 RRtmuLzwVz9K2LR61A4iEK4E0mFQa8g/QFP/+alnTvPjbO/OFjEXn6Rp7E4r//iu1U 3aont+qMO4RZ5tjOWRAfjw+rSNxo2N1yy8aCl0iE= From: Kieran Bingham To: libcamera devel Cc: "van Veen, Stephan" , Kieran Bingham Subject: [PATCH 2/3] libcamera: controls: Define a new core Hue control Date: Tue, 24 Jun 2025 18:12:22 +0100 Message-ID: <20250624171223.2181226-3-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250624171223.2181226-1-kieran.bingham@ideasonboard.com> References: <20250624171223.2181226-1-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: "van Veen, Stephan" Define a new control to support configuration of Hue adjustments when supported by the available platform. Signed-off-by: van Veen, Stephan [Kieran: Split control addition and implementation and refactor commit messages] Signed-off-by: Kieran Bingham --- Open questions How should we standardise the units on this control? Should this be a scale of -1, 0, +1 and scaled to the capability of the hardware by the IPA? Or should we standardise on similar units from a colour wheel and use values in degrees (for RKISP1 use case this would be -90,0,+87.188). As the RKISP1 makes a phase shift adjustment, is this expected to be similar on other pipelines? Or should we also expect anything that would expose a full 360 degree explicit hue? (I assume not now I write that :D) Signed-off-by: Kieran Bingham --- src/libcamera/control_ids_core.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml index 028919ef3d3e..58abf8434eae 100644 --- a/src/libcamera/control_ids_core.yaml +++ b/src/libcamera/control_ids_core.yaml @@ -1281,4 +1281,14 @@ controls: The FrameWallClock control can only be returned in metadata. + - Hue: + type: float + direction: inout + description: | + Specify a fixed hue parameter. + + Positive values (up to 1.0) produce an increase of the hue angle up to + 90 degrees; negative values (up to -1.0) produce a decrease of the hue + angle down to -90 degrees. + ...