From patchwork Wed Jun 18 12:01:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cheng-Hao Yang X-Patchwork-Id: 23594 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 65983C3237 for ; Wed, 18 Jun 2025 12:02:14 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 711F468DCC; Wed, 18 Jun 2025 14:02:13 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="SEm/jma9"; dkim-atps=neutral Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F04268DC1 for ; Wed, 18 Jun 2025 14:02:11 +0200 (CEST) Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-23649faf69fso67900525ad.0 for ; Wed, 18 Jun 2025 05:02:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1750248129; x=1750852929; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=IhCIWYX1AwphQdzHNhBbg8U9fwP/rT5ClZR80O+h3Cg=; b=SEm/jma9XQJWe0rB8qLWGiz5NJa5WGtDnMlqL/KslMQQzu8DnV4Q6N15jkUrLDWyFi KC8VDOmbXhEDJVYIp43ykPz1E+hZxZ+WcJE/iLi7C0svYRo3zcwjmCRrJSiXMcU7InpR eWa918B4t00Q95fQwD1UuUxbAzps+Q3TmFQFY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750248129; x=1750852929; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IhCIWYX1AwphQdzHNhBbg8U9fwP/rT5ClZR80O+h3Cg=; b=g0qAVu7wgXwX9gKdJQUyfcgo0qLpm2wrX1K3ExosoCSJNQ5s3xLKw4HR1INewcjTXG aEoi9qA5zizLfa49bFxXKyuKydmVFROPUOxDqJa38OE++OhVQlHGEBCv+3Y/bI9EL31L kx7j6UoAH5mlujBOrH6zOLzanLxdkAgyvpCsf0hRMYxUaKbA1qOEfqambg44yF7lI9Dt BMY+B6Xflv/bLa9FFxDVl45JLATBaeP9PNL26ZAKwA8yHD25/+yabeG3Mug8V4Mzr8uy yOkHbEZJA3h9cWnA9J1VIBayI1538w7GQiTBiARhMyJS2/TWpD/JnCLSSfV10UJcO0ez C74g== X-Gm-Message-State: AOJu0YyHrQbxB4dXPLxFjK6/5McVH6wx86F9pYK7XZWs1sq6egmEGdEf pe7lzdK1kDrFxiyYOHBVpJbi9ruOKR3sXgOUckJrhtNNg+TK0POZ13Yo00Fx9UWhG7UenYa7jFi MdIU= X-Gm-Gg: ASbGncs+UJxPXUutE9fXIKNbz4aWk7znqNYXR7JeP7+q6NWHQ4+UlHG4WIpwdDmNRpQ riuVznx6GMrcliyyOmFOSqIpm8deAmJjtQHUxjGHYQevsVc3R6u1uMugWRU4WoRJOTse4fcjwTx NAJhApGujLjFBbq+a1NQ6Q3ppmNhgknbmaSodZPTeRxtxxBIWAFo/toIBQYhTAgGPV4Qp2pjtq9 5nPdZPJJV0+ouiAuZs4xZvQpFOB9HZZnqC+rdda5qkxI9wNSr7oTAHKdW0TippDMwSUVqSDUSxY UR+zalWjZFQU3l8e7FWbMdIsnllvfkZlkGYjoFIbyLxNpu4NAfY5reSmQ0NqVDbl+qVWNCDXyHG u7BRvsj0vKn+oHaJFoSh4Y+/IGPtwJD09CAEMjB65gf9FvKwvqg2gC7arPAepcBhpZQ== X-Google-Smtp-Source: AGHT+IHJcGn0g39XVlCJFPbdy5IuUNoAWb241IZBt/Ftz9VeqSYiy6SCu25sGIA8EMYiaWXfr9H6Rg== X-Received: by 2002:a17:902:ce85:b0:234:948b:91c7 with SMTP id d9443c01a7336-2366b17db88mr237464555ad.51.1750248129218; Wed, 18 Jun 2025 05:02:09 -0700 (PDT) Received: from chenghaoyang-low.c.googlers.com.com (208.158.221.35.bc.googleusercontent.com. [35.221.158.208]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365e0d0abdsm98177225ad.254.2025.06.18.05.02.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Jun 2025 05:02:08 -0700 (PDT) From: Harvey Yang X-Google-Original-From: Harvey Yang To: libcamera-devel@lists.libcamera.org Cc: Harvey Yang , Harvey Yang Subject: [PATCH] EncoderLibJpeg: Fix struct JPEGPixelFormatInfo::PixelFormatInfo Date: Wed, 18 Jun 2025 12:01:59 +0000 Message-ID: <20250618120204.3047218-1-chenghaoyang@google.com> X-Mailer: git-send-email 2.50.0.rc2.696.g1fc2a0284f-goog MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Previously, JPEGPixelFormatInfo::PixelFormatInfo is a const reference. However, the use cases of it are mostly from temporarily constructed instances, which will be destructed right after setting up JPEGPixelFormatInfo. To avoid data corruption, JPEGPixelFormatInfo::PixelFormatInfo should be a pure constant member variable instead. Signed-off-by: Harvey Yang --- src/android/jpeg/encoder_libjpeg.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/android/jpeg/encoder_libjpeg.cpp b/src/android/jpeg/encoder_libjpeg.cpp index cb242b5ec6a8..0c088535f0be 100644 --- a/src/android/jpeg/encoder_libjpeg.cpp +++ b/src/android/jpeg/encoder_libjpeg.cpp @@ -34,7 +34,7 @@ namespace { struct JPEGPixelFormatInfo { J_COLOR_SPACE colorSpace; - const PixelFormatInfo &pixelFormatInfo; + const PixelFormatInfo pixelFormatInfo; bool nvSwap; };