From patchwork Wed Jun 11 01:32:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 23536 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D8ED1C3333 for ; Wed, 11 Jun 2025 01:34:28 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 53BBE68DF8; Wed, 11 Jun 2025 03:34:28 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="Vv6Q3INo"; dkim-atps=neutral Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3773568DF0 for ; Wed, 11 Jun 2025 03:34:25 +0200 (CEST) Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-3a4f78ebec8so3674210f8f.0 for ; Tue, 10 Jun 2025 18:34:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749605664; x=1750210464; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HI49pYUXinc5VYst8KgNjwxFTmCviwBQg1gk8SwGa4M=; b=Vv6Q3INovc2VD+fZdN7w0NjpZzc6/xxIfgTfchnkb03o7Ozk8Ui9UodftqsqUYqf+U /cD8gCJBTjGpVMuy4oRXjfrJnidx6DR4hh0/i3KvWGhDzyVl/qG4WX5xWhFqquB/1fCM ui4s2xfO6Xz1qxTnZG4qqOn7zSt3EfGFQMB1PMEEBazDJMPt82yCTHdiTLf30+64MlwG 00VptdnWLGiXyLGgyCumyvN7QnSk5RKZG3aGyv1CIQNCeEHaionkxUWORpt8saIQc8yt B+z/+2ffHvl80H1uz8rdidlAI/rI2yStM8RsyvjHUbUVbGUu2/hJjFCL9pOCXn+xZc2a qdeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749605664; x=1750210464; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HI49pYUXinc5VYst8KgNjwxFTmCviwBQg1gk8SwGa4M=; b=CR3ZWYjh3gUzmczwOhOsRdk0T7kraFbRnEE7NWeSE6ahlXN9Jsqm63We5KYwVgBCJy 2QTIVxo4l82Z9GAzy1v/Tsaf0kNtje7diipDd+5nGbUowKtcjilrWZcalmw8fDnS5IJM icPBEq0zIDYYi9e4UqiNk3ZCzxf3Zb7RcFY8CtWCvwtLdf3d8E2CVsQF+xVSHXkWlvUP nj1IaBNT8CMN2bvW/ccIhUdFnfEUIb83cE17ilI3u1Vr8q82t01uqurHSIDN+GpF5LbV rB03FzJ9gSdDvjZYtLhz7Jm6P8+J/jIPUsJrWKOJ0ZypJ6wyKXW2CCy0m25jc8dC6etG DNFQ== X-Gm-Message-State: AOJu0YzJbmeEbPnVSzRZXNVD/jscQR5oztIhOn/jYzOLerv8x9AReuS6 e8/ddYPU5yuSZeUGH2+fyZyX5kRBH3taBueZVHMFzcRqWoGj5A7KVIzIsN6YUCJfAnZG3i2XL+X YHGsMYk4= X-Gm-Gg: ASbGncuPKuif2MJ8uxysg0M8eMcaoaoXi6HMLh5PR/XPdtJfcZWsJt6IlaFlP3iqQp9 0wvVUvR0dk4g0AzT6VUQBnHqFZL+s2HFdkkr8rBanyes4uJOw+ET76+5jpIU7CCXOF872M2hdee rx9bVsKzaD5HZPwETCsoJWzot2+ggCDReqrw/YTfvqH+hrep2ErKupD+aU36kN1/o42kJAyk9R/ QJXU8uguXguPxeEhmUUsBDYPTOYsnkGKX8by7mHRtnI6734mbqBCXhee03VnvcKD4sMPgOKeilh LJI6G5hRYsnPArfi1rJ88IEbaTE1PPWcCuqhMdi+Ipi1xm8sOzD1fw/sT18xAyCy2yV727DhS74 dm7up2IrJ2RRgNh+E1BPGl+sTcI3Sw0XKNoNkk9ZWccsdW6aDQAyu X-Google-Smtp-Source: AGHT+IFNonVCs10alOBA/xOndvNC/XdHixkaWZP8bBP6SF/LUlu+yLaKuB81KvQen6zSInKa8o4cTA== X-Received: by 2002:a05:6000:4025:b0:3a4:f723:3e73 with SMTP id ffacd0b85a97d-3a558aad7b3mr698227f8f.16.1749605664601; Tue, 10 Jun 2025 18:34:24 -0700 (PDT) Received: from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532514138asm5680625e9.3.2025.06.10.18.34.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 18:34:24 -0700 (PDT) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: Bryan O'Donoghue Subject: [PATCH 30/35] libcamera: software_isp: debayer_cpu: Make getInputConfig and getOutputConfig static Date: Wed, 11 Jun 2025 02:32:40 +0100 Message-ID: <20250611013245.133785-31-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250611013245.133785-1-bryan.odonoghue@linaro.org> References: <20250611013245.133785-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Make getInputConfig and getOutputConfig static so as to allow for interrogation of the supported pixel formats prior to object instantiation. Do this so as to allow the higher level logic make an informed choice between CPU and GPU ISP based on which pixel formats are supported. Curretnly CPU ISP supports more diverse input and output schemes. Signed-off-by: Bryan O'Donoghue --- src/libcamera/software_isp/debayer_cpu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h index a043a954..999e3421 100644 --- a/src/libcamera/software_isp/debayer_cpu.h +++ b/src/libcamera/software_isp/debayer_cpu.h @@ -102,8 +102,8 @@ private: template void debayer10P_RGRG_BGR888(uint8_t *dst, const uint8_t *src[]); - int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config); - int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config); + static int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config); + static int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config); int setupStandardBayerOrder(BayerFormat::Order order); int setDebayerFunctions(PixelFormat inputFormat, PixelFormat outputFormat,