From patchwork Wed Jun 11 01:32:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 23508 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 79DD4BDE6B for ; Wed, 11 Jun 2025 01:33:05 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id E2D1568DC4; Wed, 11 Jun 2025 03:33:04 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="tiE1OPAx"; dkim-atps=neutral Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E002368DC1 for ; Wed, 11 Jun 2025 03:33:03 +0200 (CEST) Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-442f9043f56so35111155e9.0 for ; Tue, 10 Jun 2025 18:33:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749605583; x=1750210383; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=smZwtpbTz29j4hcPfA9P6oUHmTi9LVToPOlGCRTmB7Y=; b=tiE1OPAxuUH0PcJP+w6lNKSKzysS5pzNZ6zMftNgKoNwOUHGTWlXpsrhFGES6UKnPa JpIqv5hEj59NRN7I2caQJ23KeBq87VVuBHkGNE4qV1mFv7BhvJeXJEcXIdxbH6n/9e8P e/Sc8J28v/2sJZwKGEUlUHhim/TzBymGsT3z///2V9AxBgEG7YikvZZTyFzCtn4kAXST myIYt7See2XcDIHtiY8h5LhaGjdt669mgkebAo4qrA29YynepsPjc2Ta43iF1QfBtDfV ZjIhLh4WqEQxxL00EI5bPNG3PfxandJx8viBoqSfv+nvyc5Tu0F6NOOMDXIfsMMhLepk 2LQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749605583; x=1750210383; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=smZwtpbTz29j4hcPfA9P6oUHmTi9LVToPOlGCRTmB7Y=; b=AOtHL8CaL+X6t/Hh3hfYVWh2sxf8xOnFGeWUdnjC1KGbeFtBQIct7dmMq4sZoVPrDV ncLsUFhrs2Q7MFdG4VKcI/288X4PNou+6h3yv+R6giy0XfMVJAsX7cnvEvcTKA5Oi7SP 5rtecsE9f66GvQHPNzIkCIC6ypadyHWf0PuZu+Pb7hSasjKs1UJ7PnPi85vJJ80oYjaB EJxOUU2JVwHohed5BNVZn3Hkt52RBFuBZHZ8o2kctwSIsr53YsWPvwvuBZrc6bcKnQIQ P3CvAKBUWkbqpFuJiAm8hKO5/5e7PHSNvbMQaWSHlhfeVNwhYJVZ2UZpraEZ730wRx1I wtng== X-Gm-Message-State: AOJu0YxwNjB3dHeEVF0Da7do4XkKwLbtj2xRZsJYLahZE2U4S59vpljx w/Kzs07rFvIMdk8uOdlRBsGsnt3Y1foZaitmL16AxbGh3EMqlHylf1UXgzt9evQnAH+D0V18ZW2 JcMGkQ5Y= X-Gm-Gg: ASbGncshgeyTruTUbLg+xb0YuBxyj/L15BWhdAf/Bdw0kLYbxv+OKa/IhKTMtOkb+p0 /RSYn1mjLOKnohEVrCZSHtQfu3uiwHxF1J3Oc+HhWCQhNSvVXrh1Qina39W8XSK79O8NvujySC8 JmV4qY1YA0V3GK61DTnQltLlxLyaDpQHQBYjbHV+0WH2kI01HqYwe7p7/RYN5ets13fIgkg2gNv GMunrQvQIMnGhYcqfBPg0KV1nqfx+kHx89uSbwQKbLfNkeago5JP7GCyeUUfLHAq5y0CGCrbx4H fCP3IaeMxDROHEJY8PYjzmTgU3yFxs51rC209cJke10Cf8LL7F/juDP0jzNiX4yg07MMtNsAfWZ +26RVMLi+llmUUDqIH38gt1TPDp0DOr8vpSMBDai58Q== X-Google-Smtp-Source: AGHT+IH+VgSDXGeT5oVvvQndVYrMYU3vpEC7jcxBca/+Y6iTCr5FVINIddpYAOHssZuYA28v/rFbbw== X-Received: by 2002:a05:600c:a318:b0:44a:775d:b5e8 with SMTP id 5b1f17b1804b1-45324abda5emr4300245e9.1.1749605583271; Tue, 10 Jun 2025 18:33:03 -0700 (PDT) Received: from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532514138asm5680625e9.3.2025.06.10.18.32.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 18:33:02 -0700 (PDT) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: Hans de Goede , Kieran Bingham , Milan Zamazal , Bryan O'Donoghue Subject: [PATCH 02/35] libcamera: swstats_cpu: Drop patternSize_ documentation Date: Wed, 11 Jun 2025 02:32:12 +0100 Message-ID: <20250611013245.133785-3-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250611013245.133785-1-bryan.odonoghue@linaro.org> References: <20250611013245.133785-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Hans de Goede patternSize_ is a private variable and its meaning is already documented in the patternSize() getter documentation. Move the list of valid sizes to the patternSize() getter documentation and drop the patternSize_ documentation. While at it also add 1x1 as valid size for use with future support of single plane non Bayer input data. Reviewed-by: Kieran Bingham Reviewed-by: Milan Zamazal Signed-off-by: Hans de Goede Signed-off-by: Bryan O'Donoghue --- src/libcamera/software_isp/swstats_cpu.cpp | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp index a9a3e77a..5e4246a9 100644 --- a/src/libcamera/software_isp/swstats_cpu.cpp +++ b/src/libcamera/software_isp/swstats_cpu.cpp @@ -58,6 +58,8 @@ namespace libcamera { * also indicates if processLine2() should be called or not. * This may only be called after a successful configure() call. * + * Valid sizes are: 1x1, 2x2, 4x2 or 4x4. + * * \return The pattern size */ @@ -112,13 +114,6 @@ namespace libcamera { * \brief Statistics window, set by setWindow(), used every line */ -/** - * \var Size SwStatsCpu::patternSize_ - * \brief The size of the bayer pattern - * - * Valid sizes are: 2x2, 4x2 or 4x4. - */ - /** * \var unsigned int SwStatsCpu::xShift_ * \brief The offset of x, applied to window_.x for bayer variants