From patchwork Fri Jun 6 16:41:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 23491 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A4E24C31E9 for ; Fri, 6 Jun 2025 16:42:42 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1027368DCA; Fri, 6 Jun 2025 18:42:42 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="HalIKhkm"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id AE02668DC9 for ; Fri, 6 Jun 2025 18:42:17 +0200 (CEST) Received: from pb-laptop.local (185.182.215.79.nat.pool.zt.hu [185.182.215.79]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 34F9B11DD for ; Fri, 6 Jun 2025 18:42:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1749228133; bh=M1CNsryuizApYzNyJSEgga9OUl+tNty6V9mro8Qlmb8=; h=From:To:Subject:Date:In-Reply-To:References:From; b=HalIKhkmAyhAiZsryUT2alG/N+9G3ymo1RISnYj7jRsODK5pIKszIOWzsuU1AjsRn s3kaVOLgcZImzxWCaBrkBXhnXoOyaLqiduQTAsbJICK6i1YD4GC++P34SJqd+SUdpu JJHoU1Vw2fSLd2mjwXOhyEHTaLmZV8itk0QLxh/I= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [RFC PATCH v1 10/23] libcamera: camera: Store `MetadataListPlan` in `Camera::Private` Date: Fri, 6 Jun 2025 18:41:43 +0200 Message-ID: <20250606164156.1442682-11-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250606164156.1442682-1-barnabas.pocze@ideasonboard.com> References: <20250606164156.1442682-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Just like `ControlInfoMap controlInfo_` is a public member of the private camera data for pipeline handlers to populate, add a `MetadataListPlan` as well for the pipeline handlers to fill. This will be used to initialize the `MetadataList` of each request created by the camera. Signed-off-by: Barnabás Pőcze Reviewed-by: Jacopo Mondi --- include/libcamera/internal/camera.h | 3 +++ src/libcamera/camera.cpp | 8 ++++++++ 2 files changed, 11 insertions(+) diff --git a/include/libcamera/internal/camera.h b/include/libcamera/internal/camera.h index 18f5c32a1..d5d869887 100644 --- a/include/libcamera/internal/camera.h +++ b/include/libcamera/internal/camera.h @@ -17,6 +17,7 @@ #include #include +#include namespace libcamera { @@ -41,6 +42,8 @@ public: uint32_t requestSequence_; + MetadataListPlan metadataPlan_; + const CameraControlValidator *validator() const { return validator_.get(); } private: diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp index c180a5fdd..31f5ad94b 100644 --- a/src/libcamera/camera.cpp +++ b/src/libcamera/camera.cpp @@ -660,6 +660,14 @@ Camera::Private::~Private() * over a single capture session. */ +/** + * \var Camera::Private::metadataPlan_ + * \brief The set of metadata supported by the camera + * + * The metadata information shall be initialised by the pipeline handler when + * creating the camera. + */ + static const char *const camera_state_names[] = { "Available", "Acquired",