From patchwork Tue Jun 3 13:45:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 23460 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 28F4BC31E9 for ; Tue, 3 Jun 2025 13:45:43 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 0F6B268D94; Tue, 3 Jun 2025 15:45:41 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="tyVV8taf"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 13E7C614D5 for ; Tue, 3 Jun 2025 15:45:39 +0200 (CEST) Received: from pb-laptop.local (185.182.214.140.nat.pool.zt.hu [185.182.214.140]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B3DCC496 for ; Tue, 3 Jun 2025 15:45:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1748958337; bh=bnHxDRCYY4WXaXb704lsUKTFMjof2pGalEO1dOUClw8=; h=From:To:Subject:Date:From; b=tyVV8tafpgx0eC1Q4f+zzwHphD/d1SJON/riWuVn6FJ7chiUv9Pm0cGr2gkdQqhFm Cxo7DU3QGwqMBx08qkNPEFWnibvp+5/C6aZ2HMghn0l5ivLlQT9PfXhxSOsdYmWBfG Ec6wrLgTNpmlm5M9jotcSPdWdPEiEw7JSu5q/yPI= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [PATCH v1] android: camera_device: Do not pass `nullptr` to `Request::addBuffer()` Date: Tue, 3 Jun 2025 15:45:35 +0200 Message-ID: <20250603134535.772886-1-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The default argument already takes care of passing no fence to `addBuffer()`, so there is no reason to specify `nullptr` explicitly. Signed-off-by: Barnabás Pőcze Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- src/android/camera_device.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp index a038131ae..5dfa1fe22 100644 --- a/src/android/camera_device.cpp +++ b/src/android/camera_device.cpp @@ -1078,8 +1078,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques FrameBuffer *frameBuffer = cameraStream->getBuffer(); buffer.internalBuffer = frameBuffer; - descriptor->request_->addBuffer(sourceStream->stream(), - frameBuffer, nullptr); + descriptor->request_->addBuffer(sourceStream->stream(), frameBuffer); requestedStreams.insert(sourceStream); }