From patchwork Wed May 28 12:18:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Niklas_S=C3=B6derlund?= X-Patchwork-Id: 23456 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 9647DC3292 for ; Wed, 28 May 2025 12:20:14 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 333D468DA6; Wed, 28 May 2025 14:20:14 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=ragnatech.se header.i=@ragnatech.se header.b="WP5qnnxm"; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="DZ6GGa36"; dkim-atps=neutral Received: from fout-a5-smtp.messagingengine.com (fout-a5-smtp.messagingengine.com [103.168.172.148]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5E400614CE for ; Wed, 28 May 2025 14:20:10 +0200 (CEST) Received: from phl-compute-03.internal (phl-compute-03.phl.internal [10.202.2.43]) by mailfout.phl.internal (Postfix) with ESMTP id A2C141383AE9; Wed, 28 May 2025 08:20:09 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-03.internal (MEProxy); Wed, 28 May 2025 08:20:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech.se; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1748434809; x=1748521209; bh=Th59CAVXAcgQNqVt2pSLs4lYt5ZtT33gKvEq3cPTCtc=; b= WP5qnnxmt1d/olWqItOZ0AD+pY+IUF/mUSBsh82fJc/8dtXQr1OXwmUCxNmKGRUt furZEq2c/Jm/wDnnbGUj52ORN/gZYkblbM55QFi/JTesHqdwZe29xFeT3idydevO gajTdUIPKx6d4q2XZ/vnnYOeQW/GaaK7fG6q+J5lhOgf3WELM3D2wy/KFV7JTdZ1 4jkRYRvZ80PbZZaBZZacb0EL6zKa2alxKFN+Fk35eGTTQos0w2pYOL8m15XstMpH 6SEsfYgdPO5M7xl2VXFCM6hz1KKPNJZ5PzvcAH7864TukQboUqW0oOIaRmae8Llo 0FyPTn3Hh5S0fiaXbOEGrg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1748434809; x= 1748521209; bh=Th59CAVXAcgQNqVt2pSLs4lYt5ZtT33gKvEq3cPTCtc=; b=D Z6GGa36xezNwY5MvwQV6gfKN+HWRS4Ly1/iRdjgR9SY51LjhgD0+GfaYbBWiHSII P1RJqLKO6751t3Z1CfttT8yrVE0WfRRRox/h8SlM98wC1ycYw2g77Gxl+xfWMULv Hvj4EOg+rQLijEj4P8XnnpvJaABd94CfV3hlmOisWs3gi0HF5Z5jCAVJVRqmlVOd nQqJogWT6Htmn5Ryknho4aIjPkJM6VGwqcbP8JGkJ3ciEID4akh119n7s2fthrmv NX60Ga7nOKxK4a0vFqvvPgUDPAR1+v5v3SBv8XCG9X3zqn8+Vj2DdfpPHe8qQ+kt jak8D4uzN7wdS+qWOwBoQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddtgddvfedvgeculddtuddrgeefvddrtd dtmdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggft fghnshhusghstghrihgsvgdpuffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftd dtnecunecujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhm pefpihhklhgrshcuufpnuggvrhhluhhnugcuoehnihhklhgrshdrshhouggvrhhluhhnug esrhgrghhnrghtvggthhdrshgvqeenucggtffrrghtthgvrhhnpedtjeegkeeiudffhefh gedugeefueekkeffgeeltdeifeekheejveeifeffheevueenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehnihhklhgrshdrshhouggvrhhluhhn ugesrhgrghhnrghtvggthhdrshgvpdhnsggprhgtphhtthhopedvpdhmohguvgepshhmth hpohhuthdprhgtphhtthhopehlihgstggrmhgvrhgrqdguvghvvghlsehlihhsthhsrdhl ihgstggrmhgvrhgrrdhorhhgpdhrtghpthhtohepnhhikhhlrghsrdhsohguvghrlhhunh gusehrrghgnhgrthgvtghhrdhsvg X-ME-Proxy: Feedback-ID: i80c9496c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 28 May 2025 08:20:08 -0400 (EDT) From: =?utf-8?q?Niklas_S=C3=B6derlund?= To: libcamera-devel@lists.libcamera.org Cc: =?utf-8?q?Niklas_S=C3=B6derlund?= Subject: [PATCH 2/2] guides: pipeline-handler: Update name of pipeline handler stop function Date: Wed, 28 May 2025 14:18:27 +0200 Message-ID: <20250528121827.87844-3-niklas.soderlund@ragnatech.se> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250528121827.87844-1-niklas.soderlund@ragnatech.se> References: <20250528121827.87844-1-niklas.soderlund@ragnatech.se> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Since commit f6b6f15b54c2 ("libcamera: pipeline: Introduce stopDevice()") the stop function needed to be implemented by pipeline handlers where renamed to stopDevice(). Update the pipeline handler writers guide to match this. Signed-off-by: Niklas Söderlund Reviewed-by: Jai Luthra Reviewed-by: Laurent Pinchart --- Documentation/guides/pipeline-handler.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst index fe7529759650..3adb9ce24a85 100644 --- a/Documentation/guides/pipeline-handler.rst +++ b/Documentation/guides/pipeline-handler.rst @@ -213,7 +213,7 @@ implementations for the overridden class members. std::vector> *buffers) override; int start(Camera *camera, const ControlList *controls) override; - void stop(Camera *camera) override; + void stopDevice(Camera *camera) override; int queueRequestDevice(Camera *camera, Request *request) override; @@ -247,7 +247,7 @@ implementations for the overridden class members. return -1; } - void PipelineHandlerVivid::stop(Camera *camera) + void PipelineHandlerVivid::stopDevice(Camera *camera) { } @@ -1152,7 +1152,7 @@ available to the devices which have to be started and ready to produce images. At the end of a capture session the ``Camera`` device needs to be stopped, to gracefully clean up any allocated memory and stop the hardware devices. Pipeline handlers implement two functions for these purposes, the -``start()`` and ``stop()`` functions. +``start()`` and ``stopDevice()`` functions. The memory initialization phase that happens at ``start()`` time serves to configure video devices to be able to use memory buffers exported as dma-buf