From patchwork Wed May 21 13:21:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Scally X-Patchwork-Id: 23413 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 8A961BD78E for ; Wed, 21 May 2025 13:21:36 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 6C3E168D97; Wed, 21 May 2025 15:21:34 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="CNd0M4TK"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id BCE0168D85 for ; Wed, 21 May 2025 15:21:30 +0200 (CEST) Received: from [127.0.1.1] (cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3960F9E5; Wed, 21 May 2025 15:21:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1747833669; bh=iTMoWhQ1HTY+rynjybrVk6/R4TSeYAmMTbJcHmzyT2w=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=CNd0M4TKfvEToZ3JQuIGsEDONU1Yra/dCht2+UAQZBQYk9SLlRm+vo3EyoclMuT5x lpmJpmOHZmshB/fIpgf2Z5gxPL4Zs4XiHSZthGfOyp0ROiO9hhII5xPJUyxM3igxL7 K8YRFlX+DVkDrfkA0g45SsGJZdyYb5ee/4DcoWyA= From: Daniel Scally Date: Wed, 21 May 2025 14:21:01 +0100 Subject: [PATCH 1/2] libcamera/mali-c55: Remove tpgCodes_ MIME-Version: 1.0 Message-Id: <20250521-djrscally-c55-cleanup-v1-1-aa171b2aed38@ideasonboard.com> References: <20250521-djrscally-c55-cleanup-v1-0-aa171b2aed38@ideasonboard.com> In-Reply-To: <20250521-djrscally-c55-cleanup-v1-0-aa171b2aed38@ideasonboard.com> To: libcamera-devel@lists.libcamera.org Cc: Daniel Scally X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1196; i=dan.scally@ideasonboard.com; h=from:subject:message-id; bh=iTMoWhQ1HTY+rynjybrVk6/R4TSeYAmMTbJcHmzyT2w=; b=owEBbQKS/ZANAwAKAchJV3psRXUyAcsmYgBoLdNYpQOybcc+uEh64PH0S0ZEofixS7kCoRdNp zWu/nZX4PKJAjMEAAEKAB0WIQQqyuwyDnZdb+mxmm/ISVd6bEV1MgUCaC3TWAAKCRDISVd6bEV1 MsghEACj7GPYGVyH7ZivlRXb1ghKHRaEtydGg1nFPMe9fF9qVygHTzfXR0kkivpLmAwM7OOm1bS qMannCuXxPNBBGiM6u1FGLB7ZyKmDK8Fh3RRS3YVNM/fi8G122xDBhAmEkaIqzS7tajdLa0baoT 4TJ5k3uVGSJhf1bKD05MCKh3AGGVvpRZ9Pq4uxGEzrMOjb9ceRWISIKQg3q3cESa1i1NTJWxh2F A77mWttLKROG2LxM8UQCCfJ38xRMKXH1rc9kr5fJ80JNd3bD70upFvWwlRBptwWF4JlWVX3z+Xy f6eC3duBFaQTse+T9fUSs2cAPtxY8GaSp45iQYh2ED0LsGPCstixQXDr1QXSoymoy0rWASow9hQ v4GQP60GajfpPg1H+sn+g6YJkH4W3xrLRm4iREfYpK7A0EubtpHYd7fM5VKTfYjZXDseqjnsUXR Uhq5nwDj8jMMlyjaV6VeRF6HeglMwKloqGTRji9QgwFe/mYLfVG8WuWeEascn+Zx2+TSlh3ejsc kwehOVp6/GwPvq1MhC7RVW/bx8M+CSoqePCA8kMbcscu7MzsjW6STDwSeSLstyYYkNbJIJEZNSp +TjWmUWVBee/9LvF8DNt3KbVTGxdXsiiPh6d9bFenZH8kJ5rVkVmCBGxBzn66DOaVx7HyB3LaDG 8UrioQSgNc7mRvQ== X-Developer-Key: i=dan.scally@ideasonboard.com; a=openpgp; fpr=EEC699ACA1B7CB5D31330C0BBD501C2A3546CCF6 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" MaliC55CameraData stores a vector of the TPG's mbus codes (if the camera in question is a TPG). This is never used - remove it. Signed-off-by: Daniel Scally Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- src/libcamera/pipeline/mali-c55/mali-c55.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp index a05e11fccf8dfde1a0eeda994afe2d78d884c530..35372ee1ed6f694166c395088c65509d32b9d1f2 100644 --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp @@ -131,7 +131,6 @@ private: void setSensorControls(const ControlList &sensorControls); std::string id_; - std::vector tpgCodes_; std::vector tpgSizes_; Size tpgResolution_; }; @@ -180,9 +179,6 @@ void MaliC55CameraData::initTPGData() if (formats.empty()) return; - tpgCodes_ = utils::map_keys(formats); - std::sort(tpgCodes_.begin(), tpgCodes_.end()); - for (const auto &format : formats) { const std::vector &ranges = format.second; std::transform(ranges.begin(), ranges.end(), std::back_inserter(tpgSizes_),