From patchwork Wed Nov 20 01:55:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Niklas_S=C3=B6derlund?= X-Patchwork-Id: 2338 Return-Path: Received: from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net [195.74.38.229]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id BC95661C19 for ; Wed, 20 Nov 2019 02:55:33 +0100 (CET) X-Halon-ID: d5fc48a0-0b38-11ea-a00b-005056917a89 Authorized-sender: niklas@soderlund.pp.se Received: from bismarck.berto.se (p54ac5865.dip0.t-ipconnect.de [84.172.88.101]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA id d5fc48a0-0b38-11ea-a00b-005056917a89; Wed, 20 Nov 2019 02:55:32 +0100 (CET) From: =?utf-8?q?Niklas_S=C3=B6derlund?= To: libcamera-devel@lists.libcamera.org Date: Wed, 20 Nov 2019 02:55:03 +0100 Message-Id: <20191120015506.362440-8-niklas.soderlund@ragnatech.se> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191120015506.362440-1-niklas.soderlund@ragnatech.se> References: <20191120015506.362440-1-niklas.soderlund@ragnatech.se> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 07/10] libcamera: pipeline_handler: Do not use argument as local variable X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Nov 2019 01:55:34 -0000 In completeRequest() the request argument is used as a local variable, this is confusing. Add a separate local variable instead of reusing the argument. Signed-off-by: Niklas Söderlund Reviewed-by: Jacopo Mondi Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- src/libcamera/pipeline_handler.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp index 884feaa6ecbd4851..4349ca8957e403fe 100644 --- a/src/libcamera/pipeline_handler.cpp +++ b/src/libcamera/pipeline_handler.cpp @@ -409,13 +409,13 @@ void PipelineHandler::completeRequest(Camera *camera, Request *request) CameraData *data = cameraData(camera); while (!data->queuedRequests_.empty()) { - request = data->queuedRequests_.front(); - if (request->status() == Request::RequestPending) + Request *req = data->queuedRequests_.front(); + if (req->status() == Request::RequestPending) break; - ASSERT(!request->hasPendingBuffers()); + ASSERT(!req->hasPendingBuffers()); data->queuedRequests_.pop_front(); - camera->requestComplete(request); + camera->requestComplete(req); } }